Skip to content

Fix faulty return type hint.#254

Closed
martinssipenko wants to merge 2 commits intooptimizely:masterfrom
martinssipenko:patch-1
Closed

Fix faulty return type hint.#254
martinssipenko wants to merge 2 commits intooptimizely:masterfrom
martinssipenko:patch-1

Conversation

@martinssipenko
Copy link
Copy Markdown

@martinssipenko martinssipenko commented Sep 16, 2022

Summary

Fixes faulty return type hint which leads to PHPStan reporting following error when I implement UserProfileServiceInterface.

Return type (array<int, mixed>|null) of method App\UserProfileService::lookup()
should be compatible with return type (Optimizely\UserProfile\userProfile) of
method Optimizely\UserProfile\UserProfileServiceInterface::lookup()

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 3, 2022

Coverage Status

Coverage decreased (-0.3%) to 97.149% when pulling 5f7c64d on martinssipenko:patch-1 into fa9a3bf on optimizely:master.

@martinssipenko
Copy link
Copy Markdown
Author

@msohailhussain I believe CI checks are unrelated to my changes, could you please advise on how to move this foreward?

@rafinutshaw-optimizely
Copy link
Copy Markdown
Contributor

Hi @martinssipenko ,
We've just published a patch version of the Optimizely PHP SDK to https://packagist.org/packages/optimizely/optimizely-sdk

Please update your PHP application, and you should be good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants