HTTPProjectConfigManager: datafile should be a string#243
Merged
msohailhussain merged 2 commits intooptimizely:masterfrom May 12, 2022
Merged
HTTPProjectConfigManager: datafile should be a string#243msohailhussain merged 2 commits intooptimizely:masterfrom
msohailhussain merged 2 commits intooptimizely:masterfrom
Conversation
By using `->getContents()` the actual string is returned instead of a Guzzle Stream object. The interface uses string everywhere.
Contributor
msohailhussain
left a comment
msohailhussain
left a comment
There was a problem hiding this comment.
changes seem fine to me. Let's do our internal testing and will merge if it is passed.
Contributor
Author
|
Thanks a lot for looking into this @msohailhussain. I tested it in our project. Is there already and update on internal testing? :) Thanks again! |
Contributor
msohailhussain
suggested changes
May 4, 2022
Contributor
msohailhussain
left a comment
msohailhussain
left a comment
There was a problem hiding this comment.
PR looks good, please update the Copyright header.
zashraf1985
approved these changes
May 4, 2022
Contributor
|
@adri waiting for CLA and one change request. Also update the branch. |
Contributor
Author
|
@msohailhussain Done! |
msohailhussain
approved these changes
May 12, 2022
Contributor
msohailhussain
left a comment
msohailhussain
left a comment
There was a problem hiding this comment.
lgtm!!! need to update copyright header.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
->getContents()the actual string is returned instead of a Guzzle Stream object. The interface uses string everywhere.