Removes error silencing from IsFailForwardEnabled

[m1kola]

Description of the change:

• IsFailForwardEnabled is currently silincing errors from List method. This change makes it propogate errors to the caller.
• Also IsFailForwardEnabled currently has a specifal case for situation where there are 0 OperatorGroups (len(ogs) == 0) which no longer makes sense: one OperatorGroups is required. This now falls into more generic len(ogs) != 1 condition.

Main change is in pkg/controller/registry/resolver/fail_forward.go. Everything else is just updates required to fix tests: many of them were working without a fake operator group before.

Motivation for the change:

Follow up from this conversation - #2952 (comment).

Architectural changes:

Change in how we handle zero OperatorGroups.

Testing remarks:

Existing tests should cover the change.

Reviewer Checklist

• Implementation matches the proposed design, or proposal is updated to match implementation
• Sufficient unit test coverage
• Sufficient end-to-end test coverage
• Bug fixes are accompanied by regression test(s)
• e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
• tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
• Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
• Docs updated or added to /doc
• Commit messages sensible and descriptive
• Tests marked as [FLAKE] are truly flaky and have an issue
• Code is properly formatted

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[m1kola]

Note: there is a lot of copy-pasted newOperatorGroup("foo", namespace) lines. What is not very visible in the diff is that there are some calls for newOperatorGroup where strategy is set to fail forward.

Previously presence of OG in cluster state was not required in this test (and in others in this PR) because was len(ogs) == 0 condition in IsFailForwardEnabled which was returning a default value for a timeout and now we explicitly return an error in this case. So tests had to be updated.

[perdasilva]

/approve

[perdasilva]

lgtm - thank you!!!!

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: m1kola, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [perdasilva]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[grokspawn]

/lgtm