🌱 Add check for client in e2e - #1529
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1529 +/- ##
=======================================
Coverage 74.68% 74.68%
=======================================
Files 42 42
Lines 3271 3271
=======================================
Hits 2443 2443
Misses 652 652
Partials 176 176
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Depending on how e2e is run, we may not have a k8s client available. Signed-off-by: Todd Short <tshort@redhat.com>
c89fae9 to
854432d
Compare
camilamacedo86
left a comment
There was a problem hiding this comment.
/lgtm
We need to do the same in the catalogd
and probably in the future have this logic as an utils / func to just re-use in any test
Thank you. That was a good thought
|
Ok, I'll make a corresponding change to catalogd. |
|
See operator-framework/catalogd#485 @camilamacedo86 for the catalogd version |
Depending on how e2e is run, we may not have a k8s client available.
Description
Reviewer Checklist