🌱 Add golang version check to verify - #1257
Closed
tmshort wants to merge 1 commit into
Closed
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
joelanford
reviewed
Sep 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1257 +/- ##
==========================================
- Coverage 76.49% 76.18% -0.32%
==========================================
Files 40 40
Lines 2336 2330 -6
==========================================
- Hits 1787 1775 -12
- Misses 392 398 +6
Partials 157 157
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
joelanford
reviewed
Sep 11, 2024
joelanford
reviewed
Sep 11, 2024
Contributor
Author
|
All passing now |
perdasilva
reviewed
Sep 12, 2024
This makes sure that we are not exceeding our golang version Supported golang version is 1.22.5 Signed-off-by: Todd Short <tshort@redhat.com>
Contributor
Author
|
Closing in favor of #1264 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes sure that we are not exceeding our golang version Supported golang version is 1.22.5
Description
Reviewer Checklist