🌱 (fix) Revert: Check cluster is running for non-standalone Make targets - #461
🌱 (fix) Revert: Check cluster is running for non-standalone Make targets#461camilamacedo86 wants to merge 2 commits into
Conversation
)" This reverts commit b30eb4a.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #461 +/- ##
=======================================
Coverage 38.23% 38.23%
=======================================
Files 15 15
Lines 1224 1224
=======================================
Hits 468 468
Misses 706 706
Partials 50 50 ☔ View full report in Codecov by Sentry. |
|
I removed from the queue. Just wanted to discuss this a bit more because:
|
|
@camilamacedo86 can you point to a where the e2e or upgrade-e2e tests failed as a result of #437? |
|
Hi @joelanford
See the description: #461 (comment) |
|
That job didn't fail. |
|
HI @joelanford
Not because. As far as I can see, the check is wrong and not helpful for anything. |
|
It is closed in favour: #465 |
Reverts #437
If we see the logs https://github.com/operator-framework/catalogd/actions/runs/11819448861/job/32929383546 (ci job of PR where the change was introduced), we can see that this check is wrong and is always failing:
PS.: I don't think there's a need for this check. Proof of that is that besides it does not work, nothing changed. Therefore, I do not see value in this one.
Instead, I would prefer the targets of this project to be as similar as possible to those of https://github.com/operator-framework/operator-controller so that life for us contributors is easier.