✨MIXEDARCH-242 - Updated multi-arch report to use the operator-framework/api multi-arch validator. - #144
Merged
bentito merged 3 commits intoApr 12, 2023
Conversation
Contributor
Author
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
jaypoulz
changed the title
jaypoulz
force-pushed
the
multiarch-valiator-from-api
branch
from
February 23, 2023 19:38
a145ede to
ff15bc5
Compare
Contributor
Author
|
I threw a hold on this since I never tested it with the vanilla operator-framework/api, just my updated version (operator-framework/api#276 ✔️). I think that we should land the API PR first, then this one, and then finally the operator-sdk docs update (operator-framework/operator-sdk#5983) |
jaypoulz
force-pushed
the
multiarch-valiator-from-api
branch
2 times, most recently
from
April 11, 2023 15:03
55c62d5 to
cc7d4b5
Compare
jaypoulz
changed the title
jaypoulz
changed the title
Contributor
Author
|
/unhold This PR now uses the recently landed patch to the operator-framework/api. |
openshift-ci
Bot
removed
the
do-not-merge/hold
Contributor
Author
|
I will upload an html report taken against the latest 4.12 image index to show what the updates look like. |
Collaborator
|
/lgtm |
openshift-ci
Bot
added
lgtm
|
New changes are detected. LGTM label has been removed. |
jaypoulz
force-pushed
the
multiarch-valiator-from-api
branch
from
April 12, 2023 17:45
e200fe0 to
ec84e6a
Compare
Contributor
Author
|
Here is a (somewhat restricted) link to an HTML report for the 4.12 redhat-operators index |
jaypoulz
force-pushed
the
multiarch-valiator-from-api
branch
from
April 12, 2023 19:41
ec84e6a to
25ad5ee
Compare
Pull Request Test Coverage Report for Build 4682229154
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the internal validation mechanism of the multi-arch validator to use the logic in operator-framework/api instead of maintaining its own.