Skip to content

Restores openapi-gen tag for APIResourceReference - #283

Merged
openshift-merge-robot merged 1 commit into
operator-framework:masterfrom
m1kola:fix_openapi_codegen
Apr 25, 2023
Merged

Restores openapi-gen tag for APIResourceReference#283
openshift-merge-robot merged 1 commit into
operator-framework:masterfrom
m1kola:fix_openapi_codegen

Conversation

@m1kola

@m1kola m1kola commented Apr 25, 2023

Copy link
Copy Markdown
Member

It looks like it was accidentally removed in #168.

Now when we update github.com/operator-framework/api package for OLM, packageserver fails with the following error:

unable to get openapi models: cannot find model definition for github.com/operator-framework/api/pkg/operators/v1alpha1.APIResourceReference. If you added a new type, you may need to add +k8s:openapi-gen=true to the package or type and run code-gen again

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 25, 2023
@m1kola
m1kola marked this pull request as ready for review April 25, 2023 11:07
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 25, 2023
@openshift-ci
openshift-ci Bot requested review from ankitathomas and oceanc80 April 25, 2023 11:07

@ankitathomas ankitathomas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2023
@grokspawn

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ci Bot commented Apr 25, 2023

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, m1kola

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2023

@everettraven everettraven left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-merge-robot
openshift-merge-robot merged commit 047ab0b into operator-framework:master Apr 25, 2023
@m1kola
m1kola deleted the fix_openapi_codegen branch April 25, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants