update k8s 1.25 validation logic - #270
Merged
openshift-merge-robot merged 3 commits intoOct 28, 2022
Merged
Conversation
to look for deprecated k8s APIs in various CSV fields Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
jmrodri
approved these changes
Oct 28, 2022
| for i, desc := range crdDescriptions { | ||
| for j, res := range desc.Resources { | ||
| resFromKind := fmt.Sprintf("%ss", strings.ToLower(res.Kind)) | ||
| fmt.Println("XXX resFromKind:", resFromKind) |
Member
There was a problem hiding this comment.
Suggested change
| fmt.Println("XXX resFromKind:", resFromKind) |
| // Check the Required Resources | ||
| crdCheck("Required", csv.Spec.CustomResourceDefinitions.Required) | ||
|
|
||
| fmt.Println("XXX resInCsvCrds:", resInCsvCrds) |
Member
There was a problem hiding this comment.
Suggested change
| fmt.Println("XXX resInCsvCrds:", resInCsvCrds) |
| for j, rule := range perm.Rules { | ||
| for _, res := range rule.Resources { | ||
| if _, ok := resInCsvCrds[res]; ok { | ||
| fmt.Println("XXX resource: ", res, "is in resInCsvCrds map!") |
Member
There was a problem hiding this comment.
Suggested change
| fmt.Println("XXX resource: ", res, "is in resInCsvCrds map!") |
Member
|
@everettraven should probably remove the |
Contributor
Author
|
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Member
|
/lgtm |
Member
|
/approved |
Member
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: everettraven, jmrodri The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
ClusterServiceVersion.Spec.InstallStrategy.StrategySpec.ClusterPermissions[].Rules[]ClusterServiceVersion.Spec.CustomResourceDefinitionsa warning is not raisedClusterServiceVersion.Spec.InstallStrategy.StrategySpec.Permissions[].Rules[]ClusterServiceVersion.Spec.CustomResourceDefinitionsa warning is not raisedClusterServiceVersion.Spec.CustomResourceDefinitions.Owned[].Resources[]ClusterServiceVersion.Spec.CustomResourceDefinitions.Owned[].Resources[]Motivation for the change: