Skip to content

Fix a panic when reading annotations if the bundle is not there #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Aug 23, 2022
Merged

Fix a panic when reading annotations if the bundle is not there #255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/manifests/bundleloader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,10 @@ func (b *bundleLoader) LoadBundle() error {

// Add values from the annotations when the values are not loaded
func (b *bundleLoader) addChannelsFromAnnotationsFile() {
if b.bundle == nil {
// None of this is relevant if the bundle was not found
return
}
// Note that they will not get load for Bundle Format directories
// and PackageManifest should not have the annotationsFile. However,
// the following check to ensure that channels and default channels
Expand Down