fix: ensure that all load bundle methods will check the size - #227
Merged
openshift-merge-robot merged 1 commit intoFeb 22, 2022
Merged
fix: ensure that all load bundle methods will check the size#227openshift-merge-robot merged 1 commit into
openshift-merge-robot merged 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, dinhxuanvu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
| return err | ||
| } | ||
|
|
||
| if !info.IsDir() { |
Member
There was a problem hiding this comment.
nit: we can flip this conditional by checking if the file we're processing right now is a directory and returning early. This should help reduce nesting and improve readability:
if err != nil {
return err
}
if info.IsDir() {
return nil
}
if data, err := os.ReadFile(...); err != nil {
return err
}
...
Contributor
Author
There was a problem hiding this comment.
I will do that in a follow-up.
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We need to read all files and compress them to do the check.
By doing checks with SDK we could identify that the loader is not checking the size correctly.