Skip to content

BitDecomposition in eclair#37

Merged
bhgomes merged 16 commits into
mainfrom
feat/bit_decomposition
Jan 11, 2023
Merged

BitDecomposition in eclair#37
bhgomes merged 16 commits into
mainfrom
feat/bit_decomposition

Conversation

@SupremoUGH

@SupremoUGH SupremoUGH commented Dec 8, 2022 •
edited by bhgomes
Loading

Copy link
Copy Markdown
Contributor

Bit decomposition in eclair:

Changes:
eclair:

  • bool.rs: Defined the BitDecomposition trait, implemented it for the native compiler and the usual types.
  • num.rs: Impl for UnsignedInteger
  • define to_bits_be() in the trait with default impl

plugins::arkworks

  • constraint: Impl for FpVar
  • algebra: Impl for ScalarVar

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate L- label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@SupremoUGH
defined BitDecomposition trait
c2344f1
@SupremoUGH
impl for ScalarVar
a7c3b2c 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
no result, just vec of bool
bc16a53 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
changelog
cf7cead 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
now BitDecomposition gives an array
d7490c3 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH SupremoUGH added A-cryptography Area: Issues and PRs related to Cryptography L-added Changelog: add these changes to the `added` section of the changelog labels Dec 8, 2022
bhgomes
bhgomes reviewed Dec 8, 2022
View reviewed changes
Comment thread plugins/arkworks/src/constraint.rs Outdated
bhgomes
bhgomes reviewed Dec 8, 2022
View reviewed changes
Comment thread plugins/arkworks/src/constraint.rs Outdated
bhgomes
bhgomes requested changes Dec 8, 2022
View reviewed changes
Comment thread plugins/arkworks/src/constraint.rs Outdated
SupremoUGH added 4 commits January 9, 2023 14:40
merge
63d2101 
Signed-off-by: SupremoUGH <francisco@manta.network>
conflict resolved
cb75108
clippy
09e3ee0
clippy
b8ccdfb
@SupremoUGH SupremoUGH mentioned this pull request Jan 10, 2023
Open
@SupremoUGH SupremoUGH marked this pull request as ready for review January 10, 2023 13:55
GhostOfGauss
GhostOfGauss reviewed Jan 10, 2023
View reviewed changes

@GhostOfGauss GhostOfGauss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good I just suggest improving the correctness test

Comment thread plugins/arkworks/src/constraint/mod.rs Outdated
This was referenced Jan 10, 2023
Open
Closed
@bhgomes bhgomes merged commit 47b3f9a into main Jan 11, 2023
@bhgomes bhgomes deleted the feat/bit_decomposition branch January 11, 2023 19:12
@SupremoUGH SupremoUGH mentioned this pull request Jan 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bhgomes bhgomes bhgomes approved these changes

@GhostOfGauss GhostOfGauss GhostOfGauss approved these changes

Assignees

No one assigned

Labels

A-cryptography Area: Issues and PRs related to Cryptography L-added Changelog: add these changes to the `added` section of the changelog

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SupremoUGH @bhgomes @GhostOfGauss