added codecov support#645
Conversation
Added codecov for js tests
| @@ -109,3 +117,4 @@ jobs: | |||
| after_success: | |||
| - # npx nyc report --reporter=lcov | npx codecov | |||
There was a problem hiding this comment.
Why is this line still here, did we use to have codecov enabled before?
And why should we do it differently now than we did before?
There was a problem hiding this comment.
That's something I missed 😮
There was a problem hiding this comment.
I followed up using npm. Can be done this way too
|
Thanks for submitting this PR.
|
|
I think we should include in dev requirements. It's small and it makes sure everywhere's working with the same set of dependencies which makes it easier to track down problems. The rebase now #648 is in will probably be a bit gross. Apologies. You may just want to start a new branch. The good news is the PR will be smaller as .travis.yml shrunk considerably. |
|
@birdsarah sure! Will start a new PR! #648 is literally a great thing! 🚀 |
This fixes #640
We still need to register the repo on codecov so that the test coverage can be picked up!
@vringar