feat: solve the problem of losing content style when copying from Excel#466
feat: solve the problem of losing content style when copying from Excel#466wuyiping0628 wants to merge 2 commits intodevfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdded a client-only Vue demo that mounts FluentEditor with the quill-table-up table plugin (configuring clipboard paste styling and context menu), updated docs to include the demo, and bumped Changes
Sequence Diagram(s)sequenceDiagram
participant Browser
participant DemoComponent as Demo.vue
participant FluentEditorPkg as `@opentiny/fluent-editor`
participant TableUpPkg as quill-table-up
participant DOM as EditorMount
Browser->>DemoComponent: load component (SSR -> client)
DemoComponent->>DemoComponent: onMounted()
DemoComponent->>FluentEditorPkg: dynamic import
DemoComponent->>TableUpPkg: dynamic import
Note right of DemoComponent: generateTableUp(TableUp) and register module
DemoComponent->>DOM: find editor mount (`editorContextmenuRef`)
DemoComponent->>FluentEditorPkg: new FluentEditor({... toolbar + table-up, modules config ...}, mount=DOM)
FluentEditorPkg->>DOM: render editor UI
Browser->>FluentEditorPkg: user paste into table (clipboard)
FluentEditorPkg->>TableUpPkg: handle paste using configured pasteStyleSheet/pasteDefaultTagStyle
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/docs/fluent-editor/demos/table-up-clipboard.vue`:
- Around line 48-51: 将这段说明改写为更清晰、可读的中文:提到 quill-table-up 从 3.5.0 版本新增了选项
pasteStyleSheet(将其名与版本号保留),说明将其设为 true 会解析粘贴 HTML 中的 style
标签;如果希望保留通过标签选择器设置的样式,建议同时启用 pasteDefaultTagStyle(保留该选项名);将 "excel" 改为规范书写
"Excel",拆分冗长句子并在末尾保留性能提示(开启 pasteStyleSheet 可能会降低粘贴解析性能),保证语句通顺且信息完整以提高可读性。
In `@packages/docs/fluent-editor/docs/demo/table-up.md`:
- Line 23: Update the heading text "## 表格剪切板" to use the standard term by
replacing "剪切板" with "剪贴板" so the heading reads "## 表格剪贴板" to ensure consistency
and better searchability across user-facing docs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b0978e9a-6f76-4e6b-aae8-fadae6d1053e
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (4)
packages/docs/fluent-editor/demos/table-up-clipboard.vuepackages/docs/fluent-editor/docs/demo/table-up.mdpackages/docs/package.jsonpackages/projects/package.json
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
New Features
Documentation
Chores