Skip to content

fix: fix the issue of incorrect serial number display when the content exceeds one line#465

Open
wuyiping0628 wants to merge 1 commit intodevfrom
wyp/li-length-0414
Open

fix: fix the issue of incorrect serial number display when the content exceeds one line#465
wuyiping0628 wants to merge 1 commit intodevfrom
wyp/li-length-0414

Conversation

@wuyiping0628
Copy link
Copy Markdown
Collaborator

@wuyiping0628 wuyiping0628 commented Apr 14, 2026

…t exceeds one line

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #353

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@wuyiping0628 wuyiping0628 added the bug Something isn't working label Apr 14, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 14, 2026

Walkthrough

A CSS rule targeting list item children within the Quill editor was removed from the stylesheet. The rule previously applied bottom: 0; positioning to UI elements that are direct children of list items. No other editor styling or logic was altered.

Changes

Cohort / File(s) Summary
Editor Styling
packages/fluent-editor/src/assets/editor.scss
Removed the CSS rule li > .ql-ui { bottom: 0; } from .ql-editor, eliminating an explicit bottom positioning constraint on Quill UI elements nested directly within list items.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A rule deemed unnecessary, cast away,
One line of CSS shadows in the fray,
No more shall UI elements anchored stay,
The editor breathes lighter, come what may! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title describes fixing incorrect serial number display when content exceeds one line, but the actual change only removes a CSS positioning rule from list items in the editor, with no clear connection to serial number display or content line handling. Update the title to accurately reflect the actual change, such as 'fix: remove explicit bottom positioning from Quill UI elements in list items' or provide more context about how this CSS change resolves the serial number display issue.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch wyp/li-length-0414

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant