Skip to content

add 3 more Ink interface#2797

Open
open-junius wants to merge 9 commits into
devnet-readyfrom
add-tests-for-new-query
Open

add 3 more Ink interface#2797
open-junius wants to merge 9 commits into
devnet-readyfrom
add-tests-for-new-query

Conversation

@open-junius

Copy link
Copy Markdown
Contributor

Description

Follow the PR #2768, update the Ink contract in ts-tests and verify all 3 new query functions.

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run ./scripts/fix_rust.sh to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

🛡️ AI Review — Skeptic (security review)

VERDICT: SAFE

LOW/BASELINE scrutiny: open-junius has repo write permission, substantial contribution history, no Gittensor allowlist match, and no unexplained author mismatch beyond the expected auditor bot auto-fix commit; branch add-tests-for-new-query -> devnet-ready.

Static-only Skeptic review found the diff limited to ts-tests/ink/bittensor.json, ts-tests/ink/bittensor.wasm, and zombienet EVM TypeScript tests. No .github/, runtime/pallet source, dependency manifests, lockfiles, build scripts, workflow/tooling, or package-manager files changed. The updated Ink metadata hash matches the committed WASM BLAKE2b-256 hash, and static strings checks showed only the expected Ink seal import surface relevant to this test artifact.

Findings

No findings.

Conclusion

No malicious intent or security vulnerability found in the changed surface. Remaining risk is ordinary binary test-artifact review risk for the updated WASM, with no concrete security issue identified.


🔍 AI Review — Auditor (domain review)

VERDICT: 👍

Gittensor UNKNOWN; author has repo write permission and substantial prior subtensor PR history, so review focused on correctness and test coverage.

The Auditor proposed a replacement PR description, but the current body is non-trivial; not overwriting. Maintainers: ask the Auditor to regenerate if you want it.

This PR is limited to ts-tests/ink artifacts and zombienet EVM TypeScript tests. The updated Ink metadata exposes the three new read-only query messages, and the added 03-wasm-contract cases exercise get_subnet_registration_state, get_coldkey_lock, and get_stake_availability through ContractsApi.call.

No runtime or pallet code changed, so no spec-version bump is required. Verification performed: b2sum -l 256 ts-tests/ink/bittensor.wasm matches the source.hash in ts-tests/ink/bittensor.json, and git diff --check passed. I did not run the zombienet suite because no finding required runtime confirmation.

Findings

No findings.

Conclusion

Approved. The PR adds focused Ink query coverage and test-artifact updates without changing on-chain behavior, and I found no domain issue blocking merge.

@github-actions

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

@github-actions

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

@github-actions

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

@open-junius open-junius self-assigned this Jun 25, 2026
@open-junius open-junius added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Jun 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

@github-actions

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

@github-actions

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants