fix failed eco test

[open-junius]

Description

The PR fix the failed eco-test and remove the unused parameter SwapMaxPositions.

Related Issue(s)

• Closes #[issue number]

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have run ./scripts/fix_rust.sh to ensure my code is formatted and linted correctly
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

[github-actions]

🛡️ AI Review — Skeptic (security review)

VERDICT: SAFE

BASELINE scrutiny: open-junius has write permission, an established account, substantial prior subtensor PR history, matching in-PR author/committer, and no Gittensor allowlist hit found; branch fix-failed-eco-test -> devnet-ready.

Reviewed the trusted-context signals and full prefetched diff. The PR removes obsolete SwapMaxPositions mock/test wiring and bumps runtime/src/lib.rs spec_version; it does not modify .github/, dependencies, build scripts, origin checks, storage, arithmetic, economic formulas, or production runtime behavior beyond the version bump.

Findings

No findings.

Conclusion

No malicious behavior or security vulnerability was found in this small mock/test cleanup. The remaining changed surface does not create a runtime panic, supply-chain execution path, permission bypass, or economic-risk change.

---

🔍 AI Review — Auditor (domain review)

VERDICT: 👍

Gittensor: LIKELY by recent Subtensor PR history; author has write permission and substantial prior contributions, so review focused on correctness and duplicate-work overlap.

The Auditor proposed a replacement PR description, but the current body is non-trivial; not overwriting. Maintainers: ask the Auditor to regenerate if you want it.

The change is narrowly scoped to stale swap mock wiring: SwapMaxPositions and the removed type MaxPositions association are gone, and a workspace search found no remaining SwapMaxPositions or type MaxPositions references in the affected mock/test wiring. The included spec_version bump is consistent with the devnet-ready spec-version check.

Duplicate-work check: the prefetched overlap list contains broader PRs touching the same mock/runtime files, but the closest overlapping branches retain the stale MaxPositions wiring or make unrelated runtime/mock changes. I do not see a duplicate PR to prefer over this one for the stated eco-test build failure.

Verification: rustc --version / cargo could not start because rustup attempted to write under read-only /home/runner/.rustup; no build or test command was run in this sandbox. Static inspection only; no auto-fix files were modified.

Findings

No findings.

Conclusion

This PR removes obsolete mock config after the swap pallet config surface changed, without altering production economic logic or storage behavior. No blocking domain issues found.

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👍