Skip to content

hotfix 6/2/2026#2711

Merged
sam0x17 merged 20 commits into
mainfrom
testnet
Jun 3, 2026
Merged

hotfix 6/2/2026#2711
sam0x17 merged 20 commits into
mainfrom
testnet

Conversation

@sam0x17

@sam0x17 sam0x17 commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

basfroman and others added 20 commits May 29, 2026 22:55
…-runtime-apis

Expose proxy type filtering rules via runtime api
PR #2645 cached chain-bought alpha in SubnetProtocolAlpha instead of
burning it, but its deregistration settlement lumped SubnetAlphaIn (the
AMM pool reserve) together with the cached protocol alpha. Including the
pool reserve as a settlement weight diluted every staker's pro-rata TAO
share.

Convert only the chain-bought alpha (SubnetProtocolAlpha) to TAO on
dissolution, pro-rata by the same formula as every staker's alpha, and
recycle that TAO back to the chain. SubnetAlphaIn is excluded from the
settlement denominator.

- Update dissolve_protocol_alpha_share_is_not_paid_to_users for the
  corrected settlement (staker share no longer diluted by alpha-in)
- Add dissolve_chain_bought_alpha_is_converted_to_tao_and_recycled
  asserting the bought-alpha TAO is recycled (reduces total issuance)
  and never leaks to the owner
- Bump spec_version 414 -> 415
@sam0x17 sam0x17 requested review from JohnReedV and gztensor June 2, 2026 23:45
@sam0x17 sam0x17 added skip-cargo-audit This PR fails cargo audit but needs to be merged anyway skip-bittensor-e2e-tests Skips Bittensor e2e tests labels Jun 2, 2026
@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

🛡️ AI Review — Skeptic (security review)

VERDICT: SAFE

Baseline scrutiny: author is an established repo admin; branch is the legitimate testnet -> main deployment/hotfix path. No Gittensor allowlist match found in the trusted local lists.

No security findings. I reviewed the runtime economic change, the migration/cutover storage, the proxy filter macro replacement, dependency changes, and protected review-prompt paths. The PR does not modify .github/ai-review/* or .github/copilot-instructions.md, and it only enables additional syn features for an existing local proc-macro crate rather than adding a new third-party dependency.

The runtime proxy filter definitions appear equivalent to the removed hand-written InstanceFilter::filter() arms, with tests added to cross-check the runtime API metadata against filter behavior. The TAO-in refund cutover records the runtime-upgrade block once and the modified settlement path uses saturating/checked arithmetic for the newly changed pro-rata logic.

Findings

No findings.

Conclusion

I found no malicious behavior or security vulnerability in the reviewed diff. The PR is acceptable from the Skeptic perspective.


# 🔍 AI Review — Auditor (domain review) has not yet run on this PR.

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE

@sam0x17 sam0x17 merged commit 1104f2a into main Jun 3, 2026
65 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-bittensor-e2e-tests Skips Bittensor e2e tests skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants