Remove hyperparameter max_weight_limit#2141
Merged
Merged
Conversation
sam0x17
added
the
skip-cargo-audit
JohnReedV
approved these changes
Oct 17, 2025
kkowalski-reef
added a commit
to bittensor-church/agcli
that referenced
this pull request
Jun 26, 2026
There is no longer any extrinsic to set a subnet's max weight limit: opentensor/subtensor#2141 ("disable max weight limit", Oct 2025) deleted the AdminUtils.sudo_set_max_weight_limit dispatchable and made get_max_weight_limit a constant u16::MAX. This predates the current finney runtime — agcli's call has been dead for a long time. In scaffold it was silently a no-op: submit_sudo_raw_call_checked bails with "Call ... not found in runtime metadata" and try_admin! swallows anything containing "not found", so the configured max_weight_limit was never applied and the run just printed a warning. Remove the scaffold surface for it — the SubnetConfig.max_weight_limit field, its default, the set call, the example config line, and the test fixtures. The general admin::set_max_weight_limit helper and its CLI command are left in place (separate machinery, out of scope here).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaces
max_weight_limithyperparameter with a constant limit ofu16::MAX