Skip to content

backprop hotfixes 6/16/2025#1761

Merged
sam0x17 merged 32 commits into
devnet-readyfrom
sam-backprop-6-16-2025
Jun 16, 2025
Merged

backprop hotfixes 6/16/2025#1761
sam0x17 merged 32 commits into
devnet-readyfrom
sam-backprop-6-16-2025

Conversation

@sam0x17

@sam0x17 sam0x17 commented Jun 16, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@sam0x17 sam0x17 self-assigned this Jun 16, 2025
@sam0x17 sam0x17 added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Jun 16, 2025
@sam0x17 sam0x17 changed the title Sam backprop 6/16/2025 backprop hotfixes 6/16/2025 Jun 16, 2025
Comment thread pallets/subtensor/src/macros/dispatches.rs Outdated
Comment thread pallets/subtensor/src/swap/swap_hotkey.rs Outdated
Comment thread pallets/subtensor/src/swap/swap_hotkey.rs
Comment thread pallets/subtensor/src/tests/swap_hotkey_with_subnet.rs
Comment thread pallets/subtensor/src/tests/swap_hotkey_with_subnet.rs Outdated
Comment thread pallets/subtensor/src/tests/swap_hotkey_with_subnet.rs Outdated
l0r1s
l0r1s previously approved these changes Jun 16, 2025

@l0r1s l0r1s left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can batch apply the suggestions + fix only the comment for the different step where it is not at the correct place. lgtm

@sam0x17 sam0x17 requested review from a team, JohnReedV, gztensor and l0r1s June 16, 2025 22:54
@sam0x17 sam0x17 merged commit 3db0cb7 into devnet-ready Jun 16, 2025
52 of 54 checks passed
This was referenced Jun 18, 2025
@sam0x17 sam0x17 mentioned this pull request Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants