Skip to content

fix build due to set bond reset ext missing NetUid #1740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sam0x17 merged 5 commits into from
Jun 11, 2025
Merged

fix build due to set bond reset ext missing NetUid #1740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f1c1643
fix build
l0r1s Jun 11, 2025
60b137c
fix build 2
l0r1s Jun 11, 2025
f5f21c3
fix build 3
l0r1s Jun 11, 2025
4085a7c
fix tests
l0r1s Jun 11, 2025
de7c10d
Reformat
ales-otf Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pallets/admin-utils/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ pub mod pallet {
/// Event emitted when Bonds Reset is toggled.
BondsResetToggled {
/// The network identifier.
netuid: u16,
netuid: NetUid,
/// Indicates if the Bonds Reset was enabled or disabled.
enabled: bool,
},
Expand Down Expand Up @@ -1625,7 +1625,7 @@ pub mod pallet {
#[pallet::weight((0, DispatchClass::Operational, Pays::No))]
pub fn sudo_set_bonds_reset_enabled(
origin: OriginFor<T>,
netuid: u16,
netuid: NetUid,
enabled: bool,
) -> DispatchResult {
pallet_subtensor::Pallet::<T>::ensure_subnet_owner_or_root(origin, netuid)?;
Expand Down
4 changes: 2 additions & 2 deletions pallets/admin-utils/src/tests/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1785,7 +1785,7 @@ fn test_set_sn_owner_hotkey_root() {
#[test]
fn test_sudo_set_bonds_reset_enabled() {
new_test_ext().execute_with(|| {
let netuid: u16 = 1;
let netuid = NetUid::from(1);
let to_be_set: bool = true;
let sn_owner = U256::from(1);
add_network(netuid, 10);
Expand Down Expand Up @@ -1822,7 +1822,7 @@ fn test_sudo_set_bonds_reset_enabled() {
#[test]
fn test_sudo_set_yuma3_enabled() {
new_test_ext().execute_with(|| {
let netuid: u16 = 1;
let netuid = NetUid::from(1);
let to_be_set: bool = true;
let sn_owner = U256::from(1);
add_network(netuid, 10);
Expand Down
9 changes: 7 additions & 2 deletions precompiles/src/subnet.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,9 @@ where
#[precompile::public("getBondsResetEnabled(uint16)")]
#[precompile::view]
fn get_bonds_reset_enabled(_: &mut impl PrecompileHandle, netuid: u16) -> EvmResult<bool> {
Ok(pallet_subtensor::BondsResetOn::<R>::get(netuid))
Ok(pallet_subtensor::BondsResetOn::<R>::get(NetUid::from(
netuid,
)))
}

#[precompile::public("setYuma3Enabled(uint16,bool)")]
Expand Down Expand Up @@ -649,7 +651,10 @@ where
netuid: u16,
enabled: bool,
) -> EvmResult<()> {
let call = pallet_admin_utils::Call::<R>::sudo_set_bonds_reset_enabled { netuid, enabled };
let call = pallet_admin_utils::Call::<R>::sudo_set_bonds_reset_enabled {
netuid: netuid.into(),
enabled,
};

handle.try_dispatch_runtime_call::<R, _>(
call,
Expand Down
Loading