Skip to content

Add changes from Max and Dr. Nick#1716

Merged
gztensor merged 3 commits into
feat/uniswapv3-lpfrom
feat/uniswapv3-lp-tick-liquidity-fix
Jun 4, 2025
Merged

Add changes from Max and Dr. Nick#1716
gztensor merged 3 commits into
feat/uniswapv3-lpfrom
feat/uniswapv3-lp-tick-liquidity-fix

Conversation

@gztensor

@gztensor gztensor commented Jun 4, 2025

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread pallets/swap/src/pallet/impls.rs Outdated
Comment on lines +160 to +180
// println!("\tAction : {:?}", self.action);
// println!(
// "\tCurrent Price : {}",
// self.current_sqrt_price * self.current_sqrt_price
// );
// println!(
// "\tTarget Price : {}",
// self.target_sqrt_price * self.target_sqrt_price
// );
// println!(
// "\tLimit Price : {}",
// self.limit_sqrt_price * self.limit_sqrt_price
// );
// println!(
// "\tEdge Price : {}",
// self.edge_sqrt_price * self.edge_sqrt_price
// );
// println!(
// "\t{}",
// format!("Delta In : {}", self.delta_in).yellow()
// );

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Comment thread pallets/swap/src/pallet/impls.rs Outdated
// Hold the fees
Pallet::<T>::add_fees(self.netuid, self.order_type, self.fee);
let delta_out = Pallet::<T>::convert_deltas(self.netuid, self.order_type, self.delta_in);
// println!("\t{}", format!("Delta Out : {}", delta_out).green());

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Comment thread pallets/swap/src/pallet/impls.rs Outdated
Comment on lines +426 to +435
// println!("======== Start Swap ========");
// println!("Amount Remaining: {}", amount_remaining);

// Swap one tick at a time until we reach one of the stop conditions
while amount_remaining > 0 {
// println!("\nIteration: {}", iteration_counter);
// println!(
// "\tCurrent Liquidity: {}",
// CurrentLiquidity::<T>::get(netuid)
// );

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@gztensor gztensor merged commit 0163d35 into feat/uniswapv3-lp Jun 4, 2025
13 of 16 checks passed
This was referenced Jun 18, 2025
@sam0x17 sam0x17 mentioned this pull request Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants