Adding dockerfile, docker compose file and circleci#25
Open
eduardogr wants to merge 8 commits into
Open
Conversation
…used Dockerfile ARGs
eduardogr
force-pushed
the
sre/adding-dockerfile-compose-and-circleci
branch
from
fbfdd69 to
a2e85a1
Compare
shibshib
reviewed
Jan 26, 2023
Comment on lines
+42
to
+48
|
|
||
| ARG POLKADOT_VERSION | ||
|
|
||
| RUN git clone --branch ${POLKADOT_VERSION} https://github.com/paritytech/polkadot.git | ||
| RUN cd polkadot && cargo b -r | ||
|
|
||
| EXPOSE 30333 9933 9944 |
Contributor
There was a problem hiding this comment.
Not sure what the point of this is.. is it running a validator and a collator at the same time? If so, why do we need to do that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A starting point to add: