Skip to content

[tobiko] Remove quotes for TOBIKO_TESTENV variable#391

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
kstrenkova:tobiko-remove-quotes-for-env-vars
May 12, 2026
Merged

[tobiko] Remove quotes for TOBIKO_TESTENV variable#391
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
kstrenkova:tobiko-remove-quotes-for-env-vars

Conversation

@kstrenkova

Copy link
Copy Markdown
Contributor

Recently a change added quotes to Tobiko variables to follow best practices. However, the environment variable quotation prevented using "scenario -- path/to/test.py" tox syntax, where word splitting is required to pass arguments after --. This change removes quotes to enable this use case.

Recently a change added quotes to Tobiko variables to follow best
practices. However, the environment variable quotation prevented
using "scenario -- path/to/test.py" tox syntax, where word
splitting is required to pass arguments after --. This change
removes quotes to enable this use case.
@openshift-ci openshift-ci Bot requested review from abays and slagle May 12, 2026 09:08
@kstrenkova

Copy link
Copy Markdown
Contributor Author

/cherry-pick antelope

@openshift-cherrypick-robot

Copy link
Copy Markdown

@kstrenkova: once the present PR merges, I will cherry-pick it on top of antelope in a new PR and assign it to you.

Details

In response to this:

/cherry-pick antelope

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@abays abays left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented May 12, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, eduolivares, kstrenkova

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 2aae73b into openstack-k8s-operators:main May 12, 2026
5 checks passed
@openshift-cherrypick-robot

Copy link
Copy Markdown

@kstrenkova: new pull request created: #392

Details

In response to this:

/cherry-pick antelope

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants