Build openstack-watcher container#215
Conversation
raukadah
force-pushed
the
add_watcher
branch
from
c75f19c to
872d312
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/009b2d2b9cb144478d5d71af89970d0b ❌ openstack-meta-content-provider FAILURE in 23m 49s |
raukadah
force-pushed
the
add_watcher
branch
from
872d312 to
bc7fa66
Compare
|
/assign @rlandy |
| - httpd | ||
| - mod_ssl | ||
| - openstack-watcher-common | ||
| - python3-mod_wsgi |
There was a problem hiding this comment.
Only the watcher-api runs as a wsgi in httpd, I'd move httpd, mod_ssl and python3-mod_wsgi to the watcher-api container.
There was a problem hiding this comment.
Thank you for the updating in the pr!
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/430f4b85b356447da30bead4066d555e ❌ openstack-meta-content-provider FAILURE in 15m 46s |
|
recheck |
Watcher related packages got added in RDO antelope but not available in OSP-18 downstream. openstack-k8s-operators/tcib#215 adds watcher container in tcib. Since downstream tcib jobs install the tcib rpm from main branch so it may break downstream container build and component job. So in order to avoid breakage, we are skip building watcher related containers. Note: It also fixes the exclude conditional to check existence of release key in exclude var to avoid following error: ``` ''dict object'' has no attribute ''master''' ``` Depends-On: openstack-k8s-operators/tcib#215 Signed-off-by: Chandan Kumar <raukadah@gmail.com>
| "${SITE_PACKAGES}/watcher_dashboard/conf/watcher_policy.json" \ | ||
| "/etc/openstack-dashboard/watcher_policy.json" | ||
| } | ||
|
|
There was a problem hiding this comment.
I'm afraid of breaking horizon deployment downstream by adding this as we need ENABLE_WATCHER as this script requires ENABLE_WATCHER variable which we need to add in horizon-operator and also requires files which are installed by openstack-watcher-ui which will not be installed downstream. What if we add the dashboard configuration part for a future PR or at least don't run it so far?
There was a problem hiding this comment.
@amoralej Yes, indeed, it will break. I am moving this whole piece. https://issues.redhat.com/browse/OSPRH-11277 will track the same, will add it in future pr.
| config_ironic_dashboard | ||
| config_manila_ui | ||
| config_octavia_dashboard | ||
| config_watcher_dashboard |
This pull request: * Builds OpenStack Watcher containers * Add python-watcherclient package to openstackclient container * Add openstack-watcher-ui package to horizon container Note: python-watcherclient and openstack-watcher-ui is not available in downstream currently. It is available in CentOS Stream with RDO antelope release. That's why we have added these packages under tcib_distro conditional to avoid breakage downstream. Jira: https://issues.redhat.com/browse/OSPRH-11085 Co-authored-by: Alfredo Moralejo <amoralej@redhat.com> Signed-off-by: Chandan Kumar <raukadah@gmail.com>
rabi
left a comment
rabi
left a comment
There was a problem hiding this comment.
Is watcher service going to be tech-preview in a OSP 18 Feature Release or OSP19? Is there any PM agreement for that you could link it the linked jira?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rabi, raukadah, rlandy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rabi Hello, thank you for the comments, https://issues.redhat.com/browse/OSPRH-7674 tracks it and it is targeted as a tech preview in RHOS-18.0 FR 2 release. |
|
/cherry-pick 18.0-fr1 |
|
@raukadah: new pull request created: #247 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5 participants
This pull request:
* Builds OpenStack Watcher containers
* Add python-watcherclient package to openstackclient container
* Add openstack-watcher-ui package to horizon container
Note: python-watcherclient and openstack-watcher-ui is not available in downstream currently. It is available in CentOS Stream with RDO antelope release. That's why we have added these packages under tcib_distro conditional to avoid breakage downstream.
Test results: #215 (comment)
Jira: https://issues.redhat.com/browse/OSPRH-11085
Co-authored-by: Alfredo Moralejo amoralej@redhat.com
Signed-off-by: Chandan Kumar raukadah@gmail.com