Skip to content

feat: Integration test for verifying grant revocation#573

Merged
gtema merged 5 commits intoopenstack-experimental:mainfrom
konac-hamza:feature/integration-test-grant-revocation
Mar 12, 2026
Merged

feat: Integration test for verifying grant revocation#573
gtema merged 5 commits intoopenstack-experimental:mainfrom
konac-hamza:feature/integration-test-grant-revocation

Conversation

@konac-hamza
Copy link
Collaborator

No description provided.

@konac-hamza konac-hamza force-pushed the feature/integration-test-grant-revocation branch from eedc423 to 95f5696 Compare February 25, 2026 23:57
@goOdyaga
Copy link

@gtema
I thought that reason of the fails about the new implementations. So I didn't try to change anything in the PR. Do I need to change anything in the request:?

@gtema
Copy link
Collaborator

gtema commented Mar 10, 2026

I was looking at it yesterday and found few issues:

  • appcreds (as used in the test) need to keep original roles for the token revolution check, while dropping unavailable roles in the response. I addressed this yesterday in a different PR by introducing new method for calling roles on token. This requires PR rebase
  • token revolution works with a seconds precision (instead of microseconds) and that requires a 1second wait after revoking role before trying to auth again
  • sqlite (most likely sqlx driver) has some weird bug that token issued_at is compared wrongly. For MySQL/postgres works correct. I want to try to chase it down today

@gtema
Copy link
Collaborator

gtema commented Mar 10, 2026

it should be fine now to resolve the conflicts and update the test: there is a similar test verifying the revoke provider with the difference that it explicitly creates revocation event instead of revoking the concrete role and it does not verify the "auth" aspect like this test does

@konac-hamza konac-hamza force-pushed the feature/integration-test-grant-revocation branch from d5483ca to 8436997 Compare March 10, 2026 21:23
@konac-hamza konac-hamza force-pushed the feature/integration-test-grant-revocation branch from 8436997 to 2a7109d Compare March 11, 2026 20:22
@gtema gtema merged commit 372a12a into openstack-experimental:main Mar 12, 2026
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants