Repository navigation
fix: add bounds checking to prevent buffer overflows in compiler - #917
Open
LuisCastellanos-dev wants to merge 2 commits into
Open
LuisCastellanos-dev wants to merge 2 commits into
LuisCastellanos-dev wants to merge 2 commits into
Conversation
- cb_encode_program_id(): add buff_end guard before each sprintf/write to prevent stack buffer overflow with long UTF-8 PROGRAM-IDs - cobj.c -D/-I option parsing: add strlen capacity check before strcat to prevent overflow of cob_define_flags[COB_SMALL_BUFF] Fixes opensourcecobol#912 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UQSdzi4j7ovUnBDWqSDcjF
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buff_endpointer guard incb_encode_program_id()(cobj/typeck.c) to prevent stack buffer overflow when encoding long UTF-8 PROGRAM-IDs viasprintf()strlen()capacity checks beforestrcat()calls in-Dand-Ioption parsing (cobj/cobj.c) to prevent overflow ofcob_define_flags[COB_SMALL_BUFF]Test plan
cb_errorinstead of crashing-Dflags totaling >1024 bytes — should exit with overflow error instead of corrupting stackFixes #912