Skip to content

SWATCH-3413: Add acm_capacity_effective_cpu_cores:sum recording rule - #554

Merged
openshift-merge-bot[bot] merged 5 commits into
openshift:mainfrom
lindseyburnett:lburnett/acm_recording_rule_aggregate
Apr 8, 2025
Merged

SWATCH-3413: Add acm_capacity_effective_cpu_cores:sum recording rule#554
openshift-merge-bot[bot] merged 5 commits into
openshift:mainfrom
lindseyburnett:lburnett/acm_recording_rule_aggregate

Conversation

@lindseyburnett

@lindseyburnett lindseyburnett commented Apr 7, 2025

Copy link
Copy Markdown
Contributor

A recording rule needs to aggregate worker nodes under the hub cluster so swatch can associate the metric with the hub's billing account information.

Create a new recording rule that uses the existing one, and adds the "sum" logic on top of it.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 7, 2025
@openshift-ci-robot

openshift-ci-robot commented Apr 7, 2025 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown
Contributor

@lindseyburnett: This pull request references SWATCH-3413 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

A recording rule needs to aggregate worker nodes under the hub cluster so swatch can associate the metric with the hub's billing account information.

Create a new recording rule that uses the existing one, and adds the "sum" logic on top of it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 7, 2025
@openshift-ci

openshift-ci Bot commented Apr 7, 2025

Copy link
Copy Markdown
Contributor

Hi @lindseyburnett. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lindseyburnett
Add acm_capacity_effective_cpu_cores:sum recording rule
88abe63 
A recording rule needs to aggregate worker nodes under the hub cluster so swatch can associate the metric with the hub's billing account information.

Create a new recording rule that uses the existing one, and adds the "sum" logic on top of it.

Option 2: Update acm_capacity_effective_cpu_cores
@lindseyburnett
lindseyburnett force-pushed the lburnett/acm_recording_rule_aggregate branch from 09789d6 to 88abe63 Compare April 7, 2025 20:13
@simonpasquier

simonpasquier commented Apr 8, 2025

Copy link
Copy Markdown
Contributor

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 8, 2025
simonpasquier
simonpasquier reviewed Apr 8, 2025
View reviewed changes
Comment thread jsonnet/telemeter/rules.libsonnet Outdated
@lindseyburnett
lindseyburnett marked this pull request as ready for review April 8, 2025 13:50
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 8, 2025
@openshift-ci
openshift-ci Bot requested review from coleenquadros and rexagod April 8, 2025 13:51
simonpasquier
simonpasquier reviewed Apr 8, 2025
View reviewed changes
Comment thread jsonnet/telemeter/rules.libsonnet Outdated
lindseyburnett and others added 3 commits April 8, 2025 11:29
@lindseyburnett @simonpasquier
Update jsonnet/telemeter/rules.libsonnet
d98e91e 
Co-authored-by: Simon Pasquier <spasquie@redhat.com>
@lindseyburnett
Fix linting issue with leading whitespace
a5dd4b4
@lindseyburnett
Merge branch 'lburnett/acm_recording_rule_aggregate' of github.com:li…
d186b1d 
…ndseyburnett/telemeter into lburnett/acm_recording_rule_aggregate
@lindseyburnett

lindseyburnett commented Apr 8, 2025

Copy link
Copy Markdown
Contributor Author

/test lint

@lindseyburnett

lindseyburnett commented Apr 8, 2025

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci

openshift-ci Bot commented Apr 8, 2025

Copy link
Copy Markdown
Contributor

@lindseyburnett: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

simonpasquier
simonpasquier reviewed Apr 8, 2025
View reviewed changes

@simonpasquier simonpasquier left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Comment thread test/rulestests.yaml

@simonpasquier simonpasquier Apr 8, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this!

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2025
@openshift-ci

openshift-ci Bot commented Apr 8, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lindseyburnett, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2025
@openshift-merge-bot
openshift-merge-bot Bot merged commit 70e6d4b into openshift:main Apr 8, 2025
@openshift-bot

openshift-bot commented Apr 9, 2025

Copy link
Copy Markdown
Contributor

[ART PR BUILD NOTIFIER]

Distgit: telemeter
This PR has been included in build telemeter-container-v4.19.0-202504090015.p0.g70e6d4b.assembly.stream.el9.
All builds following this will include this PR.

@simonpasquier simonpasquier mentioned this pull request Aug 3, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simonpasquier simonpasquier simonpasquier left review comments
@coleenquadros coleenquadros Awaiting requested review from coleenquadros
@rexagod rexagod Awaiting requested review from rexagod

Assignees

@simonpasquier simonpasquier

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lindseyburnett @openshift-ci-robot @simonpasquier @openshift-bot