Add ServiceUnitKey and ServiceAliasConfigKey types

[Miciah]

Define and use the ServiceUnitKey and ServiceAliasConfigKey types for key values of maps of ServiceUnit values and of ServiceAliasConfig values, respectively, in order to make code dealing with such maps clearer and reduce risk of mixing key values.

• pkg/router/template/configmanager/haproxy/backend.go (Backend): Use ServiceAliasConfigKey for the name.
  (buildHAProxyBackends, newBackend, Name, ApplyChanges): Adapt to use the new ServiceAliasConfigKey type.
• pkg/router/template/configmanager/haproxy/blueprint_plugin_test.go (fakeConfigManager): Use ServiceAliasConfigKey for the blueprints map.
  (newFakeConfigManager, FindBlueprint, Register, AddRoute, RemoveRoute, ReplaceRouteEndpoints, RemoveRouteEndpoints, routeKey):
• pkg/router/template/configmanager/haproxy/client.go (FindBackend):
• pkg/router/template/configmanager/haproxy/client_test.go (TestClientCommit, TestClientBackends): Adapt to use the
  ServiceAliasConfigKey type.
• pkg/router/template/configmanager/haproxy/manager.go (configEntryMap): Use the ServiceAliasConfigKey type for the map's values.
  (routeBackendEntry): Use the ServiceAliasConfigKey type for backendName and the poolRouteBackendName, backendEntries, and poolUsage maps' keys.
  (NewHAProxyConfigManager, Register, AddRoute, RemoveRoute, ReplaceRouteEndpoints, RemoveRouteEndpoints, findFreeBackendPoolSlot, reset, BackendName, BuildMapAssociations, routeBackendName, applyMapAssociations):
• pkg/router/template/configmanager/haproxy/map.go (Add, addEntry):
• pkg/router/template/configmanager/haproxy/map_test.go (TestHAProxyMapAdd): Adapt to use the ServiceAliasConfigKey type.
• pkg/router/template/fake.go (NewFakeTemplateRouter): Adapt to use ServiceUnitKey and ServiceAliasConfigKey.
• pkg/router/template/plugin.go (RouterInterface, endpointsKey, endpointsKeyFromParts, getPartsFromEndpointsKey): Adapt to use ServiceUnitKey.
• pkg/router/template/plugin_test.go (TestRouter, newTestRouter, CreateServiceUnit, FindServiceUnit, AddEndpoints, DeleteEndpoints, calculateServiceWeights, FilterNamespaces, getKey, TestHandleEndpoints, TestHandleTCPEndpoints, TestHandleRouteExtendedValidation, TestHandleRoute, TestNamespaceScopingFromEmpty):
• pkg/router/template/router.go (templateRouter, templateData, newTemplateRouter, readState, FilterNamespaces, CreateServiceUnit, createServiceUnitInternal, findMatchingServiceUnit, FindServiceUnit, DeleteServiceUnit, addServiceAliasAssociation, removeServiceAliasAssociation, dynamicallyAddRoute, dynamicallyRemoveRoute, dynamicallyReplaceEndpoints, DeleteEndpoints, routeKey, routeKeyFromParts, getPartsFromRouteKey, createServiceAliasConfig, numberOfEndpoints, AddEndpoints, getServiceUnits, getActiveEndpoints, calculateServiceWeights):
• pkg/router/template/router_test.go (TestCreateServiceUnit, TestDeleteServiceUnit, TestAddEndpoints, TestAddEndpointDuplicates, TestDeleteEndpoints, TestCreateServiceAliasConfig, TestAddRoute, TestFilterNamespaces):
• pkg/router/template/template_helper.go (generateHAProxyCertConfigMap, getHTTPAliasesGroupedByHost, generateHAProxyMap):
• pkg/router/template/template_helper_test.go (buildTestTemplateState, TestGenerateHAProxyCertConfigMap, TestGenerateHAProxyMap, TestGetHTTPAliasesGroupedByHost): Adapt to use ServiceAliasConfigKey and
  ServiceUnitKey.
• pkg/router/template/types.go (ServiceUnit): Use ServiceAliasConfigKey for the ServiceAliasAssociations map.
  (ServiceUnitKey): New type.
  (ServiceAliasConfig): Use ServiceUnitKey for the ServiceUnits and ServiceUnitNames maps.
  (ServiceAliasConfigKey): New type.
  (ConfigManager): Adapt to use ServiceAliasConfigKey.

[Miciah]

@ironcladlou, do you have any objections to this change? One of my motivations for making this change is that it will be easier to make logging consistent in a subsequent PR if the values that we are logging have specific types.

[ironcladlou]

Oh, sorry, this should have merged long ago.

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ironcladlou, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/router/OWNERS [Miciah,ironcladlou]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment