Repository navigation
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@jparrill: This pull request references Jira Issue OCPBUGS-127110, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@jparrill: This pull request references Jira Issue OCPBUGS-127110, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedWe couldn't safely recover the incremental review. No full review was started, and the last reviewed checkpoint was preserved. Retry later, or explicitly request a full review by commenting You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (11)
📒 Files selected for processing (5)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe five Hypershift release configurations now build ChangesHypershift test image build configuration
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The release jobs will build hypershift-tests from the branch-local Dockerfile.e2e, avoiding the prior floating-image version mismatch. No concrete production-impacting risk remains identified, so the change is ready to merge. 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
Bot
added
the
approved
Context: Why this matters for the HO upgrade testThe When The concrete failure on 4.22: main's CLI sets CAPI For the HO upgrade test specifically, the test binary (CLI) and operator image must come from the same source — otherwise CRDs and operator capabilities diverge. Building This was latent on 5.0 (works by coincidence because 5.0 serves |
dee9f61 to
e86e816
Compare
The e2e-aws-upgrade-hypershift-operator test was pulling hypershift-tests from main via base_images, causing a CLI/operator version mismatch when the test binary applied newer CRDs to an older operator (e.g., 5.1 CRDs on 4.22 operator). This broke the CAPIv1beta1→v1beta2 migration path. Create a dedicated hypershift-aws-e2e-nested-upgrade workflow that overrides the test step's `from:` to use hypershift-tests-pr (built from PR source via Dockerfile.e2e). Non-upgrade jobs continue using hypershift-tests from main, unchanged. Applied to release branches: 4.19, 4.20, 4.21, 4.22, 5.0, 5.1, 5.2. Ref: OCPBUGS-127110 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Juan Manuel Parrilla Madrid <jparrill@redhat.com>
e86e816 to
a657111
Compare
|
/lgtm |
|
/pj-rehearse ack |
|
@jparrill: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jparrill, mgencur The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
removed
the
rehearsals-ack
|
[REHEARSALNOTIFIER]
A total of 593 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@jparrill: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/hold |
|
This is the wrong approach. Explaining on slack. |
openshift-ci
Bot
added
the
do-not-merge/hold
|
The following is the desired behavior for the upgrade hypershift operator:
The expectations are:
|
|
/close In favor of openshift/hypershift#9736 (comment) |
|
@jparrill: This pull request references Jira Issue OCPBUGS-127110. The bug has been updated to no longer refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@jparrill: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 participants
Summary
hypershift-testsfromDockerfile.e2eon release branches 4.19-5.0 instead of pullingtag: latestfrom maine2e-aws-upgrade-hypershift-operator)Root Cause
The
hypershift-testsimage was defined inbase_imageswithtag: latest, resolving to main (5.1). The test binary contains thehypershift installCLI, which embeds CRDs from its own version. During upgrade tests, the 5.1 CLI applies 5.1 CRDs (CAPI v1beta2 storage version + conversion webhook at/convert) but deploys an operator image from the PR branch (e.g., 4.22) that does not serve/convert. Any CAPI write operation (DELETE MachineDeployment during teardown) triggers a conversion webhook call that returns 404.Evidence from Prow job 210193874397482598:
install-cli-version: Latest supported OCP: 5.1.0Latest supported OCP: 4.22.0Changes
For each release branch (4.19, 4.20, 4.21, 4.22, 5.0):
hypershift-testsfrombase_images(wastag: latestfrom main)Dockerfile.e2ebuild inimagessection (builds from PR source)Generated job files updated via
make jobs.Test Plan
pull-ci-openshift-hypershift-release-4.22-e2e-aws-upgrade-hypershift-operatorpasseshypershift-testsimage is built from PR branch, not mainRef: OCPBUGS-127110
🤖 Generated with Claude Code
Summary by CodeRabbit
hypershift-testsbuilds on release branches 4.19 through 5.0.latestbase image frommainwith branch-localDockerfile.e2ebuilds.e2e-aws-upgrade-hypershift-operatorjobs.