Skip to content

NO-JIRA: Drop testing of HyperShift on OpenStack on < 4.23 (redux) - #84927

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
shiftstack:remove-more-old-hcp-jobs
Sep 11, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
shiftstack:remove-more-old-hcp-jobs

Conversation

@stephenfin

@stephenfin stephenfin commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

A follow-up to PR #80481 that drops the HCP jobs for the ORC repo.

Summary by CodeRabbit

Removed HyperShift control plane test jobs from the OpenStack Resource Controller CI configurations for OpenShift 4.19 through 4.22.

This prevents unsupported HyperShift testing on OpenStack versions earlier than 4.23. Other CI tests remain unchanged.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 10, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@stephenfin: This pull request explicitly references no jira issue.

Details

In response to this:

A follow-up to PR #80481 that drops the HCP jobs for the ORC repo.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stephenfin

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

This is pure job removal

@coderabbitai

coderabbitai Bot commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

We couldn't safely recover the incremental review. No full review was started, and the last reviewed checkpoint was preserved. Retry later, or explicitly request a full review by commenting @coderabbitai full review.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 8186a00c-d6e1-49da-88bc-dc524aae1475

📥 Commits

Reviewing files that changed from the base of the PR and between 2f9cf5d and 4033be2.

⛔ Files ignored due to path filters (5)
  • ci-operator/jobs/openshift/openstack-resource-controller/openshift-openstack-resource-controller-release-4.19-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/openstack-resource-controller/openshift-openstack-resource-controller-release-4.20-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/openstack-resource-controller/openshift-openstack-resource-controller-release-4.21-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/openstack-resource-controller/openshift-openstack-resource-controller-release-4.22-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/release/openshift-release-main-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (4)
  • ci-operator/config/openshift/openstack-resource-controller/openshift-openstack-resource-controller-release-4.19.yaml
  • ci-operator/config/openshift/openstack-resource-controller/openshift-openstack-resource-controller-release-4.20.yaml
  • ci-operator/config/openshift/openstack-resource-controller/openshift-openstack-resource-controller-release-4.21.yaml
  • ci-operator/config/openshift/openstack-resource-controller/openshift-openstack-resource-controller-release-4.22.yaml
💤 Files with no reviewable changes (4)
  • ci-operator/config/openshift/openstack-resource-controller/openshift-openstack-resource-controller-release-4.22.yaml
  • ci-operator/config/openshift/openstack-resource-controller/openshift-openstack-resource-controller-release-4.21.yaml
  • ci-operator/config/openshift/openstack-resource-controller/openshift-openstack-resource-controller-release-4.19.yaml
  • ci-operator/config/openshift/openstack-resource-controller/openshift-openstack-resource-controller-release-4.20.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The release configurations for versions 4.19 through 4.22 remove the e2e-hypershift test and its related HyperShift OpenStack workflow settings. Other listed tests remain unchanged.

Changes

HyperShift E2E configuration removal

Layer / File(s) Summary
Remove e2e-hypershift test definitions
ci-operator/config/openshift/openstack-resource-controller/*release-4.*.yaml
The configurations remove the e2e-hypershift test, nested workflows, quota leases, cluster profiles, and related environment settings for releases 4.19 through 4.22.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 4033b

HyperShift testing is removed for older OpenStack releases, while the remaining tests are unchanged. No merge-blocking production risk is identified.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: removing HyperShift on OpenStack testing for versions earlier than 4.23.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS: The review-scoped diff changes only YAML CI configuration and generated job files. It removes HyperShift jobs for releases 4.19–4.22 and reorders generated periodic YAML fields. It adds no Ginkg…
Test Structure And Quality ✅ Passed PASS: The pull request changes only YAML CI configuration. It removes HyperShift test/job definitions and reorders equivalent entries in a periodic job file. The review-scoped diff contains no changed…
Microshift Test Compatibility ✅ Passed PASS: The pull request adds no Ginkgo e2e tests. The relevant config files only delete the e2e-hypershift entries, and the generated presubmit files only delete their jobs. The remaining changes do …
Single Node Openshift (Sno) Test Compatibility ✅ Passed The check is not triggered. The review-scoped diff changes only nine CI YAML files and adds no Go or Ginkgo test code. The relevant changes remove HyperShift CI job definitions and generated job metad…
Topology-Aware Scheduling Compatibility ✅ Passed The check does not identify a failure. The PR changes only CI configuration and generated Prow job files. The project-specific changes remove HyperShift test jobs; they add no affinity, topology sprea…
Ote Binary Stdout Contract ✅ Passed PASS — The review-scoped diff changes only YAML files. It changes CI job and test configuration, removes HyperShift jobs, and reorders generated periodic-job fields. No source files changed, and no ad…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS. The pull request adds no Ginkgo tests or test code. The exact diff contains only deletions of HyperShift CI configurations and generated YAML reordering. The diff has no added lines with Ginkgo …
No-Weak-Crypto ✅ Passed PASS. The reviewed range changes only YAML CI configuration. The four release configs and four presubmit files remove HyperShift jobs. The generated periodic changes add or reorder Secrets Store CSI a…
Container-Privileges ✅ Passed The pull request does not introduce any listed container privilege condition. The authoritative diff only removes HyperShift test and presubmit job definitions, and reorders/adds secret-store argument…
No-Sensitive-Data-In-Logs ✅ Passed PASS. The pull request removes HyperShift test and presubmit configuration. The changed config and job files contain deletions only. The large periodic-file diff only reorders existing secret-store co…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@stephenfin: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
openshift-ci Bot requested review from AlexNPavel and gryf September 10, 2026 16:34
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 10, 2026
A follow-up to PR openshift#80481 that drops the HCP jobs for the ORC repo.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@stephenfin
stephenfin force-pushed the remove-more-old-hcp-jobs branch from 4033be2 to fe37fe1 Compare September 10, 2026 16:35
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@stephenfin: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2026

@mandre mandre left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2026
@openshift-ci

openshift-ci Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre, stephenfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@stephenfin: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 08a9455 and 2 for PR HEAD fe37fe1 in total

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 6cad41b and 1 for PR HEAD fe37fe1 in total

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 910cae3 and 0 for PR HEAD fe37fe1 in total

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/hold

Revision fe37fe1 was retested 3 times: holding

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 10, 2026
@stephenfin

Copy link
Copy Markdown
Contributor Author

There were unrelated changes creeping in here when I ran make update. Let's see if they've been addressed via a separate PR

/retest

@openshift-ci

openshift-ci Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

@stephenfin: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@stephenfin

Copy link
Copy Markdown
Contributor Author

/remove-hold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 96c44c9 into openshift:main Sep 11, 2026
16 checks passed
@openshift-merge-bot
openshift-merge-bot Bot deleted the remove-more-old-hcp-jobs branch September 11, 2026 12:55
arpsharm pushed a commit to arpsharm/release that referenced this pull request Sep 17, 2026
…84927)

A follow-up to PR openshift#80481 that drops the HCP jobs for the ORC repo.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants