-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Onboard openshift-online/rosa-rhobs-dashboards to Prow #83751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
openshift-merge-bot
merged 7 commits into
openshift:main
from
anispate:add-rosa-rhobs-dashboards
Aug 25, 2026
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5ce5e56
Add openshift-online/rosa-rhobs-dashboards Prow onboarding
anispate a2e0977
Update rosa-rhobs-dashboards OWNERS to srep-functional-team-rocket + …
anispate b43b6ca
Set rosa-rhobs-dashboards OWNERS to the two teams' members
anispate b5596e2
Move image-mirroring mapping to its own PR
anispate d941f93
Make rosa-rhobs-dashboards private: add prowgen private + regenerate …
anispate 8a8896f
Assign cluster to rosa-rhobs-dashboards presubmits
anispate 660ac81
Fix rules-check: copy source to /work without nesting
anispate File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
41 changes: 41 additions & 0 deletions
41
ci-operator/config/openshift-online/rosa-rhobs-dashboards/OWNERS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| approvers: | ||
| - aliceh | ||
| - anispate | ||
| - clcollins | ||
| - Mhodesty | ||
| - nephomaniac | ||
| - tnierman | ||
| - Ajpantuso | ||
| - bergmannf | ||
| - bmeng | ||
| - bpresnel-rh | ||
| - dustman9000 | ||
| - joshbranham | ||
| - psav | ||
| - rafael-azevedo | ||
| - ravitri | ||
| - rbhilare | ||
| - smarthall | ||
| - theautoroboto | ||
| - typeid | ||
| options: {} | ||
| reviewers: | ||
| - aliceh | ||
| - anispate | ||
| - clcollins | ||
| - Mhodesty | ||
| - nephomaniac | ||
| - tnierman | ||
| - Ajpantuso | ||
| - bergmannf | ||
| - bmeng | ||
| - bpresnel-rh | ||
| - dustman9000 | ||
| - joshbranham | ||
| - psav | ||
| - rafael-azevedo | ||
| - ravitri | ||
| - rbhilare | ||
| - smarthall | ||
| - theautoroboto | ||
| - typeid |
37 changes: 37 additions & 0 deletions
37
...g/openshift-online/rosa-rhobs-dashboards/openshift-online-rosa-rhobs-dashboards-main.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| base_images: | ||
| obsctl-reloader-rules-checker: | ||
| name: obsctl-reloader-rules-checker | ||
| namespace: ci | ||
| tag: 1.0.7 | ||
| build_root: | ||
| image_stream_tag: | ||
| name: release | ||
| namespace: openshift | ||
| tag: rhel-9-release-golang-1.25-openshift-4.23 | ||
| images: | ||
| items: | ||
| - dockerfile_literal: | | ||
| FROM obsctl-reloader-rules-checker | ||
| COPY . /work | ||
| WORKDIR /work | ||
| from: obsctl-reloader-rules-checker | ||
| to: rules-checker-with-src | ||
| prowgen: | ||
| expose: true | ||
| private: true | ||
| resources: | ||
| '*': | ||
| requests: | ||
| cpu: 100m | ||
| memory: 200Mi | ||
| tests: | ||
| - as: rules-check | ||
| commands: | | ||
| cd /work | ||
| obsctl-reloader-rules-checker -t osd -d rules -y -p -T test/rules | ||
| container: | ||
| from: rules-checker-with-src | ||
| zz_generated_metadata: | ||
| branch: main | ||
| org: openshift-online | ||
| repo: rosa-rhobs-dashboards |
41 changes: 41 additions & 0 deletions
41
ci-operator/jobs/openshift-online/rosa-rhobs-dashboards/OWNERS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| approvers: | ||
| - aliceh | ||
| - anispate | ||
| - clcollins | ||
| - Mhodesty | ||
| - nephomaniac | ||
| - tnierman | ||
| - Ajpantuso | ||
| - bergmannf | ||
| - bmeng | ||
| - bpresnel-rh | ||
| - dustman9000 | ||
| - joshbranham | ||
| - psav | ||
| - rafael-azevedo | ||
| - ravitri | ||
| - rbhilare | ||
| - smarthall | ||
| - theautoroboto | ||
| - typeid | ||
| options: {} | ||
| reviewers: | ||
| - aliceh | ||
| - anispate | ||
| - clcollins | ||
| - Mhodesty | ||
| - nephomaniac | ||
| - tnierman | ||
| - Ajpantuso | ||
| - bergmannf | ||
| - bmeng | ||
| - bpresnel-rh | ||
| - dustman9000 | ||
| - joshbranham | ||
| - psav | ||
| - rafael-azevedo | ||
| - ravitri | ||
| - rbhilare | ||
| - smarthall | ||
| - theautoroboto | ||
| - typeid |
134 changes: 134 additions & 0 deletions
134
...-online/rosa-rhobs-dashboards/openshift-online-rosa-rhobs-dashboards-main-presubmits.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,134 @@ | ||
| presubmits: | ||
| openshift-online/rosa-rhobs-dashboards: | ||
| - agent: kubernetes | ||
| always_run: true | ||
| branches: | ||
| - ^main$ | ||
| - ^main- | ||
| cluster: build01 | ||
| context: ci/prow/images | ||
| decorate: true | ||
| decoration_config: | ||
| skip_cloning: true | ||
| labels: | ||
| ci.openshift.io/generator: prowgen | ||
| pj-rehearse.openshift.io/can-be-rehearsed: "true" | ||
| name: pull-ci-openshift-online-rosa-rhobs-dashboards-main-images | ||
| rerun_command: /test images | ||
| spec: | ||
| containers: | ||
| - args: | ||
| - --gcs-upload-secret=/secrets/gcs/service-account.json | ||
| - --image-import-pull-secret=/etc/pull-secret/.dockerconfigjson | ||
| - --oauth-token-path=/usr/local/github-credentials/oauth | ||
| - --report-credentials-file=/etc/report/credentials | ||
| - --target=[images] | ||
| command: | ||
| - ci-operator | ||
| image: quay-proxy.ci.openshift.org/openshift/ci:ci_ci-operator_latest | ||
| imagePullPolicy: Always | ||
| name: "" | ||
| resources: | ||
| requests: | ||
| cpu: 10m | ||
| volumeMounts: | ||
| - mountPath: /secrets/gcs | ||
| name: gcs-credentials | ||
| readOnly: true | ||
| - mountPath: /usr/local/github-credentials | ||
| name: github-credentials-openshift-ci-robot-private-git-cloner | ||
| readOnly: true | ||
| - mountPath: /secrets/manifest-tool | ||
| name: manifest-tool-local-pusher | ||
| readOnly: true | ||
| - mountPath: /etc/pull-secret | ||
| name: pull-secret | ||
| readOnly: true | ||
| - mountPath: /etc/report | ||
| name: result-aggregator | ||
| readOnly: true | ||
| serviceAccountName: ci-operator | ||
| volumes: | ||
| - name: github-credentials-openshift-ci-robot-private-git-cloner | ||
| secret: | ||
| secretName: github-credentials-openshift-ci-robot-private-git-cloner | ||
| - name: manifest-tool-local-pusher | ||
| secret: | ||
| secretName: manifest-tool-local-pusher | ||
| - name: pull-secret | ||
| secret: | ||
| secretName: registry-pull-credentials | ||
| - name: result-aggregator | ||
| secret: | ||
| secretName: result-aggregator | ||
| trigger: (?m)^/test( | .* )images,?($|\s.*) | ||
| - agent: kubernetes | ||
| always_run: true | ||
| branches: | ||
| - ^main$ | ||
| - ^main- | ||
| cluster: build01 | ||
| context: ci/prow/rules-check | ||
| decorate: true | ||
| decoration_config: | ||
| skip_cloning: true | ||
| labels: | ||
| ci.openshift.io/generator: prowgen | ||
| pj-rehearse.openshift.io/can-be-rehearsed: "true" | ||
| name: pull-ci-openshift-online-rosa-rhobs-dashboards-main-rules-check | ||
| rerun_command: /test rules-check | ||
| spec: | ||
| containers: | ||
| - args: | ||
| - --gcs-upload-secret=/secrets/gcs/service-account.json | ||
| - --image-import-pull-secret=/etc/pull-secret/.dockerconfigjson | ||
| - --oauth-token-path=/usr/local/github-credentials/oauth | ||
| - --report-credentials-file=/etc/report/credentials | ||
| - --target=rules-check | ||
| command: | ||
| - ci-operator | ||
| env: | ||
| - name: HTTP_SERVER_IP | ||
| valueFrom: | ||
| fieldRef: | ||
| fieldPath: status.podIP | ||
| image: quay-proxy.ci.openshift.org/openshift/ci:ci_ci-operator_latest | ||
| imagePullPolicy: Always | ||
| name: "" | ||
| ports: | ||
| - containerPort: 8080 | ||
| name: http | ||
| resources: | ||
| requests: | ||
| cpu: 10m | ||
| volumeMounts: | ||
| - mountPath: /secrets/gcs | ||
| name: gcs-credentials | ||
| readOnly: true | ||
| - mountPath: /usr/local/github-credentials | ||
| name: github-credentials-openshift-ci-robot-private-git-cloner | ||
| readOnly: true | ||
| - mountPath: /secrets/manifest-tool | ||
| name: manifest-tool-local-pusher | ||
| readOnly: true | ||
| - mountPath: /etc/pull-secret | ||
| name: pull-secret | ||
| readOnly: true | ||
| - mountPath: /etc/report | ||
| name: result-aggregator | ||
| readOnly: true | ||
| serviceAccountName: ci-operator | ||
| volumes: | ||
| - name: github-credentials-openshift-ci-robot-private-git-cloner | ||
| secret: | ||
| secretName: github-credentials-openshift-ci-robot-private-git-cloner | ||
| - name: manifest-tool-local-pusher | ||
| secret: | ||
| secretName: manifest-tool-local-pusher | ||
| - name: pull-secret | ||
| secret: | ||
| secretName: registry-pull-credentials | ||
| - name: result-aggregator | ||
| secret: | ||
| secretName: result-aggregator | ||
| trigger: (?m)^/test( | .* )rules-check,?($|\s.*) |
48 changes: 48 additions & 0 deletions
48
core-services/prow/02_config/openshift-online/rosa-rhobs-dashboards/_pluginconfig.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| approve: | ||
| - repos: | ||
| - openshift-online/rosa-rhobs-dashboards | ||
| require_self_approval: false | ||
| external_plugins: | ||
| openshift-online/rosa-rhobs-dashboards: | ||
| - endpoint: http://needs-rebase | ||
| events: | ||
| - issue_comment | ||
| - pull_request | ||
| name: needs-rebase | ||
| lgtm: | ||
| - repos: | ||
| - openshift-online/rosa-rhobs-dashboards | ||
| review_acts_as_lgtm: true | ||
| plugins: | ||
| openshift-online/rosa-rhobs-dashboards: | ||
| plugins: | ||
| - assign | ||
| - blunderbuss | ||
| - cat | ||
| - dog | ||
| - heart | ||
| - golint | ||
| - goose | ||
| - help | ||
| - hold | ||
| - jira | ||
| - label | ||
| - lgtm | ||
| - lifecycle | ||
| - override | ||
| - pony | ||
| - retitle | ||
| - shrug | ||
| - sigmention | ||
| - skip | ||
| - trigger | ||
| - verify-owners | ||
| - owners-label | ||
| - wip | ||
| - yuks | ||
| - approve | ||
| triggers: | ||
| - repos: | ||
| - openshift-online/rosa-rhobs-dashboards | ||
| trusted_apps: | ||
| - openshift-merge-bot | ||
14 changes: 14 additions & 0 deletions
14
core-services/prow/02_config/openshift-online/rosa-rhobs-dashboards/_prowconfig.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| tide: | ||
| queries: | ||
| - labels: | ||
| - approved | ||
| - lgtm | ||
| missingLabels: | ||
| - backports/unvalidated-commits | ||
| - do-not-merge/hold | ||
| - do-not-merge/invalid-owners-file | ||
| - do-not-merge/work-in-progress | ||
| - jira/invalid-bug | ||
| - needs-rebase | ||
| repos: | ||
| - openshift-online/rosa-rhobs-dashboards |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
Require independent approval for this ROSA repository.
require_self_approval: falsepermits the pull request author to satisfy the approval gate without an independent approval. Set it totrueto match the ROSA review policy and the nearbycore-services/prow/02_config/openshift-online/rosa-enhancements/_pluginconfig.yamlconfiguration.Based on learnings, ROSA-owned plugin configurations under
core-services/prow/02_config/openshift-onlinemust setapprove.require_self_approval: true.Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents
Source: Learnings