Add FIPS image scan to bgp-cloud-connector CI

[alebedev87]

Summary

• Add fips-check-image-scan presubmit test to bgp-cloud-connector CI config to verify the built container image contains FIPS-compliant Go binaries using check-payload scan local.

🤖 Generated with Claude Code

Summary by CodeRabbit

The bgp-cloud-connector CI configuration now includes an fips-image-scan presubmit test. The test uses check-payload scan local to verify that the built container image contains FIPS-compliant Go binaries.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: bac3a6fd-37d6-4783-b361-801ba099b11f

📥 Commits

Reviewing files that changed from the base of the PR and between 7fe9c10 and b6d4dc5.

⛔ Files ignored due to path filters (1)

• ci-operator/jobs/openshift/bgp-cloud-connector/openshift-bgp-cloud-connector-main-presubmits.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (1)

• ci-operator/config/openshift/bgp-cloud-connector/openshift-bgp-cloud-connector-main.yaml

Included review availability: Your plan includes up to 12 reviews per rolling hour; 11 remain after this review.

---

Walkthrough

The BGP cloud connector configuration now includes an fips-image-scan test that scans the bgp-cloud-connector image with the fips-check-image-scan test reference.

Changes

BGP cloud connector FIPS validation

Layer / File(s)	Summary
Add FIPS image scan test ci-operator/config/openshift/bgp-cloud-connector/openshift-bgp-cloud-connector-main.yaml	Adds an fips-image-scan test step for the bgp-cloud-connector image using fips-check-image-scan.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: 🔵 Low · up to b6d4d

The PR adds a presubmit image-scan check, but generated CI artifacts still need to be regenerated and verified so the check is actually scheduled. This is a bounded CI integration risk requiring owner follow-up; no production behavior is changed.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the addition of the FIPS image scan to the bgp-cloud-connector CI configuration.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The diff adds only static CI identifiers such as fips-image-scan; changed files contain no Ginkgo title calls or dynamic values in test titles.
Test Structure And Quality	✅ Passed	The commit changes only CI YAML and generated Prow YAML; no Ginkgo It blocks or test implementation changed. The shared FIPS command is unchanged.
Microshift Test Compatibility	✅ Passed	The diff adds only CI YAML and a generated presubmit job for fips-check-image-scan; it adds no Ginkgo e2e tests or MicroShift API references.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The diff adds only CI YAML for a FIPS image scan and its generated Prow job; changed files contain no new Ginkgo It, Describe, Context, or When tests.
Topology-Aware Scheduling Compatibility	✅ Passed	The diff only adds a CI presubmit and generated Prow job for fips-check-image-scan; it adds no deployment, operator, controller, or topology-sensitive scheduling constraint.
Ote Binary Stdout Contract	✅ Passed	The diff changes only CI YAML and generated Prow YAML; it adds a check-payload image scan, with no OTE binary or process-level stdout code.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The diff adds only CI YAML for the FIPS image scan and generated presubmit job; it adds no Ginkgo e2e test or IPv4/public-network behavior.
No-Weak-Crypto	✅ Passed	The diff only adds CI YAML for fips-check-image-scan and generated presubmit wiring; it adds no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparisons.
Container-Privileges	✅ Passed	The PR adds only a standard FIPS scan step and generated Prow job; changed manifests contain no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, root, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs	✅ Passed	The diff adds only a FIPS test reference and its generated Prow job; it adds no logging commands or password, token, API key, PII, hostname, or customer data values.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[alebedev87]

/pj-rehearse

[openshift-merge-bot]

@alebedev87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@alebedev87: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-bgp-cloud-connector-main-fips-image-scan	openshift/bgp-cloud-connector	presubmit	Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[alebedev87]

/pj-rehearse ack

[openshift-merge-bot]

@alebedev87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[mffiedler]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87, mffiedler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/bgp-cloud-connector/OWNERS [alebedev87]
• ci-operator/jobs/openshift/bgp-cloud-connector/OWNERS [alebedev87]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment