step-registry: fix rosa-gather-rhobs-logs image resolution - #83500
Conversation
The rosa-gather-rhobs-logs step ref uses `from: rosa-aws-cli`, which requires each consuming ci-operator config to import that image into the `stable` imagestream. Configs that do not import the image (e.g. FVT staging jobs) hit ImagePullBackOff for ~1 hour before the pod is reaped. Because the step is best_effort, the failure is silent. Switch to `from_image` so the step self-resolves the image directly from the ci registry (namespace: ci, name: rosa-aws-cli, tag: latest), matching the pattern used by other ROSA step refs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan includes up to 2 reviews per rolling hour; 1 remains after this review. WalkthroughThe ROSA RHOBS log gather step now uses a structured ChangesROSA RHOBS logs
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized image-resolution change is merge-ready after normal checks and review; no actionable merge-blocking risk remains. Suggested labels: Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error, 1 inconclusive)
✅ Passed checks (13 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[REHEARSALNOTIFIER]
A total of 29 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@redhat-chai-bot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dustman9000, redhat-chai-bot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
6666d23
into
openshift:main
2 participants
Summary
The
rosa-gather-rhobs-logsstep ref (introduced in #83482) specifiesfrom: rosa-aws-cli, which requires each consuming ci-operator config to importrosa-aws-cliinto itsstableimagestream viabase_images. The FVT staging configs do not import this image, so the step's pod sits inImagePullBackOfffor ~1 hour before being reaped on every run.Because the step is configured as
best_effort: true, these failures are silently swallowed — jobs still report success — which is why the breakage went unnoticed since the step was merged.Fix
Switch from
from:tofrom_image:, which resolves the image directly from thecinamespace registry without requiring downstream configs to import it:This matches the pattern used by other ROSA step refs that consume the same image.
Impact
rosa-gather-hcp-diagnosticschainrosa-aws-cliimage already exists atregistry.ci.openshift.org/ci/rosa-aws-cli:latestVerification
The ci-operator rehearsal on this PR should confirm that the image resolves correctly. The affected jobs include all variants of
cs-rosa-hcp-*-staging-mainin the FVT staging config (openshift-online/rosa-e2e).Evidence
Confirmed broken on both Aug 16 runs:
2088818288866889728(SUCCESS overall, step silently failed)2088858324459065344(FAILURE overall, step silently failed)Both showed identical
ErrImagePull: manifest unknownforstable:rosa-aws-cli.AI-generated. Review for accuracy.
@dustman9000 requested in Slack thread
Summary by CodeRabbit
rosa-gather-rhobs-logsto resolverosa-aws-clifromci/rosa-aws-cli:latestthroughfrom_image.ImagePullBackOfffailures caused by missing images in thestableimagestream for FVT staging jobs.