Revert #73835 due to scaling GCP workers from 6 to 4 cores

[jmencak]

Also see #82852

Summary by CodeRabbit

• Reverts the GCP worker CPU assumptions from PR #73835 after reducing workers from 6 to 4 cores.
• Updates Node Tuning Operator CI configurations for releases 4.22 through 5.2 and main.
• Removes fixed RESERVED_CPU_SET and ISOLATED_CPU_SET assignments from GCP PAO end-to-end tests.
• Preserves CLUSTER=mcp-only and the existing test targets.
• References PR #82852.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 7add8713-b90d-4e6a-836c-cc8b482dd18a

📥 Commits

Reviewing files that changed from the base of the PR and between fdd0005 and aaf3f54.

📒 Files selected for processing (6)

• ci-operator/config/openshift/cluster-node-tuning-operator/openshift-cluster-node-tuning-operator-main.yaml
• ci-operator/config/openshift/cluster-node-tuning-operator/openshift-cluster-node-tuning-operator-release-4.22.yaml
• ci-operator/config/openshift/cluster-node-tuning-operator/openshift-cluster-node-tuning-operator-release-4.23.yaml
• ci-operator/config/openshift/cluster-node-tuning-operator/openshift-cluster-node-tuning-operator-release-5.0.yaml
• ci-operator/config/openshift/cluster-node-tuning-operator/openshift-cluster-node-tuning-operator-release-5.1.yaml
• ci-operator/config/openshift/cluster-node-tuning-operator/openshift-cluster-node-tuning-operator-release-5.2.yaml

Included review availability: Your plan includes up to 12 reviews per rolling hour; 11 remain after this review.

---

Walkthrough

The CI configuration removes fixed reserved and isolated CPU assignments from GCP PAO tests across main and release 4.22 through 5.2 configurations. The commands retain CLUSTER=mcp-only, deployment steps, and their existing test targets.

Changes

PAO test CPU configuration

Layer / File(s)	Summary
Remove fixed CPU-set assignments ci-operator/config/openshift/cluster-node-tuning-operator/openshift-cluster-node-tuning-operator-*.yaml	The GCP PAO functional, updating-profile, and workload-hints commands no longer set RESERVED_CPU_SET or ISOLATED_CPU_SET. They retain the mcp-only cluster setting and existing test flows.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to aaf3f

This is a localized CI configuration update with no actionable merge-blocking risk remaining beyond confirming the normal regeneration check.

Suggested reviewers: jmguzik, deepsm007

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the revert and its reason, which matches the changes to GCP PAO test commands after worker CPU scaling.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The commit changes only six CI YAML command fields. It adds no Ginkgo title constructs or dynamic test-name values, so the check has no applicable failure.
Test Structure And Quality	✅ Passed	The patch changes only six YAML CI command entries and adds or removes no Ginkgo test constructs, so this Ginkgo quality check is not applicable.
Microshift Test Compatibility	✅ Passed	The diff changes only six CI YAML command blocks; it adds no Ginkgo tests or test code, so the MicroShift compatibility check does not apply.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The diff changes only six CI YAML command strings and adds no Ginkgo tests or multi-node test assumptions covered by this check.
Topology-Aware Scheduling Compatibility	✅ Passed	The diff only changes CI test command environment variables in six ci-operator YAML files; it adds no deployment manifests, operator code, controllers, or scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The commit changes only six YAML command definitions; the diff adds no Go code or process-level stdout/logging writes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The diff changes only six YAML command entries. It adds no Ginkgo tests, IPv4 literals, IPv4-only logic, or external-network commands.
No-Weak-Crypto	✅ Passed	The diff only changes six YAML test commands by removing CPU-set exports; no MD5, SHA1, DES, RC4, Blowfish, ECB, crypto code, or secret comparisons were introduced.
Container-Privileges	✅ Passed	The PR changes only PAO command strings in six CI YAML files; added lines contain no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, root, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs	✅ Passed	The diff adds only PAO test command strings; no logging calls or passwords, tokens, keys, PII, session IDs, hostnames, or customer data appear in added lines.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[jmencak]

/pj-rehearse ack

[openshift-merge-bot]

@jmencak: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@jmencak: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-cluster-node-tuning-operator-release-4.22-e2e-gcp-pao	openshift/cluster-node-tuning-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-node-tuning-operator-release-4.22-e2e-gcp-pao-updating-profile	openshift/cluster-node-tuning-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-node-tuning-operator-release-4.22-e2e-gcp-pao-workloadhints	openshift/cluster-node-tuning-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-node-tuning-operator-release-5.1-e2e-gcp-pao	openshift/cluster-node-tuning-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-node-tuning-operator-release-5.1-e2e-gcp-pao-updating-profile	openshift/cluster-node-tuning-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-node-tuning-operator-release-5.1-e2e-gcp-pao-workloadhints	openshift/cluster-node-tuning-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-node-tuning-operator-release-5.2-e2e-gcp-pao	openshift/cluster-node-tuning-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-node-tuning-operator-release-5.2-e2e-gcp-pao-updating-profile	openshift/cluster-node-tuning-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-node-tuning-operator-release-5.2-e2e-gcp-pao-workloadhints	openshift/cluster-node-tuning-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-node-tuning-operator-release-4.23-e2e-gcp-pao	openshift/cluster-node-tuning-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-node-tuning-operator-release-4.23-e2e-gcp-pao-updating-profile	openshift/cluster-node-tuning-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-node-tuning-operator-release-4.23-e2e-gcp-pao-workloadhints	openshift/cluster-node-tuning-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-node-tuning-operator-main-e2e-gcp-pao	openshift/cluster-node-tuning-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-node-tuning-operator-main-e2e-gcp-pao-updating-profile	openshift/cluster-node-tuning-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-node-tuning-operator-main-e2e-gcp-pao-workloadhints	openshift/cluster-node-tuning-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-node-tuning-operator-release-5.0-e2e-gcp-pao	openshift/cluster-node-tuning-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-node-tuning-operator-release-5.0-e2e-gcp-pao-updating-profile	openshift/cluster-node-tuning-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-node-tuning-operator-release-5.0-e2e-gcp-pao-workloadhints	openshift/cluster-node-tuning-operator	presubmit	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[jmencak]

/pj-rehearse pull-ci-openshift-cluster-node-tuning-operator-main-e2e-gcp-pao
/pj-rehearse pull-ci-openshift-cluster-node-tuning-operator-main-e2e-gcp-pao-workloadhints
/pj-rehearse pull-ci-openshift-cluster-node-tuning-operator-main-e2e-gcp-pao-updating-profile

/pj-rehearse pull-ci-openshift-cluster-node-tuning-operator-release-4.22-e2e-gcp-pao
/pj-rehearse pull-ci-openshift-cluster-node-tuning-operator-release-4.22-e2e-gcp-pao-workloadhints
/pj-rehearse pull-ci-openshift-cluster-node-tuning-operator-release-4.22-e2e-gcp-pao-updating-profile

[openshift-merge-bot]

@jmencak: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-merge-bot]

@jmencak: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command.

[openshift-merge-bot]

@jmencak: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command.

[openshift-merge-bot]

@jmencak: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command.

[openshift-merge-bot]

@jmencak: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command.

[openshift-merge-bot]

@jmencak: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command.

[jmencak]

/pj-rehearse pull-ci-openshift-cluster-node-tuning-operator-main-e2e-gcp-pao pull-ci-openshift-cluster-node-tuning-operator-main-e2e-gcp-pao-workloadhints pull-ci-openshift-cluster-node-tuning-operator-main-e2e-gcp-pao-updating-profile pull-ci-openshift-cluster-node-tuning-operator-release-4.22-e2e-gcp-pao pull-ci-openshift-cluster-node-tuning-operator-release-4.22-e2e-gcp-pao-workloadhints pull-ci-openshift-cluster-node-tuning-operator-release-4.22-e2e-gcp-pao-updating-profile

[openshift-merge-bot]

@jmencak: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[jmencak]

/pj-rehearse pull-ci-openshift-cluster-node-tuning-operator-main-e2e-gcp-pao-updating-profile pull-ci-openshift-cluster-node-tuning-operator-main-e2e-gcp-pao

[openshift-merge-bot]

@jmencak: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[jmencak]

This failure looks permanent, but let's retry one more time:
/pj-rehearse pull-ci-openshift-cluster-node-tuning-operator-main-e2e-gcp-pao-updating-profile

[openshift-merge-bot]

@jmencak: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[shajmakh]

/lgtm
failures on the tests in rehearsals lane should be taken care of by calculating the requested CPUs vs what how many free CPUs the node can offer

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, shajmakh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/cluster-node-tuning-operator/OWNERS [jmencak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@jmencak: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/openshift/cluster-node-tuning-operator/main/e2e-gcp-pao-updating-profile	aaf3f54	link	unknown	/pj-rehearse pull-ci-openshift-cluster-node-tuning-operator-main-e2e-gcp-pao-updating-profile

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.