Skip to content

Add ai analyzer to NHC system-tests jobs - #83444

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
abrugaro:add-analyzer-to-nhc-system-tests
Aug 17, 2026
Merged

Add ai analyzer to NHC system-tests jobs#83444
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
abrugaro:add-analyzer-to-nhc-system-tests

Conversation

@abrugaro

@abrugaro abrugaro commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Adds the claude-ai-helpers base image to Medik8s system-test jobs.
  • Adds failure analysis to AWS NHC ad hoc and weekly tests.
  • Passes each test name and step identifiers to medik8s-analyze-e2e-failure.

Signed-off-by: Alejandro Brugarolas <abrugaro@redhat.com>
@abrugaro

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-medik8s-system-tests-main-4.22-konflux-e2e-nhc-weekly-aws

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@abrugaro: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 27ddd4c9-2c6b-4217-ba41-68865928c7fa

📥 Commits

Reviewing files that changed from the base of the PR and between 084f189 and f597edd.

📒 Files selected for processing (1)
  • ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__4.22-konflux.yaml

Walkthrough

The Konflux configuration adds the claude-ai-helpers image and failure-analysis post steps to the AWS NHC ad hoc and weekly tests.

Changes

AWS NHC failure analysis

Layer / File(s) Summary
Helper image declaration
ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__4.22-konflux.yaml
Adds the claude-ai-helpers image from the ci namespace with the latest tag.
AWS NHC analysis hooks
ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__4.22-konflux.yaml
Adds TEST_NAME, TEST_STEPS, and the medik8s-analyze-e2e-failure post step to the ad hoc and weekly AWS NHC tests.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to f597e

The PR adds post steps to two NHC system-tests jobs. No actionable merge-blocking risk remains; complete the standard configuration regeneration and validation checks before merging.

Suggested reviewers: ugreener, maximunited, gamado

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the addition of the AI analyzer to NHC system-test jobs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The diff changes CI YAML only. It adds static TEST_NAME values and the e2e-test step; it introduces no Ginkgo It, Describe, Context, or other test title.
Test Structure And Quality ✅ Passed The PR changes only one CI YAML file: a base image and post-step environment for two jobs. It adds no Ginkgo It, BeforeEach, AfterEach, Eventually, or Consistently code.
Microshift Test Compatibility ✅ Passed The diff changes only one YAML job configuration file and adds no Ginkgo tests or new API/resource references.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The diff changes only CI YAML: it adds an image, analyzer post steps, and env values; it adds no Ginkgo test declarations or multi-node assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed The pull request changes only CI test configuration: a base image and post-test analysis steps. It adds no deployment manifests, operator code, controllers, or scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The diff only adds CI YAML base-image, environment, and a separate post-step; it changes no OTE binary or suite setup, and the existing make run-tests command is unchanged.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The diff changes only CI YAML wiring; it adds no Ginkgo It/Describe/Context/When test and no IPv4 assumption in test code. The compatibility check is not applicable.
No-Weak-Crypto ✅ Passed The diff only adds the Claude helper image and analyzer post-steps. No MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparisons were introduced.
Container-Privileges ✅ Passed The PR diff adds a base-image reference, test environment variables, and post-step references only; it adds no privileged, host namespace, SYS_ADMIN, root, or allowPrivilegeEscalation setting.
No-Sensitive-Data-In-Logs ✅ Passed The PR adds only an image reference, test identifiers, and an existing analyzer ref; no new logging or sensitive literals are introduced, and the analyzer code is unchanged.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 14, 2026
@openshift-ci

openshift-ci Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Hi @abrugaro. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@abrugaro: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-medik8s-system-tests-main-4.22-konflux-e2e-far-aws medik8s/system-tests presubmit Ci-operator config changed
pull-ci-medik8s-system-tests-main-4.22-konflux-e2e-far-nhc-interop-aws medik8s/system-tests presubmit Ci-operator config changed
pull-ci-medik8s-system-tests-main-4.22-konflux-e2e-mdr-aws medik8s/system-tests presubmit Ci-operator config changed
pull-ci-medik8s-system-tests-main-4.22-konflux-e2e-nhc-aws medik8s/system-tests presubmit Ci-operator config changed
pull-ci-medik8s-system-tests-main-4.22-konflux-e2e-nmo-aws medik8s/system-tests presubmit Ci-operator config changed
pull-ci-medik8s-system-tests-main-4.22-konflux-e2e-sbr-aws-efs medik8s/system-tests presubmit Ci-operator config changed
pull-ci-medik8s-system-tests-main-4.22-konflux-e2e-sbr-aws-odf medik8s/system-tests presubmit Ci-operator config changed
pull-ci-medik8s-system-tests-main-4.22-konflux-e2e-sbr-hypershift-aws-odf medik8s/system-tests presubmit Ci-operator config changed
pull-ci-medik8s-system-tests-main-4.22-konflux-e2e-sbr-hypershift-persistent-aws-odf medik8s/system-tests presubmit Ci-operator config changed
pull-ci-medik8s-system-tests-main-4.22-konflux-e2e-snr-aws medik8s/system-tests presubmit Ci-operator config changed
periodic-ci-medik8s-system-tests-main-4.22-konflux-e2e-snr-weekly-aws N/A periodic Ci-operator config changed
periodic-ci-medik8s-system-tests-main-4.22-konflux-e2e-far-nhc-interop-weekly-aws N/A periodic Ci-operator config changed
periodic-ci-medik8s-system-tests-main-4.22-konflux-e2e-far-weekly-aws N/A periodic Ci-operator config changed
periodic-ci-medik8s-system-tests-main-4.22-konflux-e2e-mdr-weekly-aws N/A periodic Ci-operator config changed
periodic-ci-medik8s-system-tests-main-4.22-konflux-e2e-nhc-weekly-aws N/A periodic Ci-operator config changed
periodic-ci-medik8s-system-tests-main-4.22-konflux-e2e-nmo-weekly-aws N/A periodic Ci-operator config changed
periodic-ci-medik8s-system-tests-main-4.22-konflux-e2e-sbr-weekly-aws-efs N/A periodic Ci-operator config changed
periodic-ci-medik8s-system-tests-main-4.22-konflux-e2e-sbr-weekly-aws-odf N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@abrugaro

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-medik8s-system-tests-main-4.22-konflux-e2e-nhc-aws

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@abrugaro: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@abrugaro: needs-ok-to-test label found, no rehearsals will be run

@pranavgaikwad

Copy link
Copy Markdown

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 14, 2026
@abrugaro

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-medik8s-system-tests-main-4.22-konflux-e2e-nhc-aws

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@abrugaro: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@abrugaro

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-medik8s-system-tests-main-4.22-konflux-e2e-nhc-weekly-aws

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@abrugaro: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@razo7 razo7 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite similar PR to #82802
/pj-rehearse ack

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2026
@openshift-ci

openshift-ci Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrugaro, razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2026
@razo7

razo7 commented Aug 17, 2026

Copy link
Copy Markdown
Member

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 17, 2026
@openshift-ci

openshift-ci Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

@abrugaro: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 9a8cd18 into openshift:main Aug 17, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants