Skip to content

HYPERFLEET-1486 - chore: configure Prow CI for hyperfleet-logger - #83347

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
rafabene:HYPERFLEET-1486-prow-ci-hyperfleet-logger
Aug 13, 2026
Merged

HYPERFLEET-1486 - chore: configure Prow CI for hyperfleet-logger#83347
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
rafabene:HYPERFLEET-1486-prow-ci-hyperfleet-logger

Conversation

@rafabene

@rafabene rafabene commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add CI operator config with lint and unit presubmit jobs for openshift-hyperfleet/hyperfleet-logger
  • Configure Prow plugins (approve, lgtm, needs-rebase, refresh, triggers) and Tide merge policy with standard HyperFleet label requirements
  • No postsubmit job needed — hyperfleet-logger is a pure Go library with no Docker image to promote

Test plan

  • Prow job rehearsal passes for presubmit lint and unit jobs
  • /lgtm and /approve commands work on PRs
  • Tide auto-merges with approved + lgtm labels

Summary by CodeRabbit

  • Configures OpenShift CI for openshift-hyperfleet/hyperfleet-logger.
  • Adds lint and unit presubmit jobs using the RHEL 9 Go 1.26 builder image.
  • Enables Prow approval, LGTM, rebase, refresh, and trigger plugins.
  • Adds Tide merge requirements for approved and lgtm labels.
  • Excludes blocking labels from Tide queries.
  • Adds generated OWNERS metadata for the repository.
  • Omits postsubmit configuration because the repository is a pure Go library without a Docker image to promote.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 41638801-1079-4f8e-a5ea-329dedb936e6

📥 Commits

Reviewing files that changed from the base of the PR and between c53b104 and 113d7f3.

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/openshift-hyperfleet/hyperfleet-logger/OWNERS is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-hyperfleet/hyperfleet-logger/openshift-hyperfleet-hyperfleet-logger-main-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (4)
  • ci-operator/config/openshift-hyperfleet/hyperfleet-logger/OWNERS
  • ci-operator/config/openshift-hyperfleet/hyperfleet-logger/openshift-hyperfleet-hyperfleet-logger-main.yaml
  • core-services/prow/02_config/openshift-hyperfleet/hyperfleet-logger/_pluginconfig.yaml
  • core-services/prow/02_config/openshift-hyperfleet/hyperfleet-logger/_prowconfig.yaml
🚧 Files skipped from review as they are similar to previous changes (4)
  • ci-operator/config/openshift-hyperfleet/hyperfleet-logger/openshift-hyperfleet-hyperfleet-logger-main.yaml
  • ci-operator/config/openshift-hyperfleet/hyperfleet-logger/OWNERS
  • core-services/prow/02_config/openshift-hyperfleet/hyperfleet-logger/_prowconfig.yaml
  • core-services/prow/02_config/openshift-hyperfleet/hyperfleet-logger/_pluginconfig.yaml

Walkthrough

The change onboards openshift-hyperfleet/hyperfleet-logger with CI jobs, ownership data, Prow plugin settings, and Tide merge queries for the main branch.

Changes

Hyperfleet logger onboarding

Layer / File(s) Summary
CI build and test validation
ci-operator/config/openshift-hyperfleet/hyperfleet-logger/openshift-hyperfleet-hyperfleet-logger-main.yaml
Configures the RHEL 9 Go 1.26 builder, resource settings, lint and unit test jobs, and repository metadata.
Repository ownership and review settings
ci-operator/config/openshift-hyperfleet/hyperfleet-logger/OWNERS, core-services/prow/02_config/openshift-hyperfleet/hyperfleet-logger/_pluginconfig.yaml
Adds approvers and reviewers. Enables approval, LGTM, lifecycle, labeling, triggering, workflow, external plugin, and trusted merge-bot settings.
Tide merge query
core-services/prow/02_config/openshift-hyperfleet/hyperfleet-logger/_prowconfig.yaml
Requires approved and lgtm labels and excludes specified blocking labels.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested labels: ok-to-test

Suggested reviewers: pruan-rht, psalajova

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR adds only CI and Prow YAML/OWNERS files; the parent-to-HEAD diff contains no Ginkgo test declarations or test titles, dynamic or otherwise.
Test Structure And Quality ✅ Passed The pull request changes only YAML and OWNERS configuration; no Ginkgo test code or It blocks were added or modified, so these test-quality requirements are inapplicable.
Microshift Test Compatibility ✅ Passed The commit adds only CI/Prow YAML and OWNERS files; the diff contains no new Ginkgo e2e tests or MicroShift-incompatible API references.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR diff adds only YAML and OWNERS files; it adds no Go/e2e tests, Ginkgo declarations, or multi-node topology assumptions. The SNO check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The PR adds only CI and Prow configuration; no deployment manifests, operators, controllers, or topology-related scheduling constraints were changed.
Ote Binary Stdout Contract ✅ Passed The six-file diff adds only CI/Prow YAML and OWNERS; it adds no Go entry points, OTE binary, suite setup, or process-level stdout write.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The diff adds only YAML and OWNERS configuration; it introduces no Ginkgo tests, IPv4 assumptions, or external connectivity requirements in test code.
No-Weak-Crypto ✅ Passed The PR adds only YAML/OWNERS configuration. The parent-to-HEAD diff contains no MD5, SHA1, DES, RC4, Blowfish, ECB, crypto implementation, or secret-comparison code.
Container-Privileges ✅ Passed The added CI and Prow manifests contain no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or runAsUser: 0 settings.
No-Sensitive-Data-In-Logs ✅ Passed The commit adds only Prow/CI YAML. It contains no logging statements or sensitive values; generated jobs reference mounted credential paths without printing their contents.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the primary change: configuring Prow CI for hyperfleet-logger.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from pruan-rht and psalajova August 12, 2026 17:39
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2026
@rafabene
rafabene force-pushed the HYPERFLEET-1486-prow-ci-hyperfleet-logger branch from dfd65fb to 7d6f3e2 Compare August 12, 2026 17:45
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@rafabene

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@rafabene: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Add CI operator config with lint and unit presubmit jobs, Prow plugin
config (approve, lgtm, triggers), and Tide merge policy for the new
hyperfleet-logger repository.
@rafabene
rafabene force-pushed the HYPERFLEET-1486-prow-ci-hyperfleet-logger branch from 7d6f3e2 to 113d7f3 Compare August 12, 2026 19:21
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@rafabene: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-hyperfleet-hyperfleet-logger-main-lint openshift-hyperfleet/hyperfleet-logger presubmit Presubmit changed
pull-ci-openshift-hyperfleet-hyperfleet-logger-main-unit openshift-hyperfleet/hyperfleet-logger presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

@rafabene: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift-hyperfleet/hyperfleet-logger/main/lint 7d6f3e2 link unknown /pj-rehearse pull-ci-openshift-hyperfleet-hyperfleet-logger-main-lint
ci/rehearse/openshift-hyperfleet/hyperfleet-logger/main/unit 7d6f3e2 link unknown /pj-rehearse pull-ci-openshift-hyperfleet-hyperfleet-logger-main-unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kuudori

kuudori commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2026
@openshift-ci

openshift-ci Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kuudori, rafabene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kuudori

kuudori commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

/pj-rehearse ack

1 similar comment
@kuudori

kuudori commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@kuudori: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.

1 similar comment
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@kuudori: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.

@kuudori

kuudori commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@kuudori: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 13, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 80778f2 into openshift:main Aug 13, 2026
20 checks passed
@openshift-ci

openshift-ci Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

@rafabene: Updated the following 2 configmaps:

  • config configmap in namespace ci at cluster app.ci using the following files:
    • key core-services-prow-02_config-openshift-hyperfleet-hyperfleet-logger-_prowconfig.yaml using file core-services/prow/02_config/openshift-hyperfleet/hyperfleet-logger/_prowconfig.yaml
  • config configmap in namespace ci at cluster core-ci using the following files:
    • key core-services-prow-02_config-openshift-hyperfleet-hyperfleet-logger-_prowconfig.yaml using file core-services/prow/02_config/openshift-hyperfleet/hyperfleet-logger/_prowconfig.yaml
Details

In response to this:

Summary

  • Add CI operator config with lint and unit presubmit jobs for openshift-hyperfleet/hyperfleet-logger
  • Configure Prow plugins (approve, lgtm, needs-rebase, refresh, triggers) and Tide merge policy with standard HyperFleet label requirements
  • No postsubmit job needed — hyperfleet-logger is a pure Go library with no Docker image to promote

Test plan

  • Prow job rehearsal passes for presubmit lint and unit jobs
  • /lgtm and /approve commands work on PRs
  • Tide auto-merges with approved + lgtm labels

Summary by CodeRabbit

  • Configures OpenShift CI for openshift-hyperfleet/hyperfleet-logger.
  • Adds lint and unit presubmit jobs using the RHEL 9 Go 1.26 builder image.
  • Enables Prow approval, LGTM, rebase, refresh, and trigger plugins.
  • Adds Tide merge requirements for approved and lgtm labels.
  • Excludes blocking labels from Tide queries.
  • Adds generated OWNERS metadata for the repository.
  • Omits postsubmit configuration because the repository is a pure Go library without a Docker image to promote.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

TimurMP pushed a commit to TimurMP/release that referenced this pull request Sep 5, 2026
…nshift#83347)

Add CI operator config with lint and unit presubmit jobs, Prow plugin
config (approve, lgtm, triggers), and Tide merge policy for the new
hyperfleet-logger repository.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants