ci-staging: back job-configs-nfs on app.ci with AWS EFS - #83265
Conversation
WalkthroughThe change installs the AWS EFS CSI driver, provisions its AWS credentials, documents the credential secret, and adds a retained 10Gi EFS-backed PersistentVolume with an explicitly bound staging claim. ChangesAWS EFS storage integration
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant CredentialsRequest
participant CloudCredentialOperator
participant EFSCSI
participant PersistentVolumeClaim
participant PersistentVolume
participant AWS EFS
CredentialsRequest->>CloudCredentialOperator: Request EFS and EC2 permissions
CloudCredentialOperator->>EFSCSI: Provision aws-efs-cloud-credentials
EFSCSI->>PersistentVolume: Use efs.csi.aws.com
PersistentVolumeClaim->>PersistentVolume: Bind job-configs-nfs to job-configs-efs
PersistentVolume->>AWS EFS: Reference the fixed filesystem handle
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@Prucek: |
Adds the OLM aws-efs-csi-driver-operator subscription and its ClusterCSIDriver, plus a CredentialsRequest so app.ci's cloud-credential-operator (Mint mode, same as the existing EBS driver) auto-provisions the aws-efs-cloud-credentials secret. Requires openshift#83268 (whitelists these resource kinds in the app-ci ArgoCD AppProject) to merge first.
The ci-staging Prow deployment on app.ci already mounts a PVC named job-configs-nfs, but nothing in git ever provisioned it. Bind a static PV/PVC to a newly created EFS filesystem so the volume is reproducible, and document the CSI driver's credentials secret. Requires openshift#83268 (whitelists PersistentVolume in the app-ci ArgoCD AppProject) to merge first.
a4deff4 to
a4aee25
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
@Prucek: |
|
/retest-required |
1 similar comment
|
/retest-required |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deepsm007, Prucek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse ack |
|
@Prucek: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@Prucek: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
) * app.ci: install AWS EFS CSI driver operator Adds the OLM aws-efs-csi-driver-operator subscription and its ClusterCSIDriver, plus a CredentialsRequest so app.ci's cloud-credential-operator (Mint mode, same as the existing EBS driver) auto-provisions the aws-efs-cloud-credentials secret. Requires openshift#83268 (whitelists these resource kinds in the app-ci ArgoCD AppProject) to merge first. * ci-staging: back job-configs-nfs on app.ci with AWS EFS The ci-staging Prow deployment on app.ci already mounts a PVC named job-configs-nfs, but nothing in git ever provisioned it. Bind a static PV/PVC to a newly created EFS filesystem so the volume is reproducible, and document the CSI driver's credentials secret. Requires openshift#83268 (whitelists PersistentVolume in the app-ci ArgoCD AppProject) to merge first.
Summary
job-configs-nfsPVC (already referenced by ci-staging's hook/horologium/tide/prow-controller-manager/statusreconciler manifests but never defined in git) to a static PV backed by a newly created EFS filesystemDepends on #83268 (whitelists
PersistentVolumeandCredentialsRequestin the app-ci ArgoCD AppProject) —cluster-manifest-verifiervalidates new resource kinds against the AppProject already live on the Argo CD server, so that PR must merge first.