Add ssh-bastion to interop jobs and exclude interop tests from FAR standalone jobs - #83179
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan includes up to 2 reviews per rolling hour; 1 remains after this review. WalkthroughThe Medik8s FAR AWS workflows exclude upgrade and interop tiers from test selection. The FAR/NHC interop AWS workflows run ChangesMedik8s AWS workflow updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized configuration change adds the required SSH access step for interop jobs and excludes incompatible tests from standalone FAR jobs; no actionable merge-blocking risk remains beyond normal checks and review. Suggested labels: Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-ci
Bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__4.22-konflux.yaml`:
- Line 78: Update the ssh-bastion step, identified by the removed ref:
ssh-bastion, so its remote deploy script is fetched from a reviewed immutable
commit or otherwise ensure AWS credentials are unset before invoking it.
Preserve the step’s deployment behavior while preventing mutable master-branch
code from running with credentials.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 60a15060-e89e-4330-b789-6ae9e114ec07
📒 Files selected for processing (1)
ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__4.22-konflux.yaml
d74a111 to
b948f5b
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
ugreener
changed the title
|
/pj-rehearse pull-ci-medik8s-system-tests-main-4.22-konflux-e2e-far-nhc-interop-aws |
|
@ugreener: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Do we need to add the |
|
@abrugaro: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| test: | ||
| - chain: medik8s-setup | ||
| - ref: medik8s-aws-credentials | ||
| - ref: ssh-bastion |
There was a problem hiding this comment.
Missing from weekly interop: ssh-bastion is added here for the presubmit interop job, but the parallel weekly periodic job (e2e-far-nhc-interop-weekly-aws, ~line 602) does not get it. Both jobs run the same interop tests (operator:far && operator:nhc && tier:interop) with NHC installed, and NHC tests need SSH bastion for kubelet-stop operations. Add - ref: ssh-bastion after medik8s-aws-credentials in the weekly interop job too.
There was a problem hiding this comment.
Added - ref: ssh-bastion to e2e-far-nhc-interop-weekly-aws after medik8s-aws-credentials, matching the presubmit interop job e2e-far-nhc-interop-aws. The standalone NHC jobs (e2e-nhc-aws, e2e-nhc-weekly-aws) already use ssh-bastion for the same kubelet-stop reason. HEAD f579be0 (ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__4.22-konflux.yaml:603).
b948f5b to
f579be0
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
ugreener
changed the title
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@abrugaro Yes - it was needed and is now added in HEAD f579be0. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abrugaro, razo7, ugreener The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse pull-ci-medik8s-system-tests-main-4.22-konflux-e2e-far-nhc-interop-aws periodic-ci-medik8s-system-tests-main-4.22-konflux-e2e-far-nhc-interop-weekly-aws |
|
@ugreener: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse ack |
|
@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
@ugreener: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Problem
The NHC+FAR interop test (RHWA-1035) needs to stop kubelet on a worker node to simulate an unhealthy node for NHC to detect. Without ssh-bastion, the test relies on
oc debugwhich consistently fails: the debug pod dies when kubelet stops, causingoc debugto exit with error. Kubelet then auto-restarts before NHC's 30s unhealthy duration threshold is met, so NHC never triggers remediation.Additionally, the FAR standalone jobs (
e2e-far-aws,e2e-far-weekly-aws) filter with!tier:upgradebut would still match interop tests. Since those jobs don't install NHC or deploy ssh-bastion, interop tests would fail.Summary
ssh-bastionstep reference to both interop jobs,e2e-far-nhc-interop-aws(presubmit) ande2e-far-nhc-interop-weekly-aws(weekly periodic), matching the ssh-bastion usage in the standalone NHC jobs (e2e-nhc-aws,e2e-nhc-weekly-aws)!tier:upgradeto!tier:upgrade && !tier:interopChanges
medik8s-system-tests-main__4.22-konflux.yaml: added- ref: ssh-bastionto both interop jobs' test steps (e2e-far-nhc-interop-awsande2e-far-nhc-interop-weekly-aws)medik8s-system-tests-main__4.22-konflux.yaml: changedECO_TEST_LABELSfrom!tier:upgradeto!tier:upgrade && !tier:interopin bothe2e-far-aws(presubmit) ande2e-far-weekly-aws(periodic)Summary by CodeRabbit
ECO_TEST_LABELS.ssh-bastionstep to the FAR/NHC interop AWS workflow after AWS credential setup.