HyperShift integration should edit the api go.mod

[JoelSpeed]

This is meant to protect merges to openshift/api from breaking hypershift. However it was editing the wrong go.mod and therefore the make api was actually having no effect. This hopefully resolves the issue

Summary by CodeRabbit

The HyperShift integration check now edits the correct openshift/api go.mod file. It applies local replacements and updates vendor/modules.txt relative to the HyperShift API module, so make api affects the intended module and detects compatibility issues before merges to openshift/api.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 700769df-5935-4db0-9d3d-5636f744157a

📥 Commits

Reviewing files that changed from the base of the PR and between 93dcaa0 and e01cab7.

📒 Files selected for processing (1)

• ci-operator/config/openshift/api/openshift-api-master.yaml

---

Walkthrough

The Hypershift integration verification command now performs replacements and vendoring from $dir/api. It uses sibling paths for local repositories and returns to the parent directory before running the API test environment.

Changes

Hypershift API integration

Layer / File(s)	Summary
Update API module paths ci-operator/config/openshift/api/openshift-api-master.yaml	The verification setup runs from $dir/api, updates replacement and vendor paths, and returns to the parent directory before testing.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the main change: updating HyperShift integration to edit the correct API go.mod file.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR changes only CI shell commands in YAML; no Ginkgo It/Describe/Context/When titles were added or changed, and the step name is static.
Test Structure And Quality	✅ Passed	The PR modifies only a CI configuration YAML file (openshift-api-master.yaml), not Ginkgo test code. The custom check targets Ginkgo test structure and quality, which does not apply here. The chang...
Microshift Test Compatibility	✅ Passed	This PR modifies only a CI configuration file and does not add any new Ginkgo e2e tests, so the MicroShift test compatibility check does not apply.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The pull request changes only a CI YAML command block; it adds no Ginkgo e2e tests or test declarations requiring SNO compatibility review.
Topology-Aware Scheduling Compatibility	✅ Passed	The pull request changes only a CI YAML test command. It adds no deployment manifests, operator code, controllers, replicas, affinity, topology spread, selectors, tolerations, or PDBs.
Ote Binary Stdout Contract	✅ Passed	The PR changes only a CI YAML shell command; it adds no Go OTE binary, main/suite setup, or process-level stdout logging. The added echo writes vendor/modules.txt.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR only changes paths and directory navigation in an existing YAML verification command; it adds no Ginkgo e2e test or new IPv4 or external-connectivity requirement.
No-Weak-Crypto	✅ Passed	The pull request changes only CI path and Go module replacement commands; scans found no MD5, SHA1, DES, RC4, Blowfish, ECB, or secret-comparison usage.
Container-Privileges	✅ Passed	The only changed file updates Hypershift shell paths and uses container: from: src; it adds no privileged, host namespace, SYS_ADMIN, root, or allowPrivilegeEscalation setting.
No-Sensitive-Data-In-Logs	✅ Passed	The patch only changes directory paths and echoes fixed module replacement comments; it adds no passwords, tokens, API keys, PII, hostnames, or customer data to logs.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@JoelSpeed: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-api-master-verify-hypershift-integration	openshift/api	presubmit	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[clebs]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clebs, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/api/OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[JoelSpeed]

/pj-rehearse ack

[openshift-merge-bot]

@JoelSpeed: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@JoelSpeed: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.