Skip to content

Add Prow plugin and tide config for openshift/bgp-cloud-connector - #82795

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
alebedev87:bgp-cloud-connector
Aug 17, 2026
Merged

Add Prow plugin and tide config for openshift/bgp-cloud-connector#82795
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
alebedev87:bgp-cloud-connector

Conversation

@alebedev87

@alebedev87 alebedev87 commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Enable approve, lgtm, and label plugins for openshift/bgp-cloud-connector
  • Tide merge policy requires approved and lgtm labels on main

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Added Prow configuration for openshift/bgp-cloud-connector.
  • Enabled the approve, lgtm, and label plugins without requiring self-approval.
  • Configured Tide to merge pull requests into main only when they have both approved and lgtm labels.
  • Excluded pull requests with hold, ownership, Jira, or rebase-related labels.
  • Delegated CI handling to Konflux.

@openshift-ci
openshift-ci Bot requested review from hector-vido and pruan-rht August 3, 2026 09:48
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2026
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 9b06bd41-7243-484c-ab38-eab1302814f7

📥 Commits

Reviewing files that changed from the base of the PR and between 7fe9c10 and 27103c2.

📒 Files selected for processing (2)
  • core-services/prow/02_config/openshift/bgp-cloud-connector/_pluginconfig.yaml
  • core-services/prow/02_config/openshift/bgp-cloud-connector/_prowconfig.yaml
🚧 Files skipped from review as they are similar to previous changes (2)
  • core-services/prow/02_config/openshift/bgp-cloud-connector/_pluginconfig.yaml
  • core-services/prow/02_config/openshift/bgp-cloud-connector/_prowconfig.yaml

Included review availability: Your plan includes up to 12 reviews per rolling hour; 10 remain after this review.


Walkthrough

Adds Prow plugin and Tide configuration for openshift/bgp-cloud-connector. The configuration enables approval and LGTM handling, disables self-approval requirements, and defines merge criteria for the main branch.

Changes

Prow repository onboarding

Layer / File(s) Summary
Approval plugins and Tide merge criteria
core-services/prow/02_config/openshift/bgp-cloud-connector/*
Enables the approve plugin, configures approval and LGTM handling, disables self-approval requirements, and requires approved and lgtm labels for main while rejecting blocking labels.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 27103

This change adds localized Prow and Tide configuration for the repository, and no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: pruan-rht, hector-vido

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The diff adds only two Prow YAML files. It introduces no Ginkgo tests or test titles, so it cannot introduce unstable or dynamic test names.
Test Structure And Quality ✅ Passed The pull request changes only two YAML Prow configuration files. It adds no Ginkgo tests or cluster operations, so the listed test-quality checks do not apply.
Microshift Test Compatibility ✅ Passed The pull request adds only two Prow YAML configuration files. It adds no Ginkgo e2e tests or references to MicroShift-incompatible APIs or features.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The diff adds only two Prow YAML configuration files. It adds no Ginkgo e2e tests or multi-node assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed The diff adds only Prow plugin and Tide YAML; it adds no deployment manifest, operator, controller, replica, affinity, node-selection, or disruption scheduling constraint.
Ote Binary Stdout Contract ✅ Passed The commit adds only two YAML Prow configuration files. It introduces no OTE binary process code or stdout writes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit adds only two Prow YAML configuration files; it adds no Ginkgo e2e tests, IPv4 assumptions, or external connectivity requirements.
No-Weak-Crypto ✅ Passed The verified diff adds only Prow YAML for approval, LGTM, plugins, and Tide; it introduces no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparisons.
Container-Privileges ✅ Passed The PR adds only Prow plugin and Tide YAML. The changed files contain no container manifest or privilege keys such as privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation.
No-Sensitive-Data-In-Logs ✅ Passed The diff adds only Prow approval, LGTM, plugin, and Tide YAML; it contains no logging code or password, token, API key, PII, hostname, or customer data.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the added Prow plugin and Tide configuration for the specified repository.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 3, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@core-services/prow/02_config/openshift/bgp-cloud-connector/_pluginconfig.yaml`:
- Around line 5-7: Add review-based LGTM configuration for the
openshift/bgp-cloud-connector repository by setting review_acts_as_lgtm to true
in the plugin configuration alongside the existing lgtm repository entry, so
GitHub approvals satisfy the Tide query.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 498608e6-2853-487e-bf6f-743149767fcf

📥 Commits

Reviewing files that changed from the base of the PR and between a996379 and 73cdf9c.

📒 Files selected for processing (2)
  • core-services/prow/02_config/openshift/bgp-cloud-connector/_pluginconfig.yaml
  • core-services/prow/02_config/openshift/bgp-cloud-connector/_prowconfig.yaml

@alebedev87

Copy link
Copy Markdown
Contributor Author

/retest

Enable approve, lgtm, and label plugins. Tide merge policy requires
`approved` and `lgtm` labels on `main`.

Co-Authored-By: Claude
@alebedev87
alebedev87 force-pushed the bgp-cloud-connector branch from 5666e0c to 27103c2 Compare August 17, 2026 16:48
@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@alebedev87: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@mffiedler

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2026
@openshift-ci

openshift-ci Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87, mffiedler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit cc2ec2b into openshift:main Aug 17, 2026
11 of 12 checks passed
@openshift-ci

openshift-ci Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

@alebedev87: Updated the following 2 configmaps:

  • config configmap in namespace ci at cluster app.ci using the following files:
    • key core-services-prow-02_config-openshift-bgp-cloud-connector-_prowconfig.yaml using file core-services/prow/02_config/openshift/bgp-cloud-connector/_prowconfig.yaml
  • config configmap in namespace ci at cluster core-ci using the following files:
    • key core-services-prow-02_config-openshift-bgp-cloud-connector-_prowconfig.yaml using file core-services/prow/02_config/openshift/bgp-cloud-connector/_prowconfig.yaml
Details

In response to this:

Summary

  • Enable approve, lgtm, and label plugins for openshift/bgp-cloud-connector
  • Tide merge policy requires approved and lgtm labels on main

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Added Prow configuration for openshift/bgp-cloud-connector.
  • Enabled the approve, lgtm, and label plugins without requiring self-approval.
  • Configured Tide to merge pull requests into main only when they have both approved and lgtm labels.
  • Excluded pull requests with hold, ownership, Jira, or rebase-related labels.
  • Delegated CI handling to Konflux.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants