Skip to content

Enable pipeline controller for openshift/origin release branches - #82264

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
redhat-chai-bot:pipeline-controller-origin-release-branches
Jul 22, 2026
Merged

Enable pipeline controller for openshift/origin release branches#82264
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
redhat-chai-bot:pipeline-controller-origin-release-branches

Conversation

@redhat-chai-bot

@redhat-chai-bot redhat-chai-bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

The pipeline controller is currently only configured for the main branch of openshift/origin, but release branches also have jobs configured with always_run: false and optional: false (second-stage pipeline jobs). Without the pipeline controller on these branches, the second-stage jobs are never automatically triggered and Tide allows PRs to merge without them running.

Analysis

Scanned all ci-operator/config/openshift/origin/openshift-origin-*.yaml configs (excluding variant configs like __okd-scos and __agentic) and identified branches with tests that have always_run: false without optional: true:

Branch Second-stage jobs Action
main Yes Already configured
release-4.21 15 jobs Added
release-4.22 15 jobs Added
release-4.23 15 jobs Added
release-5.0 15 jobs Added
release-5.1 15 jobs Added
release-3.11, release-4.6release-4.20 None (all are optional: true) Excluded

Example second-stage jobs on these branches: e2e-gcp-ovn, e2e-gcp-ovn-upgrade, e2e-gcp-csi, e2e-aws-csi, e2e-aws-ovn-serial, e2e-vsphere-ovn, e2e-vsphere-ovn-upi, e2e-aws-ovn-fips, e2e-metal-ipi-ovn-ipv6, plus several pipeline_run_if_changed jobs.

Change

Adds release-4.21 through release-5.1 to the pipeline controller config.yaml for openshift/origin, keeping the existing trigger: auto mode.

/cc @openshift/test-platform


@smg247 requested in Slack thread

Summary by CodeRabbit

  • Configures the pipeline controller for openshift/origin release branches release-4.21 through release-5.1.
  • Ensures non-optional second-stage jobs trigger automatically, preventing Tide from merging pull requests before those jobs run.
  • Preserves the existing main branch configuration and automatic trigger behavior.

The pipeline controller is currently only configured for the main branch
of openshift/origin, but release branches also have jobs configured with
always_run: false and optional: false (second-stage pipeline jobs). Without
the pipeline controller, these jobs are never automatically triggered and
Tide allows PRs to merge without them running.

Add all active release branches that have second-stage pipeline jobs to the
pipeline controller configuration.
@openshift-ci
openshift-ci Bot requested a review from a team July 22, 2026 02:01
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 22, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@redhat-chai-bot: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: be9857bd-f1ce-4764-b235-21ae8071525f

📥 Commits

Reviewing files that changed from the base of the PR and between 307236e and 466cadc.

📒 Files selected for processing (1)
  • core-services/pipeline-controller/config.yaml

Walkthrough

The pipeline controller configuration adds five OpenShift release-* branches, from release-4.21 through release-5.1, to the tracked origin branches.

Changes

Pipeline branch tracking

Layer / File(s) Summary
Expand tracked release branches
core-services/pipeline-controller/config.yaml
The openshift origin branch list now includes release-4.21 through release-5.1 in addition to main.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: fjglira

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: enabling pipeline controller coverage for openshift/origin release branches.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The patch only updates a YAML branch list in pipeline-controller config; no Ginkgo test titles or test files were added or edited.
Test Structure And Quality ✅ Passed PR only changes core-services/pipeline-controller/config.yaml; no Ginkgo test code was added or modified.
Microshift Test Compatibility ✅ Passed Only core-services/pipeline-controller/config.yaml changed; no Ginkgo tests or MicroShift-relevant code were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only core-services/pipeline-controller/config.yaml changed; no Ginkgo tests were added or modified, so the SNO check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only pipeline-controller branch config changed; no manifests, operator code, or scheduling logic were modified.
Ote Binary Stdout Contract ✅ Passed Only core-services/pipeline-controller/config.yaml changed; no process-level code or stdout writes were added, so the OTE stdout contract is unaffected.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only core-services/pipeline-controller/config.yaml changed; no tests were added, so IPv4/disconnected compatibility isn’t applicable.
No-Weak-Crypto ✅ Passed The only touched config is a branch list for openshift/origin; it contains no crypto code, weak ciphers, or secret comparisons.
Container-Privileges ✅ Passed The only change is adding origin release branches; no privileged, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation fields are present.
No-Sensitive-Data-In-Logs ✅ Passed The change only adds release branch names in a YAML config; no logging statements or sensitive fields are introduced.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@smg247

smg247 commented Jul 22, 2026

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2026
@openshift-ci

openshift-ci Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: redhat-chai-bot, smg247

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2026
@openshift-ci

openshift-ci Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 50af9dd into openshift:main Jul 22, 2026
7 checks passed
fracappa pushed a commit to fracappa/release that referenced this pull request Jul 22, 2026
…nshift#82264)

The pipeline controller is currently only configured for the main branch
of openshift/origin, but release branches also have jobs configured with
always_run: false and optional: false (second-stage pipeline jobs). Without
the pipeline controller, these jobs are never automatically triggered and
Tide allows PRs to merge without them running.

Add all active release branches that have second-stage pipeline jobs to the
pipeline controller configuration.

Co-authored-by: redhat-chai-bot <chai-bot@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants