Skip to content

fix: migrate autobump jobs to GitHub App auth - #80034

Open
Prucek wants to merge 1 commit into
openshift:mainfrom
Prucek:fix/autobump-github-app-auth
Open

fix: migrate autobump jobs to GitHub App auth#80034
Prucek wants to merge 1 commit into
openshift:mainfrom
Prucek:fix/autobump-github-app-auth

Conversation

@Prucek

@Prucek Prucek commented Jun 3, 2026

Copy link
Copy Markdown
Member

Summary

  • Switch release-bumper and ci-tools-bumper periodic jobs from openshift-bot OAuth token to openshift-prow-github-app GitHub App credentials
  • Pass --github-app-id and --github-app-private-key-path args to generic-autobumper and update volume/secret references accordingly
  • Update bumper configs to use openshift-ci[bot] identity and remove deprecated gitHubToken/gitHubLogin fields

🤖 Generated with Claude Code

Summary by CodeRabbit

This PR migrates the OpenShift CI infrastructure's automated dependency bumper jobs from OAuth token authentication to GitHub App authentication.

Infrastructure Changes:

  • Release Bumper Job (_release-bumper.yaml): Updates the automated release repository bumper to use the openshift-ci[bot] GitHub App identity instead of the legacy openshift-bot OAuth credentials. This service periodically updates upstream Prow, Boskos, and TestInfra image references in the OpenShift release repository.

  • CI Tools Bumper Job (_ci-tools-bumper.yaml): Similarly migrates the CI tools repository bumper to the new GitHub App identity for automated updates to cluster initialization manifests and integration test configurations.

Key Updates:

  • Replaces hardcoded openshift-bot credentials with the openshift-ci[bot] GitHub App account
  • Sets explicit gitHubOrg: "openshift" configuration in both bumper definitions
  • Removes deprecated OAuth token field references (gitHubToken, gitHubLogin)
  • Maintains all existing bumper configurations (repo targets, image prefixes, PR assignments to openshift/test-platform)

This change modernizes the authentication mechanism for these critical infrastructure jobs, aligning them with GitHub App-based authentication standards while preserving their operational behavior.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 3d3033c2-5f5d-4d28-ac78-f0e8457e9886

📥 Commits

Reviewing files that changed from the base of the PR and between 5994c08 and 8b28635.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/infra-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (2)
  • core-services/prow/02_config/_ci-tools-bumper.yaml
  • core-services/prow/02_config/_release-bumper.yaml

Walkthrough

Two Prow bumper configuration files update their bot identity and credentials. CI tools bumper and release bumper YAML configurations replace the openshift-bot identity and /etc/github/oauth token references with openshift-ci[bot] name/email and openshift GitHub organization.

Changes

Bot identity migration in bumper configs

Layer / File(s) Summary
Bot identity migration in bumper configs
core-services/prow/02_config/_ci-tools-bumper.yaml, core-services/prow/02_config/_release-bumper.yaml
Both bumper configurations update Git identity from openshift-bot to openshift-ci[bot], add gitHubOrg: openshift, and remove deprecated gitHubToken and gitHubLogin credential fields.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • openshift/release#79805: Both PRs modify the same Prow bumper YAML identity/auth fields in core-services/prow/02_config/_ci-tools-bumper.yaml and _release-bumper.yaml (switching bot identity and GitHub auth/token configuration).

Suggested labels

lgtm, rehearsals-ack

Suggested reviewers

  • danilo-gemoli
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: migrating autobump jobs from OAuth token authentication to GitHub App authentication, which is the core objective of this pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only CI configuration YAML files, not Ginkgo test code. No test names to evaluate against stability requirements.
Test Structure And Quality ✅ Passed Check not applicable: PR contains only YAML configuration changes for Prow CI tools bumper jobs, with no Ginkgo test code added or modified.
Microshift Test Compatibility ✅ Passed PR modifies only Prow CI configuration files (_ci-tools-bumper.yaml and _release-bumper.yaml), not Ginkgo e2e tests. MicroShift compatibility check applies only to new test code.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only modifies Prow CI configuration files (YAML), not adding any Ginkgo e2e tests. The check is for new e2e tests only, making it not applicable here.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies Prow CI config files updating authentication credentials. No deployment manifests, operator code, controllers, or scheduling constraints—check not applicable.
Ote Binary Stdout Contract ✅ Passed PR changes only YAML configuration files for Prow autobumper tools, not process-level Go code; OTE stdout contract check is not applicable to configuration-only changes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR modifies only YAML configuration files for CI job credentials, not Ginkgo e2e tests. The IPv6 compatibility check applies only to new test code, which is absent here.
No-Weak-Crypto ✅ Passed No weak crypto in this PR. Migrated from OAuth tokens to GitHub App auth with secure PEM private keys mounted as read-only secrets. No MD5, SHA1, DES, RC4, 3DES, Blowfish, or ECB usage.
Container-Privileges ✅ Passed PR modifies data configuration files only. Container job specs lack privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation: true, or root user settings.
No-Sensitive-Data-In-Logs ✅ Passed PR removes insecure OAuth token references and switches to GitHub App auth. Configuration files contain no exposed passwords, tokens, or API keys—only secure Kubernetes secret references.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci

openshift-ci Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Prucek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2026
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 3, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@Prucek: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@Prucek

Prucek commented Jun 3, 2026

Copy link
Copy Markdown
Member Author

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2026
@openshift-ci

openshift-ci Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

@Prucek: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant