OTA-1921 Add 5.0 Y/Z stream Jobs - #79460
Merged
openshift-merge-bot[bot] merged 2 commits intoAug 11, 2026
Merged
Conversation
Contributor
WalkthroughAdds nine private openshift-tests-private release-5.0 CI operator YAMLs that declare base_images, prowgen privacy, release targets/version bounds, default resources, and extensive scheduled upgrade rehearsal test matrices across amd64, arm64, and multi-arch variants. ChangesRelease-5.0 Upgrade Test Configurations
🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
|
@dis016, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 13
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-nightly-5.0-upgrade-from-stable-4.22.yaml`:
- Around line 83-95: This job contains non-compliant Y-stream names and a
forbidden winc profile: replace any job names using f14/f7/f999 (e.g.,
aws-ipi-disconnected-pin-mco-f14) with the standard f28 suffix and ensure the
chain job (chain: openshift-upgrade-qe-sanity-disconnected) and workflow
(cucushift-installer-rehearse-aws-ipi-disconnected-private) reference only
f28-compliant jobs; also remove or change any winc-profile chain jobs to a
supported profile (no "winc" chains) so the job names and profiles conform to
the Y-stream policy.
- Around line 619-620: Replace the placeholder cron value "cron: to be
implemented" in the job YAML with a valid cron schedule string (e.g., "0 2 * *
*" or another release-appropriate expression) so the periodic job can be
parsed/scheduled; update every occurrence of the cron key in this file
(including the other similar entry) and ensure the chosen schedule follows the
project's release-specific periodic test guidelines.
In
`@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-nightly-5.0-upgrade-from-stable-5.0.yaml`:
- Around line 660-663: The cron placeholder "cron: to be implemented" for the
periodic job entry (as: metal-ds-ipi-ovn-ipv6-fips-f999) is invalid; locate the
job block containing the cron field and either remove the cron key or replace
the placeholder with a valid cron schedule string (e.g., a standard crontab
expression) so the job becomes schedulable; repeat the same change for the
second occurrence referenced (the similar block around the other reported lines)
to ensure no "to be implemented" placeholders remain.
- Around line 425-426: This Z-stream config uses old f28/f14 job suffixes; find
job names like "azure-aks-hypershift-byo-vnet-replace-guest-f28" (and other
occurrences noted) and replace their "-f28" or "-f14" suffix with "-f60" so all
upgrade-from-stable-5.0 jobs consistently use f60; scan the file for any
remaining "-f28" or "-f14" tokens (including the other mentioned locations) and
update them to "-f60".
In
`@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-stable-5.0-upgrade-from-stable-4.22.yaml`:
- Around line 64-243: Multiple test entries under tests implement
stable-to-stable chain upgrades (entries using test chain
"openshift-upgrade-qe-sanity" or "openshift-upgrade-qe-sanity-disconnected");
policy requires only one profile for that upgrade path. Keep a single canonical
test profile (pick the appropriate one, e.g., the entry with cluster_profile:
aws-qe or whichever is desired) and remove the other duplicate stable-to-stable
entries (those with as: aws-ipi-shared-vpc-phz-sts-fips-f28,
aws-ipi-disc-priv-sts-ep-fips-f28, vsphere-ipi-ovn-dualstack-f28,
vsphere-ipi-proxy-fips-f28, etc.) so only one tests->steps->test chain
"openshift-upgrade-qe-sanity" (or the disconnected variant if intended) remains;
ensure the retained entry preserves required env and workflow fields and delete
the extra profiles to comply with the single-profile guideline.
In
`@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__arm64-nightly-5.0-upgrade-from-stable-4.22.yaml`:
- Around line 200-204: The job currently named "metal-ds-ipi-ovn-ipv4-f999" uses
an invalid placeholder schedule and has "cron: to be implemented"; rename the
job to use the required Y-stream pattern by replacing "f999" with "f28" (i.e.,
update the `as:` value) and replace the `cron: to be implemented` line with a
valid periodic cron entry for the upgrade job (a fully defined cron schedule
string) so the periodic upgrade job is runnable; ensure the updated cron follows
the project's periodic format and remains inside the same job block that
contains `capabilities:` and `steps:`.
In
`@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__arm64-nightly-5.0-upgrade-from-stable-5.0.yaml`:
- Around line 152-156: The periodic job placeholder "metal-ds-ipi-ovn-ipv4-f999"
contains an invalid cron field ("cron: to be implemented") and uses the
disallowed "f999" suffix; either remove this job or finalize it by renaming to
the approved Z-stream suffix "metal-ds-ipi-ovn-ipv4-f60" and replacing "cron: to
be implemented" with a valid cron schedule (e.g., a proper cron expression) so
the periodic CI job is valid and follows the guideline to always use f60 for Z
stream upgrade jobs.
In
`@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__arm64-stable-5.0-upgrade-from-stable-4.22.yaml`:
- Around line 74-109: This file currently defines two stable-to-stable chain
profiles (as: aws-ipi-disc-priv-sts-ep-f28 and as:
azure-ipi-disc-fullyprivate-f28); keep only one profile for the stable-to-stable
upgrade chain by removing the other block entirely (including its cron, steps,
env, test, and workflow entries) so only a single "as:" entry remains for the
stable-to-stable chain; ensure the retained profile's workflow (e.g.,
cucushift-installer-rehearse-aws-ipi-disconnected-private-... or
cucushift-installer-rehearse-azure-ipi-disconnected-fullyprivate) and test chain
(openshift-upgrade-qe-sanity-disconnected) stay intact and the file remains
valid YAML.
In
`@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__multi-nightly-5.0-upgrade-from-stable-4.22.yaml`:
- Around line 187-188: This Y-stream upgrade job uses inconsistent footers
(e.g., the as value "aws-ipi-priv-sts-basecap-none-mini-perm-arm-f14" and other
occurrences using f7/f999); update those job identifiers to use f28 consistently
for the Y-stream upgrade variant by replacing any "-f14", "-f7", or "-f999"
suffixes in the "as" job names (and any similar job name patterns in the same
config) with "-f28" so all upgrade-from-stable-4.22 jobs use the required f28
suffix.
- Around line 662-663: Find the periodic job entries that currently contain the
placeholder line "cron: to be implemented" (the periodic job definitions under
the job's spec where "cron" sits) and replace each placeholder with a valid cron
schedule expression (e.g., "0 2 * * *" or another agreed schedule) so the job is
fully schedulable; ensure you update both occurrences mentioned, keep the
surrounding "steps:" block unchanged, and validate the resulting YAML against
the ci-operator periodic job schema to confirm the "cron" field is accepted.
In
`@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__multi-nightly-5.0-upgrade-from-stable-5.0.yaml`:
- Around line 244-245: Update the lingering Z-stream job names that end with
"-f28" to "-f60" so they conform to the Z-stream policy; specifically replace
occurrences like "aws-ipi-priv-sts-basecap-none-mini-perm-arm-f28" (and the
other similar job names referenced in this PR) with their "-f60" equivalents in
the YAML entries (the job name strings and any identical cron/job keys) so the
upgrade-from-stable-5.0 config consistently uses f60 for Z-stream upgrade jobs.
In
`@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__multi-stable-5.0-upgrade-from-stable-4.22.yaml`:
- Around line 60-175: The tests list for the stable-5.0 -> stable-4.22 chain
contains multiple scheduled profiles (entries with as:
aws-ipi-ovn-ipsec-arm-mixarch-f28, aws-ipi-proxy-sts-arm-f28,
azure-ipi-fullyprivate-proxy-arm-f28, etc.) but chain upgrades must include only
ONE profile; keep a single canonical test/profile that uses the chain (the
entry(s) containing "chain: openshift-upgrade-qe-sanity") and remove the other
scheduled profiles from this chain YAML (move them into their respective
non-chain or z-stream job configs), ensuring the retained test keeps its
cluster_profile, env and workflow references unchanged (e.g., leave the chosen
"as: ..." entry with its "chain: openshift-upgrade-qe-sanity" intact and
remove/migrate the rest).
- Around line 94-95: The workflow block currently lists multiple profiles for
the stable-to-stable upgrade path; change it so only one profile remains under
the workflow key — pick a single representative profile (for example keep
"cucushift-installer-rehearse-aws-ipi-proxy-cco-manual-security-token-service"
or another chosen profile) and remove the other seven entries so the workflow
value contains exactly one profile string; ensure the remaining profile name
replaces the current multi-profile list and that no other profile entries for
the 4.22→5.0 stable-to-stable path remain in this YAML.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: c7fcf266-4e63-406e-b62f-365be33a803d
📒 Files selected for processing (9)
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-nightly-5.0-upgrade-from-stable-4.22.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-nightly-5.0-upgrade-from-stable-5.0.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-stable-5.0-upgrade-from-stable-4.22.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__arm64-nightly-5.0-upgrade-from-stable-4.22.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__arm64-nightly-5.0-upgrade-from-stable-5.0.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__arm64-stable-5.0-upgrade-from-stable-4.22.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__multi-nightly-5.0-upgrade-from-stable-4.22.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__multi-nightly-5.0-upgrade-from-stable-5.0.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__multi-stable-5.0-upgrade-from-stable-4.22.yaml
Comment on lines
+83
to
+95
| - as: aws-ipi-disconnected-pin-mco-f14 | ||
| cron: 45 1 2,16 * * | ||
| steps: | ||
| cluster_profile: aws-qe | ||
| env: | ||
| BASE_DOMAIN: qe.devcluster.openshift.com | ||
| EXTRACT_MANIFEST_INCLUDED: "true" | ||
| MCO_CONF_DAY2_PINTARGETRELEASE: "true" | ||
| MCO_CONF_DAY2_PINTARGETRELEASE_REMOVE_PULLSECRET: "true" | ||
| test: | ||
| - chain: openshift-upgrade-qe-sanity-disconnected | ||
| workflow: cucushift-installer-rehearse-aws-ipi-disconnected-private | ||
| - as: aws-c2s-ipi-disc-priv-fips-f28 |
Contributor
There was a problem hiding this comment.
Y-stream naming/policy mismatches (f14/f7/f999 and winc profile).
This Y-stream upgrade file includes non-f28 jobs (f14, f7, f999) and a winc profile chain job, which violates upgrade policy for this path.
As per coding guidelines, "Always use f28 for Y stream upgrade jobs in OpenShift CI configurations" and "Do not use ... winc profiles for Chain upgrade jobs."
Also applies to: 204-205, 616-617, 645-646, 1097-1109
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-nightly-5.0-upgrade-from-stable-4.22.yaml`
around lines 83 - 95, This job contains non-compliant Y-stream names and a
forbidden winc profile: replace any job names using f14/f7/f999 (e.g.,
aws-ipi-disconnected-pin-mco-f14) with the standard f28 suffix and ensure the
chain job (chain: openshift-upgrade-qe-sanity-disconnected) and workflow
(cucushift-installer-rehearse-aws-ipi-disconnected-private) reference only
f28-compliant jobs; also remove or change any winc-profile chain jobs to a
supported profile (no "winc" chains) so the job names and profiles conform to
the Y-stream policy.
Comment on lines
+425
to
+426
| - as: azure-aks-hypershift-byo-vnet-replace-guest-f28 | ||
| cron: 19 19 15 * * |
Contributor
There was a problem hiding this comment.
Use f60 consistently for this Z-stream file.
This upgrade-from-stable-5.0 config still contains f28/f14 jobs, which conflicts with the required z-stream convention.
As per coding guidelines, "Always use f60 for Z stream upgrade jobs in OpenShift CI configurations."
Also applies to: 812-813, 839-840, 848-849, 988-989, 1028-1029, 1044-1045, 1121-1122
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-nightly-5.0-upgrade-from-stable-5.0.yaml`
around lines 425 - 426, This Z-stream config uses old f28/f14 job suffixes; find
job names like "azure-aks-hypershift-byo-vnet-replace-guest-f28" (and other
occurrences noted) and replace their "-f28" or "-f14" suffix with "-f60" so all
upgrade-from-stable-5.0 jobs consistently use f60; scan the file for any
remaining "-f28" or "-f14" tokens (including the other mentioned locations) and
update them to "-f60".
Comment on lines
+64
to
+243
| tests: | ||
| - as: aws-c2s-ipi-disc-priv-fips-f28 | ||
| cron: 22 11 30 * * | ||
| steps: | ||
| cluster_profile: aws-c2s-qe | ||
| env: | ||
| BASE_DOMAIN: qe.devcluster.openshift.com | ||
| EXTRACT_MANIFEST_INCLUDED: "true" | ||
| FIPS_ENABLED: "true" | ||
| OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY: "" | ||
| test: | ||
| - chain: openshift-upgrade-qe-sanity-disconnected | ||
| workflow: cucushift-installer-rehearse-aws-c2s-ipi-disconnected-private | ||
| - as: aws-ipi-disc-priv-localzone-fips-f28 | ||
| cron: 41 11 4 * * | ||
| steps: | ||
| cluster_profile: aws-1-qe | ||
| env: | ||
| BASE_DOMAIN: qe.devcluster.openshift.com | ||
| EXTRACT_MANIFEST_INCLUDED: "true" | ||
| FIPS_ENABLED: "true" | ||
| OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY: "" | ||
| test: | ||
| - chain: openshift-upgrade-qe-sanity-disconnected | ||
| workflow: | ||
| cucushift-installer-rehearse-aws-ipi-disconnected-private-edge-zone | ||
| - as: aws-ipi-disc-priv-sts-ep-fips-f28 | ||
| cron: 16 12 16 * * | ||
| steps: | ||
| cluster_profile: aws-qe | ||
| env: | ||
| BASE_DOMAIN: qe.devcluster.openshift.com | ||
| ENABLE_OTA_TEST: OCP-30832 | ||
| EXTRACT_MANIFEST_INCLUDED: "true" | ||
| FIPS_ENABLED: "true" | ||
| OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY: "" | ||
| UPGRADE_CCO_MANUAL_MODE: oidc | ||
| test: | ||
| - chain: openshift-upgrade-qe-sanity-disconnected | ||
| workflow: | ||
| cucushift-installer-rehearse-aws-ipi-disconnected-private-cco-manual-security-token-service-private-s3-with-ep-sts-ec2-elb | ||
| - as: aws-ipi-shared-vpc-phz-sts-fips-f28 | ||
| cron: 35 13 5 * * | ||
| steps: | ||
| cluster_profile: aws-qe | ||
| env: | ||
| BASE_DOMAIN: qe.devcluster.openshift.com | ||
| EXTRACT_MANIFEST_INCLUDED: "true" | ||
| FIPS_ENABLED: "true" | ||
| OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY: "" | ||
| UPGRADE_CCO_MANUAL_MODE: oidc | ||
| test: | ||
| - chain: openshift-upgrade-qe-sanity | ||
| workflow: cucushift-installer-rehearse-aws-ipi-shared-vpc-phz-sts | ||
| - as: aws-usgov-ipi-private-sts-f28 | ||
| cron: 52 3 26 * * | ||
| steps: | ||
| cluster_profile: aws-usgov-qe | ||
| env: | ||
| BASE_DOMAIN: qe.devcluster.openshift.com | ||
| EXTRACT_MANIFEST_INCLUDED: "true" | ||
| OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY: "" | ||
| UPGRADE_CCO_MANUAL_MODE: oidc | ||
| test: | ||
| - chain: openshift-upgrade-qe-sanity | ||
| workflow: | ||
| cucushift-installer-rehearse-aws-usgov-ipi-private-cco-manual-security-token-service | ||
| - as: azure-ipi-disc-fullyprivate-f28 | ||
| cron: 3 19 27 * * | ||
| steps: | ||
| cluster_profile: azure-qe | ||
| env: | ||
| BASE_DOMAIN: qe.azure.devcluster.openshift.com | ||
| ENABLE_OTA_TEST: OCP-27986 | ||
| OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY: "" | ||
| test: | ||
| - chain: openshift-upgrade-qe-sanity-disconnected | ||
| workflow: cucushift-installer-rehearse-azure-ipi-disconnected-fullyprivate | ||
| - as: azure-ipi-disc-oidc-oc-mirror-f28-ota | ||
| cron: 39 22 5 * * | ||
| steps: | ||
| cluster_profile: azure-qe | ||
| env: | ||
| BASE_DOMAIN: qe.azure.devcluster.openshift.com | ||
| EXTRACT_MANIFEST_INCLUDED: "true" | ||
| MIRROR_BIN: oc-mirror | ||
| MIRROR_GRAPH_DATA: "true" | ||
| OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY: "" | ||
| USE_ORIGINAL_OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE: "true" | ||
| USE_ORIGINAL_OPENSHIFT_UPGRADE_RELEASE_IMAGE_OVERRIDE: "true" | ||
| test: | ||
| - ref: cucushift-upgrade-mirror-images-by-oc-mirror | ||
| - ref: cucushift-upgrade-prehealthcheck | ||
| - ref: cucushift-upgrade-toimage | ||
| - ref: cucushift-upgrade-healthcheck | ||
| workflow: | ||
| cucushift-installer-rehearse-azure-ipi-disconnected-cco-manual-workload-identity | ||
| - as: azure-mag-ipi-fips-f28 | ||
| cron: 0 5 27 * * | ||
| steps: | ||
| cluster_profile: azuremag-qe | ||
| env: | ||
| BASE_DOMAIN: qemag.azure.devcluster.openshift.com | ||
| FIPS_ENABLED: "true" | ||
| OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY: "" | ||
| test: | ||
| - chain: openshift-upgrade-qe-sanity | ||
| workflow: cucushift-installer-rehearse-azure-mag-ipi | ||
| - as: azure-stack-ipi-proxy-fips-f28 | ||
| cluster: build01 | ||
| cron: 12 17 29 * * | ||
| steps: | ||
| cluster_profile: azurestack-qe | ||
| env: | ||
| EXTRACT_MANIFEST_INCLUDED: "true" | ||
| FIPS_ENABLED: "true" | ||
| OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY: "" | ||
| test: | ||
| - chain: openshift-upgrade-qe-sanity | ||
| workflow: cucushift-installer-rehearse-azure-stack-ipi-proxy | ||
| - as: ibmcloud-ipi-proxy-private-fips-rt-f28 | ||
| cron: 28 20 18 * * | ||
| steps: | ||
| cluster_profile: ibmcloud-qe | ||
| env: | ||
| ENABLE_OTA_TEST: OCP-56083 | ||
| OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY: "" | ||
| RT_ENABLED: "true" | ||
| test: | ||
| - chain: openshift-upgrade-qe-sanity | ||
| workflow: cucushift-installer-rehearse-ibmcloud-ipi-proxy-private | ||
| - as: nutanix-ipi-proxy-fips-mini-perm-f28 | ||
| cluster: build01 | ||
| cron: 4 4 15 * * | ||
| steps: | ||
| cluster_profile: nutanix-qe-dis | ||
| env: | ||
| ENABLE_OTA_TEST: OCP-24358 | ||
| EXTRACT_MANIFEST_INCLUDED: "true" | ||
| FIPS_ENABLED: "true" | ||
| OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY: "" | ||
| test: | ||
| - chain: openshift-upgrade-qe-sanity | ||
| workflow: cucushift-installer-rehearse-nutanix-ipi-proxy-minimal-permission | ||
| - as: vsphere-ipi-disc-f28 | ||
| cron: 11 16 11 * * | ||
| steps: | ||
| cluster_profile: vsphere-dis-2 | ||
| env: | ||
| ENABLE_OTA_TEST: OCP-30832 | ||
| OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY: "" | ||
| leases: | ||
| - env: VSPHERE_BASTION_LEASED_RESOURCE | ||
| resource_type: vsphere-connected-2-quota-slice | ||
| test: | ||
| - chain: openshift-upgrade-qe-sanity-disconnected | ||
| workflow: cucushift-installer-rehearse-vsphere-ipi-disconnected | ||
| - as: vsphere-ipi-ovn-dualstack-f28 | ||
| cron: 24 23 23 * * | ||
| steps: | ||
| cluster_profile: vsphere-elastic | ||
| env: | ||
| OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY: "" | ||
| test: | ||
| - chain: openshift-upgrade-qe-sanity | ||
| workflow: cucushift-installer-rehearse-vsphere-ipi-ovn-dualstack | ||
| - as: vsphere-ipi-proxy-fips-f28 | ||
| cron: 56 13 21 * * | ||
| steps: | ||
| cluster_profile: vsphere-dis-2 | ||
| env: | ||
| ENABLE_OTA_TEST: OCP-24358 | ||
| FIPS_ENABLED: "true" | ||
| OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY: "" | ||
| leases: | ||
| - env: VSPHERE_BASTION_LEASED_RESOURCE | ||
| resource_type: vsphere-connected-2-quota-slice | ||
| test: | ||
| - chain: openshift-upgrade-qe-sanity | ||
| workflow: cucushift-installer-rehearse-vsphere-ipi-proxy |
Contributor
There was a problem hiding this comment.
Stable-to-stable path should keep a single profile.
This file defines many test profiles for a stable-to-stable chain path; policy requires only one.
As per coding guidelines, "Choose only ONE profile for stable-to-stable upgrade paths in chain upgrades."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-stable-5.0-upgrade-from-stable-4.22.yaml`
around lines 64 - 243, Multiple test entries under tests implement
stable-to-stable chain upgrades (entries using test chain
"openshift-upgrade-qe-sanity" or "openshift-upgrade-qe-sanity-disconnected");
policy requires only one profile for that upgrade path. Keep a single canonical
test profile (pick the appropriate one, e.g., the entry with cluster_profile:
aws-qe or whichever is desired) and remove the other duplicate stable-to-stable
entries (those with as: aws-ipi-shared-vpc-phz-sts-fips-f28,
aws-ipi-disc-priv-sts-ep-fips-f28, vsphere-ipi-ovn-dualstack-f28,
vsphere-ipi-proxy-fips-f28, etc.) so only one tests->steps->test chain
"openshift-upgrade-qe-sanity" (or the disconnected variant if intended) remains;
ensure the retained entry preserves required env and workflow fields and delete
the extra profiles to comply with the single-profile guideline.
Comment on lines
+187
to
+188
| - as: aws-ipi-priv-sts-basecap-none-mini-perm-arm-f14 | ||
| cron: 26 23 3,17 * * |
Contributor
There was a problem hiding this comment.
Use f28 consistently in this Y-stream config.
The file mixes f14/f7/f999 in a upgrade-from-stable-4.22 variant where f28 is required.
As per coding guidelines, "Always use f28 for Y stream upgrade jobs in OpenShift CI configurations."
Also applies to: 630-631, 659-660, 714-715
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__multi-nightly-5.0-upgrade-from-stable-4.22.yaml`
around lines 187 - 188, This Y-stream upgrade job uses inconsistent footers
(e.g., the as value "aws-ipi-priv-sts-basecap-none-mini-perm-arm-f14" and other
occurrences using f7/f999); update those job identifiers to use f28 consistently
for the Y-stream upgrade variant by replacing any "-f14", "-f7", or "-f999"
suffixes in the "as" job names (and any similar job name patterns in the same
config) with "-f28" so all upgrade-from-stable-4.22 jobs use the required f28
suffix.
Comment on lines
+244
to
+245
| - as: aws-ipi-priv-sts-basecap-none-mini-perm-arm-f28 | ||
| cron: 20 14 2 * * |
Contributor
There was a problem hiding this comment.
Normalize lingering f28 jobs to f60 in this Z-stream variant.
This file is upgrade-from-stable-5.0 but still carries multiple f28 entries, conflicting with z-stream policy.
As per coding guidelines, "Always use f60 for Z stream upgrade jobs in OpenShift CI configurations."
Also applies to: 264-265, 533-534, 686-687, 714-715, 842-843
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__multi-nightly-5.0-upgrade-from-stable-5.0.yaml`
around lines 244 - 245, Update the lingering Z-stream job names that end with
"-f28" to "-f60" so they conform to the Z-stream policy; specifically replace
occurrences like "aws-ipi-priv-sts-basecap-none-mini-perm-arm-f28" (and the
other similar job names referenced in this PR) with their "-f60" equivalents in
the YAML entries (the job name strings and any identical cron/job keys) so the
upgrade-from-stable-5.0 config consistently uses f60 for Z-stream upgrade jobs.
Comment on lines
+60
to
+175
| tests: | ||
| - as: aws-ipi-ovn-ipsec-arm-mixarch-f28 | ||
| cron: 11 18 3 * * | ||
| steps: | ||
| cluster_profile: aws-qe | ||
| env: | ||
| ADDITIONAL_WORKER_ARCHITECTURE: x86_64 | ||
| ADDITIONAL_WORKER_VM_TYPE: m6i.xlarge | ||
| ADDITIONAL_WORKERS: "1" | ||
| BASE_DOMAIN: qe.devcluster.openshift.com | ||
| COMPUTE_NODE_REPLICAS: "2" | ||
| COMPUTE_NODE_TYPE: m6g.xlarge | ||
| CONTROL_PLANE_INSTANCE_TYPE: m6g.xlarge | ||
| OCP_ARCH: arm64 | ||
| OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY: "" | ||
| test: | ||
| - ref: ipi-install-heterogeneous | ||
| - chain: openshift-upgrade-qe-sanity | ||
| workflow: cucushift-installer-rehearse-aws-ipi-ovn-ipsec | ||
| - as: aws-ipi-proxy-sts-arm-f28 | ||
| cron: 49 22 23 * * | ||
| steps: | ||
| cluster_profile: aws-qe | ||
| env: | ||
| BASE_DOMAIN: qe.devcluster.openshift.com | ||
| COMPUTE_NODE_TYPE: m6g.xlarge | ||
| CONTROL_PLANE_INSTANCE_TYPE: m6g.xlarge | ||
| ENABLE_OTA_TEST: OCP-24358 | ||
| EXTRACT_MANIFEST_INCLUDED: "true" | ||
| OCP_ARCH: arm64 | ||
| OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY: "" | ||
| UPGRADE_CCO_MANUAL_MODE: oidc | ||
| test: | ||
| - chain: openshift-upgrade-qe-sanity | ||
| workflow: | ||
| cucushift-installer-rehearse-aws-ipi-proxy-cco-manual-security-token-service | ||
| - as: aws-ipi-usertags-custom-sg-fips-amd-f28 | ||
| cron: 14 17 8 * * | ||
| steps: | ||
| cluster_profile: aws-qe | ||
| env: | ||
| BASE_DOMAIN: qe.devcluster.openshift.com | ||
| FIPS_ENABLED: "true" | ||
| OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY: "" | ||
| test: | ||
| - chain: openshift-upgrade-qe-sanity | ||
| workflow: | ||
| cucushift-installer-rehearse-aws-ipi-usertags-custom-security-groups | ||
| - as: azure-ipi-fullyprivate-proxy-arm-f28 | ||
| cron: 26 17 27 * * | ||
| steps: | ||
| cluster_profile: azure-qe | ||
| env: | ||
| BASE_DOMAIN: qe.azure.devcluster.openshift.com | ||
| COMPUTE_NODE_TYPE: Standard_D4ps_v5 | ||
| ENABLE_OTA_TEST: OCP-24358 | ||
| OCP_ARCH: arm64 | ||
| OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY: "" | ||
| test: | ||
| - chain: openshift-upgrade-qe-sanity | ||
| workflow: cucushift-installer-rehearse-azure-ipi-fullyprivate-proxy | ||
| - as: azure-ipi-usertags-sa-encryption-arm-f28 | ||
| cron: 21 8 23 * * | ||
| steps: | ||
| cluster_profile: azure-qe | ||
| env: | ||
| BASE_DOMAIN: qe.azure.devcluster.openshift.com | ||
| COMPUTE_NODE_TYPE: Standard_D4ps_v5 | ||
| OCP_ARCH: arm64 | ||
| OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY: "" | ||
| test: | ||
| - chain: openshift-upgrade-qe-sanity | ||
| workflow: | ||
| cucushift-installer-rehearse-azure-ipi-usertags-storage-account-encryption | ||
| - as: gcp-ipi-compact-filestore-csi-mini-perm-arm-f28 | ||
| cron: 13 14 30 * * | ||
| steps: | ||
| cluster_profile: gcp-qe | ||
| dependency_overrides: | ||
| OO_INDEX: quay.io/openshift-qe-optional-operators/aosqe-index:v4.20 | ||
| env: | ||
| COMPUTE_NODE_TYPE: t2a-standard-4 | ||
| GCP_INSTALL_USE_MINIMAL_PERMISSIONS: "yes" | ||
| OCP_ARCH: arm64 | ||
| OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY: "" | ||
| SIZE_VARIANT: compact | ||
| test: | ||
| - chain: openshift-upgrade-qe-sanity | ||
| workflow: cucushift-installer-rehearse-gcp-ipi-filestore-csi | ||
| - as: gcp-ipi-proxy-private-mini-perm-amd-mixarch-f28 | ||
| cron: 16 21 23 * * | ||
| steps: | ||
| cluster_profile: gcp-qe | ||
| env: | ||
| ADDITIONAL_WORKER_VM_TYPE: t2a-standard-4 | ||
| ADDITIONAL_WORKERS: "1" | ||
| COMPUTE_NODE_REPLICAS: "2" | ||
| ENABLE_OTA_TEST: OCP-24358 | ||
| GCP_INSTALL_USE_MINIMAL_PERMISSIONS: "yes" | ||
| OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY: "" | ||
| test: | ||
| - ref: ipi-install-heterogeneous | ||
| - chain: openshift-upgrade-qe-sanity | ||
| workflow: cucushift-installer-rehearse-gcp-ipi-proxy-private | ||
| - as: gcp-ipi-xpn-mini-perm-amd-fips-f28 | ||
| cron: 37 2 25 * * | ||
| steps: | ||
| cluster_profile: gcp-qe | ||
| env: | ||
| COMPUTE_SERVICE_ACCOUNT: installer-dev-worker-sa | ||
| CONTROL_PLANE_SERVICE_ACCOUNT: installer-dev-control-plane-sa | ||
| FIPS_ENABLED: "true" | ||
| OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY: "" | ||
| test: | ||
| - chain: openshift-upgrade-qe-sanity | ||
| workflow: cucushift-installer-rehearse-gcp-ipi-xpn-minimal-permission |
Contributor
There was a problem hiding this comment.
Stable-to-stable chain path should not include multiple profiles in one config.
This variant (stable-5.0 from stable-4.22) defines many scheduled profiles. For stable-to-stable chain upgrades, keep only one profile in this path and move the rest to appropriate non-chain/z-stream coverage.
As per coding guidelines, "Choose only ONE profile for stable-to-stable upgrade paths in chain upgrades".
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__multi-stable-5.0-upgrade-from-stable-4.22.yaml`
around lines 60 - 175, The tests list for the stable-5.0 -> stable-4.22 chain
contains multiple scheduled profiles (entries with as:
aws-ipi-ovn-ipsec-arm-mixarch-f28, aws-ipi-proxy-sts-arm-f28,
azure-ipi-fullyprivate-proxy-arm-f28, etc.) but chain upgrades must include only
ONE profile; keep a single canonical test/profile that uses the chain (the
entry(s) containing "chain: openshift-upgrade-qe-sanity") and remove the other
scheduled profiles from this chain YAML (move them into their respective
non-chain or z-stream job configs), ensuring the retained test keeps its
cluster_profile, env and workflow references unchanged (e.g., leave the chosen
"as: ..." entry with its "chain: openshift-upgrade-qe-sanity" intact and
remove/migrate the rest).
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
♻️ Duplicate comments (2)
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__arm64-stable-5.0-upgrade-from-stable-4.22.yaml (1)
74-108:⚠️ Potential issue | 🟠 Major | ⚡ Quick winKeep only one stable-to-stable chain profile in this config.
This file still defines two stable-to-stable profiles (
aws-...andazure-...); policy requires a single one.As per coding guidelines, "Choose only ONE profile for stable-to-stable upgrade paths in chain upgrades".
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__arm64-stable-5.0-upgrade-from-stable-4.22.yaml` around lines 74 - 108, This config defines two stable-to-stable chain profiles; keep only one: remove the entire block for the profile you do NOT want (either the as: aws-ipi-disc-priv-sts-ep-f28 block with its cron/steps/env/test/workflow or the as: azure-ipi-disc-fullyprivate-f28 block with its cron/steps/env/test/workflow), leaving a single profile that contains the cluster_profile, dependencies, env, test (chain: openshift-upgrade-qe-sanity-disconnected) and workflow (cucushift-installer-rehearse-...) entries; ensure the remaining profile retains its original keys (cron, steps, dependencies, env, test, workflow) and no duplicate stable-to-stable chain is left.ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__arm64-nightly-5.0-upgrade-from-stable-5.0.yaml (1)
149-153:⚠️ Potential issue | 🟠 Major | ⚡ Quick winReplace the
f999placeholder withf60for this z-stream job.Line 149 still uses
metal-ds-ipi-ovn-ipv4-f999, which violates the z-stream suffix rule.Proposed patch
-- as: metal-ds-ipi-ovn-ipv4-f999 +- as: metal-ds-ipi-ovn-ipv4-f60As per coding guidelines, "Always use
f60for Z stream upgrade jobs in OpenShift CI configurations".🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__arm64-nightly-5.0-upgrade-from-stable-5.0.yaml` around lines 149 - 153, Update the z-stream job suffix: locate the job name string "metal-ds-ipi-ovn-ipv4-f999" in the job definition and replace the trailing "f999" with "f60" so it becomes "metal-ds-ipi-ovn-ipv4-f60"; ensure no other occurrences remain and keep the rest of the job block (capabilities, cron, steps) unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__arm64-nightly-5.0-upgrade-from-stable-5.0.yaml`:
- Around line 132-179: The jobs under the top-level list must be sorted
alphabetically by their "as" name; reorder the three job entries so
"gcp-ipi-disc-priv-oidc-mini-perm-f60" and "metal-ds-ipi-ovn-ipv4-f999" and
"metal-upi-ovn-ipv4-f60" appear in strict ascending alphabetical order (place
the "metal-ds-ipi-ovn-ipv4-f999" block before "metal-upi-ovn-ipv4-f60" and
ensure "gcp-..." is positioned appropriately), preserving each job's internal
fields (capabilities, cron, steps, dependencies, env, test, workflow) intact and
without modifying keys or values.
- Around line 96-97: The job is using a disconnected chain/profile (chain:
openshift-upgrade-qe-test-disconnected and workflow:
cucushift-installer-rehearse-...-disconnected-...) which violates the "don't use
disconnected profiles for chain upgrade jobs" rule; update the job(s) at the
shown locations (and the other occurrences flagged at 113-114, 130-131, 178-179)
to use the non-disconnected chain variant (e.g., change chain to the matching
non-disconnected name such as openshift-upgrade-qe-test) and remove the
"-disconnected" profile from the workflow name (or replace with the equivalent
non-disconnected workflow name) so the chain-upgrade jobs no longer reference
disconnected profiles.
In
`@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__arm64-stable-5.0-upgrade-from-stable-4.22.yaml`:
- Around line 91-92: The chain field is set to a disconnected variant (chain:
openshift-upgrade-qe-sanity-disconnected) while the workflow is a chain-upgrade
job; change the chain to a non-disconnected profile (for example use
openshift-upgrade-qe-sanity or the standard chain-upgrade chain) so the job no
longer uses a disconnected profile, and apply the same change to the other
occurrence referenced (the similar block at the second occurrence around the
file). Ensure the chain value matches the non-disconnected naming convention
used by other chain-upgrade jobs.
---
Duplicate comments:
In
`@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__arm64-nightly-5.0-upgrade-from-stable-5.0.yaml`:
- Around line 149-153: Update the z-stream job suffix: locate the job name
string "metal-ds-ipi-ovn-ipv4-f999" in the job definition and replace the
trailing "f999" with "f60" so it becomes "metal-ds-ipi-ovn-ipv4-f60"; ensure no
other occurrences remain and keep the rest of the job block (capabilities, cron,
steps) unchanged.
In
`@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__arm64-stable-5.0-upgrade-from-stable-4.22.yaml`:
- Around line 74-108: This config defines two stable-to-stable chain profiles;
keep only one: remove the entire block for the profile you do NOT want (either
the as: aws-ipi-disc-priv-sts-ep-f28 block with its cron/steps/env/test/workflow
or the as: azure-ipi-disc-fullyprivate-f28 block with its
cron/steps/env/test/workflow), leaving a single profile that contains the
cluster_profile, dependencies, env, test (chain:
openshift-upgrade-qe-sanity-disconnected) and workflow
(cucushift-installer-rehearse-...) entries; ensure the remaining profile retains
its original keys (cron, steps, dependencies, env, test, workflow) and no
duplicate stable-to-stable chain is left.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 5a2a2b7c-6f56-437c-bea5-1f4f98e67ec5
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (9)
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-nightly-5.0-upgrade-from-stable-4.22.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-nightly-5.0-upgrade-from-stable-5.0.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-stable-5.0-upgrade-from-stable-4.22.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__arm64-nightly-5.0-upgrade-from-stable-4.22.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__arm64-nightly-5.0-upgrade-from-stable-5.0.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__arm64-stable-5.0-upgrade-from-stable-4.22.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__multi-nightly-5.0-upgrade-from-stable-4.22.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__multi-nightly-5.0-upgrade-from-stable-5.0.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__multi-stable-5.0-upgrade-from-stable-4.22.yaml
🚧 Files skipped from review as they are similar to previous changes (6)
- ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__multi-nightly-5.0-upgrade-from-stable-4.22.yaml
- ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-stable-5.0-upgrade-from-stable-4.22.yaml
- ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__multi-nightly-5.0-upgrade-from-stable-5.0.yaml
- ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__arm64-nightly-5.0-upgrade-from-stable-4.22.yaml
- ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-nightly-5.0-upgrade-from-stable-5.0.yaml
- ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-nightly-5.0-upgrade-from-stable-4.22.yaml
Comment on lines
+132
to
+179
| - as: metal-upi-ovn-ipv4-f60 | ||
| capabilities: | ||
| - intranet | ||
| cron: 14 8 8 2,4,6,8,10,12 * | ||
| steps: | ||
| cluster_profile: equinix-ocp-metal-qe | ||
| dependencies: | ||
| OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE: release:arm64-latest | ||
| OPENSHIFT_UPGRADE_RELEASE_IMAGE_OVERRIDE: release:arm64-target | ||
| env: | ||
| AUX_HOST: openshift-qe-metal-ci.arm.eng.rdu2.redhat.com | ||
| architecture: arm64 | ||
| masters: "3" | ||
| workers: "2" | ||
| test: | ||
| - chain: openshift-upgrade-qe-test | ||
| workflow: baremetal-lab-upi | ||
| - as: metal-ds-ipi-ovn-ipv4-f999 | ||
| capabilities: | ||
| - intranet | ||
| cron: 8 8 29 2 * | ||
| steps: | ||
| cluster_profile: equinix-ocp-metal-qe | ||
| dependencies: | ||
| OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE: release:arm64-latest | ||
| OPENSHIFT_UPGRADE_RELEASE_IMAGE_OVERRIDE: release:arm64-target | ||
| env: | ||
| ARCHITECTURE: arm64 | ||
| NVME_DEVICE: /dev/nvme1n1 | ||
| test: | ||
| - chain: openshift-upgrade-qe-test | ||
| workflow: cucushift-installer-rehearse-baremetalds-ipi-ovn | ||
| - as: gcp-ipi-disc-priv-oidc-mini-perm-f60 | ||
| cron: 31 9 6 1,3,5,7,9,11 * | ||
| steps: | ||
| cluster_profile: gcp-qe | ||
| dependencies: | ||
| OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE: release:arm64-latest | ||
| OPENSHIFT_UPGRADE_RELEASE_IMAGE_OVERRIDE: release:arm64-target | ||
| env: | ||
| COMPUTE_NODE_TYPE: t2a-standard-4 | ||
| ENABLE_MIN_PERMISSION_FOR_STS: "true" | ||
| EXTRACT_MANIFEST_INCLUDED: "true" | ||
| GCP_INSTALL_USE_MINIMAL_PERMISSIONS: "yes" | ||
| OCP_ARCH: arm64 | ||
| test: | ||
| - chain: openshift-upgrade-qe-test-disconnected | ||
| workflow: cucushift-installer-rehearse-gcp-ipi-disconnected-private-cco-manual-workload-identity |
Contributor
There was a problem hiding this comment.
Sort tests entries alphabetically by as name.
The sequence is not alphabetical (for example, gcp-... appears after metal-..., and metal-ds-... should come before metal-upi-...).
As per coding guidelines, "Ensure all jobs are ordered alphabetically in upgrade configuration files".
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__arm64-nightly-5.0-upgrade-from-stable-5.0.yaml`
around lines 132 - 179, The jobs under the top-level list must be sorted
alphabetically by their "as" name; reorder the three job entries so
"gcp-ipi-disc-priv-oidc-mini-perm-f60" and "metal-ds-ipi-ovn-ipv4-f999" and
"metal-upi-ovn-ipv4-f60" appear in strict ascending alphabetical order (place
the "metal-ds-ipi-ovn-ipv4-f999" block before "metal-upi-ovn-ipv4-f60" and
ensure "gcp-..." is positioned appropriately), preserving each job's internal
fields (capabilities, cron, steps, dependencies, env, test, workflow) intact and
without modifying keys or values.
Comment on lines
+91
to
+92
| - chain: openshift-upgrade-qe-sanity-disconnected | ||
| workflow: cucushift-installer-rehearse-aws-ipi-disconnected-private-cco-manual-security-token-service-private-s3-with-ep-sts-ec2-elb |
Contributor
There was a problem hiding this comment.
Use a non-disconnected profile/chain for chain upgrade coverage.
Both jobs are currently mapped to disconnected chain variants, which violates the chain-upgrade profile policy.
As per coding guidelines, "Don't use disconnected profiles for chain upgrade jobs".
Also applies to: 107-108
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__arm64-stable-5.0-upgrade-from-stable-4.22.yaml`
around lines 91 - 92, The chain field is set to a disconnected variant (chain:
openshift-upgrade-qe-sanity-disconnected) while the workflow is a chain-upgrade
job; change the chain to a non-disconnected profile (for example use
openshift-upgrade-qe-sanity or the standard chain-upgrade chain) so the job no
longer uses a disconnected profile, and apply the same change to the other
occurrence referenced (the similar block at the second occurrence around the
file). Ensure the chain value matches the non-disconnected naming convention
used by other chain-upgrade jobs.
Contributor
Author
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-5.0-amd64-nightly-5.0-upgrade-from-stable-5.0-azure-ipi-marketplace-mini-perm-f60 periodic-ci-openshift-openshift-tests-private-release-5.0-multi-nightly-5.0-upgrade-from-stable-4.22-aws-ipi-sno-lvms-arm-f28 periodic-ci-openshift-openshift-tests-private-release-5.0-arm64-stable-5.0-upgrade-from-stable-4.22-azure-ipi-disc-fullyprivate-f28 |
Contributor
|
@dis016: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Contributor
Author
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-5.0-amd64-nightly-5.0-upgrade-from-stable-5.0-azure-ipi-marketplace-mini-perm-f60 periodic-ci-openshift-openshift-tests-private-release-5.0-multi-nightly-5.0-upgrade-from-stable-4.22-aws-ipi-sno-lvms-arm-f28 periodic-ci-openshift-openshift-tests-private-release-5.0-arm64-stable-5.0-upgrade-from-stable-4.22-azure-ipi-disc-fullyprivate-f28 |
Contributor
|
@dis016: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
dis016
force-pushed
the
OTA-1921_add_yz_stream_jobs
branch
from
June 15, 2026 08:22
9d6ee6e to
9aa1443
Compare
Contributor
Author
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-5.0-amd64-nightly-5.0-upgrade-from-stable-5.0-azure-ipi-marketplace-mini-perm-f60 periodic-ci-openshift-openshift-tests-private-release-5.0-multi-nightly-5.0-upgrade-from-stable-4.22-aws-ipi-sno-lvms-arm-f28 periodic-ci-openshift-openshift-tests-private-release-5.0-arm64-stable-5.0-upgrade-from-stable-4.22-azure-ipi-disc-fullyprivate-f28 |
Contributor
|
@dis016: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Contributor
Author
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-5.0-amd64-nightly-5.0-upgrade-from-stable-5.0-azure-ipi-marketplace-mini-perm-f60 periodic-ci-openshift-openshift-tests-private-release-5.0-multi-nightly-5.0-upgrade-from-stable-4.22-aws-ipi-sno-lvms-arm-f28 periodic-ci-openshift-openshift-tests-private-release-5.0-arm64-stable-5.0-upgrade-from-stable-4.22-azure-ipi-disc-fullyprivate-f28 |
Contributor
|
@dis016: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
dis016
force-pushed
the
OTA-1921_add_yz_stream_jobs
branch
from
July 8, 2026 18:06
9aa1443 to
85cf30f
Compare
Contributor
Author
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-5.0-amd64-nightly-5.0-upgrade-from-stable-5.0-azure-ipi-marketplace-mini-perm-f60 periodic-ci-openshift-openshift-tests-private-release-5.0-multi-nightly-5.0-upgrade-from-stable-4.22-aws-ipi-sno-lvms-arm-f28 periodic-ci-openshift-openshift-tests-private-release-5.0-arm64-stable-5.0-upgrade-from-stable-4.22-azure-ipi-disc-fullyprivate-f28 |
Contributor
|
[REHEARSALNOTIFIER]
A total of 338 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
Contributor
|
@dis016: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Contributor
Author
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-5.0-arm64-stable-5.0-upgrade-from-stable-4.22-azure-ipi-disc-fullyprivate-f28 |
Contributor
|
@dis016: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Contributor
Author
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-5.0-multi-nightly-5.0-upgrade-from-stable-4.22-metal-upi-ovn-ipv4-arm-f28 |
Contributor
|
@dis016: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Contributor
Author
|
/Pj-rehearse periodic-ci-openshift-openshift-tests-private-release-5.0-arm64-nightly-5.0-upgrade-from-stable-4.22-aws-ipi-disc-priv-sts-ep-mini-perm-f28 |
Contributor
Author
Contributor
|
@dis016: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Contributor
Author
Contributor
Author
|
/pj-rehearse ack |
Contributor
|
@dis016: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
Contributor
Author
|
/cc @wking @hongkailiu |
Member
Contributor
Author
|
@wking with these jobs we are mostly concentrating on the overall upgrade related steps, component related upgrade failures will be automatically assigned to component teams in qe private deck. mostly they will fix those in their test steps which upgrade team is not maintaining. |
wking
approved these changes
Jul 30, 2026
Member
There was a problem hiding this comment.
I'm not all that clear on if/how we are going to maintain this approach going forward. But there aren't many rehearsal failures, and the failures we see are acceptable, so I'm fine with this merging as it stands for 5.0. And we can have a longer discussion about what happens for 5.1 later.
/lgtm
Contributor
Author
|
/assign @mffiedler |
Contributor
Author
|
/cc @mffiedler pls approve the PR to add the jobs. |
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dis016, mffiedler, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
openshift-merge-bot
Bot
merged commit Aug 11, 2026
6d1b108
into
openshift:main
16 of 20 checks passed
This was referenced Aug 13, 2026
TimurMP
pushed a commit
to TimurMP/release
that referenced
this pull request
Sep 5, 2026
* OTA-1921_add_5.0_yz_stream_jobs * generated jobs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OTA-1921 Add 5.0 Y/Z stream Jobs
Summary
This PR adds comprehensive CI job configurations for OpenShift 5.0 Y/Z stream testing (referencing OTA-1921). It introduces 9 new release configuration files for the
openshift-tests-privaterepository covering:These configurations add 338 total test jobs across multiple cloud platforms (AWS, Azure, GCP, IBM Cloud, Nutanix, vSphere, Equinix metal) with various deployment scenarios including:
Each configuration specifies release targeting, base image references, resource requirements, and detailed test job scheduling with cron timing and platform-specific environment variables. The jobs leverage existing upgrade workflow chains and test scenarios to validate OpenShift upgrade paths between release versions and streams.