ci-operator/templates/openshift: specify version - #2559
Conversation
The installer is soon going to require that the install config specifies its version. This change won't have any effect in the meantime.
|
I went to double-check the location running a build from your PR, and I don't see the new field? $ openshift-install version
openshift-install v0.9.0-master-10-g28a1d59cdb1531a6c9d3538b89d75b8c300953e6
$ openshift-install --dir ver create install-config
? SSH Public Key <none>
? Platform aws
? Region us-east-1
? Base Domain coreservices.team.coreos.systems
? Cluster Name wking
? Pull Secret [? for help] ***...***
$ grep apiVersion ver/install-config.yaml
# no hits? |
|
@wking I realized that last night. I still have to make a modification to the Installer PR to ensure that that field is populated. |
|
/lgtm We'll still need approval from the Ansible folks. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, sdodson, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@crawford: Updated the following 3 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The installer is soon going to require that the install config specifies
its version. This change won't have any effect in the meantime.