Skip to content

Update the gcp-kubernetes-e2e job for o/k to be optional - #10556

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
marun:make-kube-e2e-optional
Jul 30, 2020
Merged

Update the gcp-kubernetes-e2e job for o/k to be optional#10556
openshift-merge-robot merged 1 commit into
openshift:masterfrom
marun:make-kube-e2e-optional

Conversation

@marun

@marun marun commented Jul 30, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@kikisdeliveryservice

Copy link
Copy Markdown
Contributor

I don't think my lgtm works here but since this is blocking openshift/kubernetes#300 which might fix CI a lot why not try! 😹

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2020
@bparees

bparees commented Jul 30, 2020

Copy link
Copy Markdown
Contributor

Why don't we expect this job to pass on k8s prs?

@bparees

bparees commented Jul 30, 2020

Copy link
Copy Markdown
Contributor

Seems like a job we'd want to require so k8s updates don't break upgrades, whether it was optional before or not, why is optional the right setting?

@marun

marun commented Jul 30, 2020

Copy link
Copy Markdown
Contributor Author

Seems like a job we'd want to require so k8s updates don't break upgrades, whether it was optional before or not, why is optional the right setting?

@bparees This job has never passed, it's new as part of the hyperkube transition from origin to openshift/kubernetes. I renamed it recently when I switched it to run on gcp instead of aws and the rename made it required because I forgot that jobs need to be manually set optional post-generation (yay footgun).

Getting the job passing will require porting the annotation rules from origin to o/k, which is something I'm working on.

@bparees

bparees commented Jul 30, 2020

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, kikisdeliveryservice, marun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2020
@openshift-merge-robot
openshift-merge-robot merged commit 6a3de2c into openshift:master Jul 30, 2020
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@marun: Updated the following 2 configmaps:

  • job-config-master configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-kubernetes-master-presubmits.yaml using file ci-operator/jobs/openshift/kubernetes/openshift-kubernetes-master-presubmits.yaml
  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-kubernetes-master-presubmits.yaml using file ci-operator/jobs/openshift/kubernetes/openshift-kubernetes-master-presubmits.yaml
Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marun
marun deleted the make-kube-e2e-optional branch February 1, 2021 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants