Update the gcp-kubernetes-e2e job for o/k to be optional - #10556
Conversation
|
I don't think my lgtm works here but since this is blocking openshift/kubernetes#300 which might fix CI a lot why not try! 😹 /lgtm |
|
Why don't we expect this job to pass on k8s prs? |
|
Seems like a job we'd want to require so k8s updates don't break upgrades, whether it was optional before or not, why is optional the right setting? |
@bparees This job has never passed, it's new as part of the hyperkube transition from origin to openshift/kubernetes. I renamed it recently when I switched it to run on gcp instead of aws and the rename made it required because I forgot that jobs need to be manually set optional post-generation (yay footgun). Getting the job passing will require porting the annotation rules from origin to o/k, which is something I'm working on. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, kikisdeliveryservice, marun The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@marun: Updated the following 2 configmaps:
DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.