Skip to content

NOJIRA: fix(auditloganalyzer): increase cao watch limit#31410

Open
LucasAndFlores wants to merge 1 commit into
openshift:mainfrom
LucasAndFlores:increase-count-tracking-cao
Open

NOJIRA: fix(auditloganalyzer): increase cao watch limit#31410
LucasAndFlores wants to merge 1 commit into
openshift:mainfrom
LucasAndFlores:increase-count-tracking-cao

Conversation

@LucasAndFlores

@LucasAndFlores LucasAndFlores commented Jul 22, 2026

Copy link
Copy Markdown

According to this thread in slack, we agreed that will be necessary to increase the limits of the cluster-autoscaler-operator watcher. For more information, please, take a look into the thread

Summary by CodeRabbit

  • Bug Fixes
    • Increased the configured watch limit for highly available AWS clusters using the cluster autoscaler operator from 91 to 100.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci
openshift-ci Bot requested review from p0lyn0mial and sjenning July 22, 2026 10:32
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 311ca88e-c9a4-43ae-95e0-fc3ea97a2bc5

📥 Commits

Reviewing files that changed from the base of the PR and between c367745 and 8af02da.

📒 Files selected for processing (1)
  • pkg/monitortests/kubeapiserver/auditloganalyzer/operator_watch_limits.json

Walkthrough

The AWS HighlyAvailable profile’s cluster-autoscaler-operator watch limit is increased from 91 to 100 in the audit log analyzer configuration.

Changes

Operator watch limit update

Layer / File(s) Summary
Update AWS HighlyAvailable limit
pkg/monitortests/kubeapiserver/auditloganalyzer/operator_watch_limits.json
The cluster-autoscaler-operator watch limit changes from 91 to 100 for the HighlyAvailable AWS profile.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the change: increasing the cluster-autoscaler-operator watch limit in auditloganalyzer.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only operator_watch_limits.json changed; no Ginkgo test titles were added or modified.
Test Structure And Quality ✅ Passed Only operator_watch_limits.json changed; no Ginkgo test code or test logic was modified, so the check is not applicable.
Microshift Test Compatibility ✅ Passed PR only changes a JSON watch-limit value; no new or modified Ginkgo tests or MicroShift-relevant APIs were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only a JSON watch-limit value changed; no Ginkgo tests or topology-sensitive code were added.
Topology-Aware Scheduling Compatibility ✅ Passed PR only changes the audit log analyzer watch-limit JSON; no deployment manifests, controllers, or scheduling constraints were introduced.
Ote Binary Stdout Contract ✅ Passed PR only edits a JSON watch-limit entry; no process-level code or stdout logging was added.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo tests were added; this PR only changes a JSON watch-limit value, so the IPv4/disconnected-network check is not applicable.
No-Weak-Crypto ✅ Passed Only change is a JSON watch-limit update (91→100) for cluster-autoscaler-operator; no crypto algorithms, custom crypto, or secret comparisons are present.
Container-Privileges ✅ Passed Only operator_watch_limits.json changed, updating a single numeric watch limit; no K8s/container privilege fields or manifests were modified.
No-Sensitive-Data-In-Logs ✅ Passed The only change is a numeric watch-limit update in a JSON fixture; no logging or sensitive-data fields were added.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Jul 22, 2026
@elmiko

elmiko commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

/test verify

is 100 the minimum number of watches we need?

@joelsmith

Copy link
Copy Markdown
Contributor

is 100 the minimum number of watches we need?

We didn't do a full analysis, only an analysis of what we added lately (which was 2) so in chatting with Lucas yesterday I recommended 100 to give us a little headroom. If we need to be more deliberate about it, we could spend some more time analyzing.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@elmiko

elmiko commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

chatted about new limit on slack, i'm good with this.
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2026
@openshift-ci

openshift-ci Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: elmiko, LucasAndFlores
Once this PR has been reviewed and has the lgtm label, please assign jogeo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

@LucasAndFlores: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6 8af02da link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-vsphere-ovn 8af02da link true /test e2e-vsphere-ovn
ci/prow/e2e-aws-ovn-fips 8af02da link true /test e2e-aws-ovn-fips
ci/prow/e2e-gcp-ovn 8af02da link true /test e2e-gcp-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants