NOJIRA: fix(auditloganalyzer): increase cao watch limit#31410
NOJIRA: fix(auditloganalyzer): increase cao watch limit#31410LucasAndFlores wants to merge 1 commit into
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughThe AWS ChangesOperator watch limit update
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/test verify is 100 the minimum number of watches we need? |
We didn't do a full analysis, only an analysis of what we added lately (which was 2) so in chatting with Lucas yesterday I recommended 100 to give us a little headroom. If we need to be more deliberate about it, we could spend some more time analyzing. |
|
Scheduling required tests: |
|
chatted about new limit on slack, i'm good with this. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: elmiko, LucasAndFlores The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@LucasAndFlores: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
According to this thread in slack, we agreed that will be necessary to increase the limits of the cluster-autoscaler-operator watcher. For more information, please, take a look into the thread
Summary by CodeRabbit