METAL-1902: Remove exception for co/baremetal on Progressing

[iurygregory]

This commit remove the exception for co/baremetal because of the bug OCPBUGS-66101.

Summary by CodeRabbit

• Bug Fixes
  • Updated cluster upgrade monitoring so previously allowlisted progressing-state transitions for bare-metal clusters are now reported as failures when they do not match expected behavior.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@iurygregory: This pull request references METAL-1902 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

This commit remove the exception for co/baremetal because of the bug OCPBUGS-66101.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: fb8f7f4a-47c0-47ae-90cf-0f0d6f62a8cd

📥 Commits

Reviewing files that changed from the base of the PR and between 478b8a2 and 79915ef.

📒 Files selected for processing (1)

• pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go

💤 Files with no reviewable changes (1)

• pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go

---

Walkthrough

The progressing-state transition test removes the exception branch for the baremetal cluster operator, causing matching transitions to be evaluated as failures unless another exception applies.

Changes

Cluster version operator tests

Layer / File(s)	Summary
Remove baremetal progressing exception pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go	Removes the baremetal exception mapping from progressing-state transition validation.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Test Structure And Quality	❓ Inconclusive	placeholder	Need to inspect the changed test file and surrounding Ginkgo patterns before judging quality.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the PR’s main change: removing the baremetal Progressing exception.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR only removes a baremetal exception mapping; no Ginkgo titles were added or changed, and the affected code contains static junit names only.
Microshift Test Compatibility	✅ Passed	No new Ginkgo tests were added; the diff only removes a baremetal exception in existing monitor test logic, so this check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Only a monitor-test exception was removed; no new Ginkgo e2e tests or SNO-sensitive logic were added.
Topology-Aware Scheduling Compatibility	✅ Passed	The only change is a test exception removal in operator monitoring logic; it adds no scheduling constraints or topology-dependent pod placement.
Ote Binary Stdout Contract	✅ Passed	Only the baremetal exception string was removed from test logic; no stdout-writing APIs or process-level setup code were added.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added; the PR only removes a baremetal exception mapping in a monitor/junit helper, so the IPv6/disconnected check is not applicable.
No-Weak-Crypto	✅ Passed	Diff only removes a baremetal test exception; no weak-crypto primitives, custom crypto, or secret comparisons were added.
Container-Privileges	✅ Passed	Only a Go test file changed; no container/K8s manifests or security context fields were added or modified.
No-Sensitive-Data-In-Logs	✅ Passed	PR only removes a baremetal exception URL from test logic; no new log statements or sensitive fields are added.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: iurygregory
Once this PR has been reviewed and has the lgtm label, please assign sosiouxme for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[iurygregory]

/retest-required

[openshift-ci]

@iurygregory: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-ovn	79915ef	link	true	/test e2e-gcp-ovn
ci/prow/e2e-metal-ipi-ovn-ipv6	79915ef	link	true	/test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-ovn-fips	79915ef	link	true	/test e2e-aws-ovn-fips

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[iurygregory]

/retest-required