OCPBUGS-99166: wait for default ServiceAccount before creating IRI test pod by andfasano · Pull Request #31401 · openshift/origin

andfasano · 2026-07-20T09:36:27Z

CreateSimpleNamespace waited for SCC annotations but not for the default ServiceAccount, causing a race on ha5 clusters where the service-account-controller is slower to provision it.

Assisted-by: claude

Summary by CodeRabbit

Bug Fixes
- Improved test environment setup by waiting for the default service account to become available when creating namespaces.
- Added cleanup handling when service account creation does not complete successfully.

CreateSimpleNamespace waited for SCC annotations but not for the default ServiceAccount, causing a race on ha5 clusters where the service-account-controller is slower to provision it. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

openshift-merge-bot · 2026-07-20T09:36:30Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

openshift-ci-robot · 2026-07-20T09:36:34Z

@andfasano: This pull request references Jira Issue OCPBUGS-99166, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (5.0.0) matches configured target version for branch (5.0.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

CreateSimpleNamespace waited for SCC annotations but not for the default ServiceAccount, causing a race on ha5 clusters where the service-account-controller is slower to provision it.

Assisted-by: claude

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-07-20T09:37:24Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 09208f74-df10-41e9-97c0-6abdd588bf55

📥 Commits

Reviewing files that changed from the base of the PR and between 478b8a2 and acc268c.

📒 Files selected for processing (1)

test/extended/internalreleaseimage/helper.go

Walkthrough

CreateSimpleNamespace now waits for the namespace’s default ServiceAccount after namespace creation and cleans up the namespace if the wait times out.

Changes

Namespace readiness

Layer / File(s)	Summary
Wait for default ServiceAccount `test/extended/internalreleaseimage/helper.go`	`CreateSimpleNamespace` waits for the default `ServiceAccount`, deletes the namespace on failure, and reports a timeout-specific expectation.

Estimated code review effort: 2 (Simple) | ~5 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: waiting for the default ServiceAccount before creating the IRI test pod.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The diff only updates helper logic; no Ginkgo It/Describe/Context/When titles were added or changed.
Test Structure And Quality	✅ Passed	The change keeps existing test patterns: the SA wait has a 3m timeout, failure paths delete the namespace, and the caller still defers namespace cleanup.
Microshift Test Compatibility	✅ Passed	No new Ginkgo tests were added; existing cases are tagged [apigroup:machineconfiguration.openshift.io], and the new wait only uses core Namespace/ServiceAccount APIs.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The change only waits for the default ServiceAccount before creating a pod; it adds no multi-node or HA assumption, and the test body has no SNO-unsafe topology checks.
Topology-Aware Scheduling Compatibility	✅ Passed	Only a test helper changed to wait for the default ServiceAccount; no manifests, controllers, affinity, node selectors, or replica logic were added.
Ote Binary Stdout Contract	✅ Passed	Changed helper only adds WaitForServiceAccount; no fmt.Print/log-to-stdout/klog use appears in process-level code.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR only adds a default ServiceAccount wait in a helper; it adds no new Ginkgo test logic or IPv4/external-connectivity assumptions.
No-Weak-Crypto	✅ Passed	The only changed helper adds a ServiceAccount wait; the file has no weak-crypto APIs, custom crypto, or secret comparisons.
Container-Privileges	✅ Passed	No privileged, host*, SYS_ADMIN, root, or allowPrivilegeEscalation settings were added; the only change waits for the default ServiceAccount.
No-Sensitive-Data-In-Logs	✅ Passed	The only added code waits for the default ServiceAccount and adds no sensitive logging; no passwords, tokens, PII, or internal hostnames are introduced.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

openshift-ci-robot · 2026-07-20T09:37:57Z

@andfasano: This pull request references Jira Issue OCPBUGS-99166, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (5.0.0) matches configured target version for branch (5.0.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

CreateSimpleNamespace waited for SCC annotations but not for the default ServiceAccount, causing a race on ha5 clusters where the service-account-controller is slower to provision it.

Assisted-by: claude

Summary by CodeRabbit

Bug Fixes

Improved test environment setup by waiting for the default service account to become available when creating namespaces.

Added cleanup handling when service account creation does not complete successfully.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

andfasano · 2026-07-20T09:38:14Z

/test ?

andfasano · 2026-07-20T09:38:32Z

/test e2e-agent-compact-ipv4-iso-no-registry

bfournie · 2026-07-20T11:09:55Z

/lgtm

openshift-ci · 2026-07-20T11:10:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, bfournie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~test/extended/internalreleaseimage/OWNERS~~ [andfasano,bfournie]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

andfasano · 2026-07-20T11:17:50Z

/label acknowledge-critical-fixes-only

andfasano · 2026-07-20T12:08:43Z

/verified by @andfasano

openshift-ci-robot · 2026-07-20T12:08:56Z

@andfasano: This PR has been marked as verified by @andfasano.

Details

In response to this:

/verified by @andfasano

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

andfasano · 2026-07-20T13:54:58Z

/retest-required

openshift-merge-bot · 2026-07-20T14:25:21Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

andfasano · 2026-07-20T21:39:59Z

/retest-required

openshift-merge-bot · 2026-07-21T02:17:03Z

/retest-required

Remaining retests: 0 against base HEAD 1f0ad8b and 2 for PR HEAD acc268c in total

openshift-merge-bot · 2026-07-21T06:17:00Z

/retest-required

Remaining retests: 0 against base HEAD 3cae547 and 1 for PR HEAD acc268c in total

andfasano · 2026-07-21T08:16:35Z

/test e2e-aws-ovn-microshift

petr-muller · 2026-07-21T10:57:09Z

/override ci/prow/e2e-aws-ovn-microshift

openshift-ci · 2026-07-21T10:57:25Z

@petr-muller: Overrode contexts on behalf of petr-muller: ci/prow/e2e-aws-ovn-microshift

Details

In response to this:

/override ci/prow/e2e-aws-ovn-microshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2026-07-21T11:42:21Z

@andfasano: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2026-07-21T11:43:59Z

@andfasano: Jira Issue Verification Checks: Jira Issue OCPBUGS-99166
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-99166 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

CreateSimpleNamespace waited for SCC annotations but not for the default ServiceAccount, causing a race on ha5 clusters where the service-account-controller is slower to provision it.

Assisted-by: claude

Summary by CodeRabbit

Bug Fixes

Improved test environment setup by waiting for the default service account to become available when creating namespaces.

Added cleanup handling when service account creation does not complete successfully.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

…ollowup OCPBUGS-99166: wait for default ServiceAccount before creating IRI test pod

openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jul 20, 2026

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jul 20, 2026

openshift-ci Bot requested review from bfournie and rwsu July 20, 2026 09:38

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2026

coderabbitai Bot approved these changes Jul 20, 2026

View reviewed changes

openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Jul 20, 2026

openshift-ci Bot assigned bfournie Jul 20, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2026

openshift-ci Bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Jul 20, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jul 20, 2026

bfournie mentioned this pull request Jul 20, 2026

[release-4.22]AGENT-1549: Backport NoRegistryClusterInstall feature to release-4.22 #31406

Merged

openshift-merge-bot Bot merged commit d09034c into openshift:main Jul 21, 2026
23 checks passed

pawanpinjarkar pushed a commit to pawanpinjarkar/origin that referenced this pull request Jul 21, 2026

Merge pull request openshift#31401 from andfasano/fix-iri-namespace-f…

af74ff2

…ollowup OCPBUGS-99166: wait for default ServiceAccount before creating IRI test pod

Uh oh!

Conversation

andfasano commented Jul 20, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

openshift-merge-bot Bot commented Jul 20, 2026

Uh oh!

openshift-ci-robot commented Jul 20, 2026

Uh oh!

coderabbitai Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

openshift-ci-robot commented Jul 20, 2026

Summary by CodeRabbit

Uh oh!

andfasano commented Jul 20, 2026

Uh oh!

andfasano commented Jul 20, 2026

Uh oh!

bfournie commented Jul 20, 2026

Uh oh!

openshift-ci Bot commented Jul 20, 2026

Uh oh!

andfasano commented Jul 20, 2026

Uh oh!

andfasano commented Jul 20, 2026

Uh oh!

openshift-ci-robot commented Jul 20, 2026

Uh oh!

andfasano commented Jul 20, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 20, 2026

Uh oh!

andfasano commented Jul 20, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 21, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 21, 2026

Uh oh!

andfasano commented Jul 21, 2026

Uh oh!

petr-muller commented Jul 21, 2026

Uh oh!

openshift-ci Bot commented Jul 21, 2026

Uh oh!

openshift-ci Bot commented Jul 21, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Jul 21, 2026

Summary by CodeRabbit

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

andfasano commented Jul 20, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 20, 2026 •

edited

Loading