AGENT-1527: Fix comparison of InternalReleaseImage to mirror#31250
Conversation
The IRI image should be compared against the mirrors in the IDMS, not the source.
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
openshift-ci-robot
added
the
jira/valid-reference
|
@bfournie: This pull request references AGENT-1527 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughThe PR modifies ChangesIDMS validation expansion
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 13 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (13 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
Bot
added
the
approved
|
With this fix we see the test run successfully |
|
/cc @pawanpinjarkar |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/extended/internalreleaseimage/helper.go`:
- Line 97: The log message at the e2e.Logf call that currently reads "Verifying
image repo is present in image-digest-mirror IDMS: %s" is outdated; update the
string to reflect that the function now scans all ImageDigestMirrorSets (e.g.,
"Verifying image repo is present in all ImageDigestMirrorSets: %s") so
diagnostics are accurate—modify the e2e.Logf invocation that references
releaseImage accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 16be2634-9c90-4a5e-9576-d38339d5bad3
📒 Files selected for processing (1)
test/extended/internalreleaseimage/helper.go
| // VerifyIDMSConfigured verifies that the test image repo is present in the image-digest-mirror IDMS | ||
| // VerifyIDMSConfigured verifies that the test image repo is present as a mirror in at least one IDMS | ||
| func (h *IRITestHelper) VerifyIDMSConfigured(releaseImage string) { | ||
| e2e.Logf("Verifying image repo is present in image-digest-mirror IDMS: %s", releaseImage) |
There was a problem hiding this comment.
Update the verification log text to match the new all-IDMS scan.
The log still says image-digest-mirror IDMS, but this function now scans all ImageDigestMirrorSets. Keeping this message current will avoid misleading test diagnostics.
Suggested diff
- e2e.Logf("Verifying image repo is present in image-digest-mirror IDMS: %s", releaseImage)
+ e2e.Logf("Verifying image repo is present as a mirror in at least one ImageDigestMirrorSet: %s", releaseImage)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| e2e.Logf("Verifying image repo is present in image-digest-mirror IDMS: %s", releaseImage) | |
| e2e.Logf("Verifying image repo is present as a mirror in at least one ImageDigestMirrorSet: %s", releaseImage) |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@test/extended/internalreleaseimage/helper.go` at line 97, The log message at
the e2e.Logf call that currently reads "Verifying image repo is present in
image-digest-mirror IDMS: %s" is outdated; update the string to reflect that the
function now scans all ImageDigestMirrorSets (e.g., "Verifying image repo is
present in all ImageDigestMirrorSets: %s") so diagnostics are accurate—modify
the e2e.Logf invocation that references releaseImage accordingly.
|
/test ? |
|
Scheduling required tests: |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bfournie, pawanpinjarkar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified later by @pawanpinjarkar and ove periodic jobs |
|
@pawanpinjarkar: Only users can be targets for the DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified later by @pawanpinjarkar |
|
@pawanpinjarkar: Only users can be targets for the DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified later @pawanpinjarkar |
|
@pawanpinjarkar: This PR has been marked to be verified later by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
verified
|
@bfournie: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
AGENT-1527: Fix comparison of InternalReleaseImage to mirror
3 participants
The IRI image should be compared against the mirrors in the IDMS, not the source.
Summary by CodeRabbit